From: Kito Cheng <kito.cheng@gmail.com>
To: "Maciej W. Rozycki" <macro@embecosm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Andrew Waterman <andrew@sifive.com>
Subject: Re: [PATCH] RISC-V: Remove duplicate backslashes from `stack_protect_set_<mode>'
Date: Wed, 27 Jul 2022 01:12:36 +0800 [thread overview]
Message-ID: <CA+yXCZApCLbvLFmPRxJZ+q1HUzxzLjFa-7f8dijMpr_J81Go=A@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.2207261746530.10833@tpp.orcam.me.uk>
Hi Maciej:
Ooops, thanks for fixing that, the change was gotten from kernel
folks. I assume they have already used that for a while, but it's
really weird no bug report from those guys...
OK for trunk and backport for release branch.
On Wed, Jul 27, 2022 at 1:00 AM Maciej W. Rozycki <macro@embecosm.com> wrote:
>
> Remove redundant duplicate backslash characters from \t sequences in the
> output pattern of the `stack_protect_set_<mode>' RTL insn.
>
> gcc/
> * gcc/config/riscv/riscv.md (stack_protect_set_<mode>): Remove
> duplicate backslashes.
> ---
> Hi,
>
> I don't know why it doesn't matter whether the backslash is duplicated
> here or not, but output produced in insn-output.cc is the same either way,
> with lone \t sequences present, so remove these extraneous backslashes for
> consistency. Even this very output pattern does not have this duplication
> present in the final LI instruction.
>
> OK to apply?
>
> Maciej
> ---
> gcc/config/riscv/riscv.md | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> gcc-riscv-stack-protect-tab.diff
> Index: gcc/gcc/config/riscv/riscv.md
> ===================================================================
> --- gcc.orig/gcc/config/riscv/riscv.md
> +++ gcc/gcc/config/riscv/riscv.md
> @@ -2851,7 +2851,7 @@
> UNSPEC_SSP_SET))
> (set (match_scratch:GPR 2 "=&r") (const_int 0))]
> ""
> - "<load>\\t%2, %1\;<store>\\t%2, %0\;li\t%2, 0"
> + "<load>\t%2, %1\;<store>\t%2, %0\;li\t%2, 0"
> [(set_attr "length" "12")])
>
> (define_expand "stack_protect_test"
next prev parent reply other threads:[~2022-07-26 17:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 16:59 Maciej W. Rozycki
2022-07-26 17:12 ` Kito Cheng [this message]
2022-07-27 10:28 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+yXCZApCLbvLFmPRxJZ+q1HUzxzLjFa-7f8dijMpr_J81Go=A@mail.gmail.com' \
--to=kito.cheng@gmail.com \
--cc=andrew@sifive.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=macro@embecosm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).