From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id 0EDE23858D32 for ; Tue, 26 Jul 2022 17:12:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0EDE23858D32 Received: by mail-ej1-x629.google.com with SMTP id va17so27403465ejb.0 for ; Tue, 26 Jul 2022 10:12:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=cM+OyJD6u+lxcCFcWScItSTgka4Gjz15i7G2cr+4bAg=; b=eXbEIjz2g0IZ+lLNGMj5yUP/enFo7UE3sqe1bAHvDEStS8iuqrRoglA6jk+CneU8QB gP1W8//lbG+kBZZIYIQxWSmHjk1LhHEkJHmM5YZANp73hY3bDLttkU8Ga1rpHfcTM3bO kMGIKS/KAojlHBxGYdQ7tRn8iyMcSxx0ztY22SMq7bSrJeacBMxrBOn/2buCLXbsVqQz IXWS27CM6pRbXC5Ftd8PbiM0u0I5sZfzrXcDnWA11uhseyuUPszOJdE75uOfr5wuliD7 AV/snR9VByl1n6eaOPb4nRyAaXpzmEmtY0BFucPn4SJ6ux0wCPpNbgZzKY3I6lk/9SNa K/rg== X-Gm-Message-State: AJIora/dCKt/vgFlmoeRoqmuKJPC4nWoz5bDF4Y4RTAz7K9oMYo76WyQ wFbeUvljIwqvFN6yOO9XOiiOyyJtrsymdm0jkjo= X-Google-Smtp-Source: AGRyM1vapNuHUuR3AHF8Legh4JZyLLffREYBXb0scnqGb0KPxPCear7pX3gfn3KZ9TaNMUOyc272TVmdZ6NfKLEEPSY= X-Received: by 2002:a17:907:c14:b0:72b:6762:de34 with SMTP id ga20-20020a1709070c1400b0072b6762de34mr14820602ejc.94.1658855567574; Tue, 26 Jul 2022 10:12:47 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Kito Cheng Date: Wed, 27 Jul 2022 01:12:36 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Remove duplicate backslashes from `stack_protect_set_' To: "Maciej W. Rozycki" Cc: GCC Patches , Andrew Waterman Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jul 2022 17:12:53 -0000 Hi Maciej: Ooops, thanks for fixing that, the change was gotten from kernel folks. I assume they have already used that for a while, but it's really weird no bug report from those guys... OK for trunk and backport for release branch. On Wed, Jul 27, 2022 at 1:00 AM Maciej W. Rozycki wrote: > > Remove redundant duplicate backslash characters from \t sequences in the > output pattern of the `stack_protect_set_' RTL insn. > > gcc/ > * gcc/config/riscv/riscv.md (stack_protect_set_): Remove > duplicate backslashes. > --- > Hi, > > I don't know why it doesn't matter whether the backslash is duplicated > here or not, but output produced in insn-output.cc is the same either way, > with lone \t sequences present, so remove these extraneous backslashes for > consistency. Even this very output pattern does not have this duplication > present in the final LI instruction. > > OK to apply? > > Maciej > --- > gcc/config/riscv/riscv.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > gcc-riscv-stack-protect-tab.diff > Index: gcc/gcc/config/riscv/riscv.md > =================================================================== > --- gcc.orig/gcc/config/riscv/riscv.md > +++ gcc/gcc/config/riscv/riscv.md > @@ -2851,7 +2851,7 @@ > UNSPEC_SSP_SET)) > (set (match_scratch:GPR 2 "=&r") (const_int 0))] > "" > - "\\t%2, %1\;\\t%2, %0\;li\t%2, 0" > + "\t%2, %1\;\t%2, %0\;li\t%2, 0" > [(set_attr "length" "12")]) > > (define_expand "stack_protect_test"