From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe2f.google.com (mail-vs1-xe2f.google.com [IPv6:2607:f8b0:4864:20::e2f]) by sourceware.org (Postfix) with ESMTPS id 16DDC3858423 for ; Thu, 10 Nov 2022 01:03:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 16DDC3858423 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vs1-xe2f.google.com with SMTP id 128so307035vsz.12 for ; Wed, 09 Nov 2022 17:03:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dt0YckJvygQwaxnkU/KJCaOOqN1zzGxZKZfzrDuiRgs=; b=fEoXkpQ+Zpksq1HoNGYAfdqCjLaKXAO2I9tOk0ykGrfrWZLmUZDjDKNThi2+1gxzhD 4Nft2q1slJDONU/y44sMJ/pEODPPB6wSoz6vBEC+9knKWoerqrTo8HNOwvOA20Genvws Kb4dLjPq5sXRtP4BXipAS0w19rTYas1uOcZwLI0Nu1IFMqvZxx5ZQKGmWJdNac7EOLhu IG8U+AyL0OFKR1zAlV7BXoCRo4WzPLU0Nttl6ygt1iDps0yDcYhfV55R2z3X4PzHw8z3 ID67PmOJ5qhIYy+a2UtOq6j2Jr9szBZ67qulkbFlcmhCjUphPOePRnyxO0w8gL6icLC8 iOZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dt0YckJvygQwaxnkU/KJCaOOqN1zzGxZKZfzrDuiRgs=; b=VAplBrmJOXAkb1dynxxh0YmWtPl73tGXfB09AMZgBWn8Rbq8JFv/Zve87ZnXUBRTNr 9/XvsnEWd0PoRJ7Ge0V7ra7akrXjogaiXoMWC/WBuNR1mu9LlVh2dFS6t+UjWo1je5mo N7qhYSfhzQx7vq8+Hbq2JzI9DQEWQCZjjgfjEOkbYPlxpj+WLU4IFdW0RZg/+4K+TYk/ EaJKTTWGX5FD8amKxsiGWCZkgm9GADIci+5xgrhPunisRmbSNw9z7wpDYfDpkR+3pNwM 0ZwHKpmodX/F0VLbXxmPzs8vzqNx8n0YcoI6m4whNHbBOA3SZl+ECPScus573n8ruJpH cvVA== X-Gm-Message-State: ACrzQf30L3SQ+pNTHN94gdZbmhT+IKEwfVW/LyA1PUiLRmEwsW2xBuJl PGsd5ichyi126K2X7d9W8pwf8K9JDni26VoKuxs= X-Google-Smtp-Source: AMsMyM5iN6mREQWZjdBACPZ4u38yb6oXHe2NDn3HSYyrw3h0OTmKdY47HejbLok1cPR2Sv3CrfFgKd15kskmycX+JJM= X-Received: by 2002:a05:6102:2457:b0:3aa:16ab:5987 with SMTP id g23-20020a056102245700b003aa16ab5987mr1928874vss.40.1668042200195; Wed, 09 Nov 2022 17:03:20 -0800 (PST) MIME-Version: 1.0 References: <20221109234948.3279391-1-philipp.tomsich@vrull.eu> In-Reply-To: <20221109234948.3279391-1-philipp.tomsich@vrull.eu> From: Kito Cheng Date: Wed, 9 Nov 2022 17:03:08 -0800 Message-ID: Subject: Re: [PATCH] RISC-V: Fix selection of pipeline model for sifive-7-series To: Philipp Tomsich Cc: gcc-patches@gcc.gnu.org, Palmer Dabbelt , Christoph Muellner , Jeff Law Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: LGTM, thank you for catching that!! On Wed, Nov 9, 2022 at 3:50 PM Philipp Tomsich wrote: > > A few of the gcc.target/riscv/mcpu-*.c tests have been failing for a > while now, due to the pipeline model for sifive-7-series not being > selected despite -mtune=sifive-7-series. The root cause is that the > respective RISCV_TUNE entry points to generic instead. Fix this. > > Fixes 97d1ed67fc6 ("RISC-V: Support --target-help for -mcpu/-mtune") > > gcc/ChangeLog: > > * config/riscv/riscv-cores.def (RISCV_TUNE): Update > sifive-7-series to point to the sifive_7 pipeline > description. > > Signed-off-by: Philipp Tomsich > --- > > gcc/config/riscv/riscv-cores.def | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/riscv/riscv-cores.def b/gcc/config/riscv/riscv-cores.def > index b84ad999ac1..31ad34682c5 100644 > --- a/gcc/config/riscv/riscv-cores.def > +++ b/gcc/config/riscv/riscv-cores.def > @@ -36,7 +36,7 @@ > RISCV_TUNE("rocket", generic, rocket_tune_info) > RISCV_TUNE("sifive-3-series", generic, rocket_tune_info) > RISCV_TUNE("sifive-5-series", generic, rocket_tune_info) > -RISCV_TUNE("sifive-7-series", generic, sifive_7_tune_info) > +RISCV_TUNE("sifive-7-series", sifive_7, sifive_7_tune_info) > RISCV_TUNE("thead-c906", generic, thead_c906_tune_info) > RISCV_TUNE("size", generic, optimize_size_tune_info) > > -- > 2.34.1 >