From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id 70F6F3858D20 for ; Mon, 29 Jan 2024 12:32:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 70F6F3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 70F6F3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706531576; cv=none; b=Z4Qbc4gaSCfPmR9n/Lixj3ZrzjJc12504OiRDDH/Z3zBq6bjc6WLgJ3llHhbQ2RMslLe6Pg22QfL9Y9yZkU0+/Y6AD8vmNpw+woeDEOF10Tvv7HdzpJAOFjFCT2bH+7Kdh098PRtrHv/hZl/ug1yGlE5iy6rRceKfcvMHEGlhKM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706531576; c=relaxed/simple; bh=bDt+F50WR/aNE67GZeAWo2LLlcofzyUAcf00aY1Dqv8=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=ved92ZWgO5B30U5WCi/1Zno6NxBGi0hxWsjjvjcDRYzcMJcldh/AwgyZyVfIXlYyfM+FZijutHsQ8SBFj4TLDjzNR0SXXssimftWf8KON+FI//JDWa3TJ7aPwdZNnuPLVwxoBBmWcuhLxbKEgcXZvi4nl2eUAyD7d//myhSbWtM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-a35e1b735a9so68201666b.2 for ; Mon, 29 Jan 2024 04:32:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706531573; x=1707136373; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+qxd0UBCq6C68hzystPQ36hTDOqpE+bzxbF3MsNf7mk=; b=ZjA16y8cbsAgPzjEKiC//v3h7C2ivzqLUcWpkSrOoy6f1dFfVoms1sW0In5m0gVixO eNTBmie5G5ytSIe3+k+t1euz1Fe4X515H3GYQCwHP0RlmTV6kyZgwDRztuXfzwOhPwMe XzVrnlGybVb1wksN6JzGic+IUveQNdtwsVfYQ/tiE6qA2qcrULAusle1Hwts5QgkY94z LgIxosgPc4P0odeIe9eKYquA5JaIWNkBBvWoy9Z9PnUgc0sA3bJD0T8l+mozyw9VV/X4 jqeWaom1G5FcPj7qSVSad/F330AXwZx/tEVRSXWyiEYH9beT47RtW++FNie85AukTZha QlUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706531573; x=1707136373; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+qxd0UBCq6C68hzystPQ36hTDOqpE+bzxbF3MsNf7mk=; b=wZrqN0531w7jxbOD4nJnVfaVyjJXVKlpP01MCO4m3TwB9wfr6OovbnPddGasmpVCBN W8+T4e9w1dq0pBHFHVviVDsoHEapmf9BOh2LRkYRfgWP5EvJ18GI5ExhB5xwsjNX8dXh eT2+SntfK8BWEYk8gLxeEk7mV8Cqvpm1CnWaMaVPhbdF4ESo/bmsMgkYAq3PQ9lnEoV2 3NZpTqXOV9O7Xqh+InT8CIYxaXcDmzPmgnZcmUzdIfeDfFPc6TTob8jzmRmUSFWnM9Do 5ePruypQaNg37bxVDcQ5V2qUKx7gjRVooP3J1Smbzyt8X1j5DvkywBqd9va/qd+zu6bR RImQ== X-Gm-Message-State: AOJu0Yx+JWNDGUdSzlaKpJaDfzkV+Lkw451vM6idIyAcuTvGlmk1MGkN xzUix8CL17SaBOcOqHD5zMTHc6f/Tu2hFPlWObZwP/RrtkN3KBeETOZ8XdtJ4jF0zLmEdUOnkHJ Z98BvDhPdsDiPMhSkafiSzFo/1I8= X-Google-Smtp-Source: AGHT+IGhjaud/ahONr7HyQGa7AHiyK0+aBjiLe5BVZDyMx/gIgpCY198p2eZABqC8t5CvQ33x0BWmrMnByJHK0WbXFg= X-Received: by 2002:a17:906:4157:b0:a35:f46b:6e50 with SMTP id l23-20020a170906415700b00a35f46b6e50mr417124ejk.35.1706531572591; Mon, 29 Jan 2024 04:32:52 -0800 (PST) MIME-Version: 1.0 References: <20240129092016.1176-1-jinma@linux.alibaba.com> <20240129095700.1245-1-jinma@linux.alibaba.com> In-Reply-To: <20240129095700.1245-1-jinma@linux.alibaba.com> From: Kito Cheng Date: Mon, 29 Jan 2024 20:32:39 +0800 Message-ID: Subject: Re: [PATCH v2] RISC-V: THEAD: Fix improper immediate value for MODIFY_DISP instruction on 32-bit systems. To: Jin Ma Cc: GCC Patches , Jeff Law , Palmer Dabbelt , "richard.sandiford" , =?UTF-8?Q?Christoph_M=C3=BCllner?= , Robin Dapp , =?UTF-8?B?6ZKf5bGF5ZOy?= , "jinma.contrib" Content-Type: multipart/alternative; boundary="0000000000002eae24061014d8a2" X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000002eae24061014d8a2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable LGTM Jin Ma =E6=96=BC 2024=E5=B9=B41=E6=9C=8829=E6=97= =A5 =E9=80=B1=E4=B8=80 17:57 =E5=AF=AB=E9=81=93=EF=BC=9A > When using '%ld' to print 'long long int' variable, 'fprintf' will > produce messy output on a 32-bit system, in an incorrect instruction > being generated, such as 'th.lwib a1,(a0),-16,4294967295'. And the > following error occurred during compilation: > > Assembler messages: > Error: improper immediate value (18446744073709551615) > > gcc/ChangeLog: > > * config/riscv/thead.cc (th_print_operand_address): Change %ld > to %lld. > --- > gcc/config/riscv/thead.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/riscv/thead.cc b/gcc/config/riscv/thead.cc > index 2955bc5f8a9..e4b8c37bc28 100644 > --- a/gcc/config/riscv/thead.cc > +++ b/gcc/config/riscv/thead.cc > @@ -1141,7 +1141,7 @@ th_print_operand_address (FILE *file, machine_mode > mode, rtx x) > return true; > > case ADDRESS_REG_WB: > - fprintf (file, "(%s),%ld,%u", reg_names[REGNO (addr.reg)], > + fprintf (file, "(%s),"HOST_WIDE_INT_PRINT_DEC",%u", reg_names[REGNO > (addr.reg)], > INTVAL (addr.offset) >> addr.shift, addr.shift); > return true; > > -- > 2.17.1 > > --0000000000002eae24061014d8a2--