From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x92e.google.com (mail-ua1-x92e.google.com [IPv6:2607:f8b0:4864:20::92e]) by sourceware.org (Postfix) with ESMTPS id BA2C43858C83 for ; Mon, 28 Feb 2022 15:57:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BA2C43858C83 Received: by mail-ua1-x92e.google.com with SMTP id 10so6209114uar.9 for ; Mon, 28 Feb 2022 07:57:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Hu5fnCdZrUt/U1yMMVWfLTo+hU4ekcvl+uuAyTRQjew=; b=P6Se81PNxewHns6n12BVMoYm0WLIumx5SxFDPJJTMuYr6lwcaNLsL9bE+XUMGWkN/6 UH9Gjmbzwzb2/lGZKUheHnpUUIX301hQqs6bvDS99JF7oqTvDhqjtS0XchXi2KD/+9ew u8O5fMwA6fywQVkvwHxBcIxaCN07BYSurg4bs5eOVKmEJ6RFIHSJkjBaJvOIG94Z0bP/ RZ10j0inV+PtriWGuLupYPL/qWYz6F7m+igWqTQEs18PFm2dS9Q+RT0hl/4MhKKJLkp8 EGWnMt3hRKoLvbL9sZ2znsl4FRynpS4oquvoqsB8Q8J/7n0sDJQH0alzO/no/gx0VfJi MftQ== X-Gm-Message-State: AOAM531uueGhR7Jrlgz3h05aPfnshX4Zudq9w8RH2tAGRQrCLeHbJpSb fbsvp6jc1f+/h7NnmXD4kM3PeY+f38T8ihlj/mo= X-Google-Smtp-Source: ABdhPJzGC98Aq+Sd1Pv5bGZQydZvP+EDAfjMyrEc8rUaxebiUTpUBXx/LYWN+qK6u6ElnZdLBsIFuWak+5z/Qfqno/c= X-Received: by 2002:ab0:7e4b:0:b0:341:2c61:b9a3 with SMTP id e11-20020ab07e4b000000b003412c61b9a3mr7538660uax.88.1646063830230; Mon, 28 Feb 2022 07:57:10 -0800 (PST) MIME-Version: 1.0 References: <20220223094418.3518-1-shihua@iscas.ac.cn> <20220223094418.3518-6-shihua@iscas.ac.cn> In-Reply-To: From: Kito Cheng Date: Mon, 28 Feb 2022 23:56:58 +0800 Message-ID: Subject: Re: [PATCH 5/5 V1] RISC-V:Implement architecture extension test macros for Crypto extension To: shihua@iscas.ac.cn Cc: GCC Patches , ben.marshall@pqshield.com, Christoph Muellner , Andrew Waterman , jiawei , mjos@iki.fi, Kito Cheng Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=1.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNWANTED_LANGUAGE_BODY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Feb 2022 15:57:12 -0000 and could you separate this from this patch series, I would like to include this into GCC 12, and defer other stuffs to GCC 13 On Thu, Feb 24, 2022 at 5:55 PM Kito Cheng wrote: > > I would suggest implementing that in riscv_subset_list::parse so that > it also affect the ELF attribute emission. > > On Wed, Feb 23, 2022 at 5:44 PM wrote: > > > > From: LiaoShihua > > > > gcc/ChangeLog: > > > > * config/riscv/riscv-c.cc (riscv_cpu_cpp_builtins):Add __riscv_zks, __riscv_zk, __riscv_zkn > > > > gcc/testsuite/ChangeLog: > > > > * gcc.target/riscv/predef-17.c: New test. > > > > --- > > gcc/config/riscv/riscv-c.cc | 9 ++++ > > gcc/testsuite/gcc.target/riscv/predef-17.c | 59 ++++++++++++++++++++++ > > 2 files changed, 68 insertions(+) > > create mode 100644 gcc/testsuite/gcc.target/riscv/predef-17.c > > > > diff --git a/gcc/config/riscv/riscv-c.cc b/gcc/config/riscv/riscv-c.cc > > index 73c62f41274..d6c153e8d7c 100644 > > --- a/gcc/config/riscv/riscv-c.cc > > +++ b/gcc/config/riscv/riscv-c.cc > > @@ -63,6 +63,15 @@ riscv_cpu_cpp_builtins (cpp_reader *pfile) > > builtin_define ("__riscv_fdiv"); > > builtin_define ("__riscv_fsqrt"); > > } > > + > > + if (TARGET_ZBKB && TARGET_ZBKC && TARGET_ZBKX && TARGET_ZKNE && TARGET_ZKND && TARGET_ZKNH) > > + { > > + builtin_define ("__riscv_zk"); > > + builtin_define ("__riscv_zkn"); > > + } > > + > > + if (TARGET_ZBKB && TARGET_ZBKC && TARGET_ZBKX && TARGET_ZKSED && TARGET_ZKSH) > > + builtin_define ("__riscv_zks"); > > > > switch (riscv_abi) > > { > > diff --git a/gcc/testsuite/gcc.target/riscv/predef-17.c b/gcc/testsuite/gcc.target/riscv/predef-17.c > > new file mode 100644 > > index 00000000000..4366dee1016 > > --- /dev/null > > +++ b/gcc/testsuite/gcc.target/riscv/predef-17.c > > @@ -0,0 +1,59 @@ > > +/* { dg-do compile } */ > > +/* { dg-options "-march=rv64i_zbkb_zbkc_zbkx_zknd_zkne_zknh_zksed_zksh -mabi=lp64 -mcmodel=medlow -misa-spec=2.2" } */ > > + > > +int main () { > > + > > +#ifndef __riscv_arch_test > > +#error "__riscv_arch_test" > > +#endif > > + > > +#if __riscv_xlen != 64 > > +#error "__riscv_xlen" > > +#endif > > + > > +#if !defined(__riscv_i) > > +#error "__riscv_i" > > +#endif > > + > > +#if !defined(__riscv_zk) > > +#error "__riscv_zk" > > +#endif > > + > > +#if !defined(__riscv_zkn) > > +#error "__riscv_zkn" > > +#endif > > + > > +#if !defined(__riscv_zks) > > +#error "__riscv_zks" > > +#endif > > + > > +#if !defined(__riscv_zbkb) > > +#error "__riscv_zbkb" > > +#endif > > + > > +#if !defined(__riscv_zbkc) > > +#error "__riscv_zbkc" > > +#endif > > + > > +#if !defined(__riscv_zbkx) > > +#error "__riscv_zbkx" > > +#endif > > + > > +#if !defined(__riscv_zknd) > > +#error "__riscv_zknd" > > +#endif > > + > > +#if !defined(__riscv_zkne) > > +#error "__riscv_zkne" > > +#endif > > + > > +#if !defined(__riscv_zknh) > > +#error "__riscv_zknh" > > +#endif > > + > > +#if !defined(__riscv_zksh) > > +#error "__riscv_zksh" > > +#endif > > + > > + return 0; > > +} > > \ No newline at end of file > > -- > > 2.31.1.windows.1 > >