From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x92f.google.com (mail-ua1-x92f.google.com [IPv6:2607:f8b0:4864:20::92f]) by sourceware.org (Postfix) with ESMTPS id D51263858D1E for ; Tue, 18 Apr 2023 15:44:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D51263858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ua1-x92f.google.com with SMTP id l13so5175487uan.10 for ; Tue, 18 Apr 2023 08:44:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681832676; x=1684424676; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kfJhcUg596PQckTeErYMUjwbgGqAg/QJ4BgOft6IH6s=; b=c90F6AA/JQUTJArBJK74YR+zwLdy+pHGrIFB4yAzLK1YWXuJnVPfM95HVmT5bkKtax iXk3JGEWduiw4FqcnKp7Stkc6xoT8cPa11pJwroGXD+i6ReIHVQioKUT/FGa1EjWb2ew LdU0WFHMNr2rdt+MevJRQSf3YFNu4/S4iqaT/4OYqs3NC4dsK+xprO+XW+5u36RkT8tu VtL/DcKeMIUcXfi0g+gs1ewIHXpkDFOWYunQFNP0lyZtDsOkrNO0kjf8WZXtCJ8O1+Yt 5DNKu44XZFmjhgZXcyZCcrvBMTC5DppruWms0lQ090EuNb17+Z1wzmkxjSKJiZa99dWK cANA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681832676; x=1684424676; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kfJhcUg596PQckTeErYMUjwbgGqAg/QJ4BgOft6IH6s=; b=QzomkCzSs4t4EnIvnNDNKO7zuzsEKXDRa73T0E58pUnfk/UFdnkqSdBWyblMuHbVmN XEFM00iS4scx5IG2HsNFaojs9n7kTzuiIscIW7h5HbRA4aIC0bmvIBKl3/T8qv9ztnT2 Nmki7Fv8eR6EgZ4bDMgsOLrwdK8GSikEzU+pSC+vkN6z9yX2JhbQzp3IWbB9KR7OMGeZ JxxYmmvug3+vqb2tBb8Oq89414XhgDqnro95YLJW6QAC+0NEpxh0RjXfv8mPOqJ6Ryso iuhHok+KY/cZIYlXtgFVxBCm8+KgXI2Md5qrZrm1HXoX+k9fhKesw1M3ebfrySw/cVlV +FOQ== X-Gm-Message-State: AAQBX9cERR4b42yecqXlxnTxASj2nK6EgfhQCPUSNh2rHpyCEEwed2nm tCplyy1XP3eKzgnYevQDaiBxl3ujAHEBolt3nIw= X-Google-Smtp-Source: AKy350YryVDup2OAt3sw07BxVlhJIMTLqXIqlVwf4lkLuBZRXIQolb4pKg1DOOlQ/hMYmcLxKW8uErex3N0JoLKFm10= X-Received: by 2002:a1f:5f57:0:b0:43f:b70d:562b with SMTP id t84-20020a1f5f57000000b0043fb70d562bmr6147116vkb.9.1681832675811; Tue, 18 Apr 2023 08:44:35 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Kito Cheng Date: Tue, 18 Apr 2023 23:44:24 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Update multilib-generator to handle V To: Palmer Dabbelt Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Yep, if I drop the non-canonicial strings via > > diff --git a/gcc/config/riscv/multilib-generator b/gcc/config/riscv/multilib-generator > index 58b7198b243..a63a4d69c18 100755 > --- a/gcc/config/riscv/multilib-generator > +++ b/gcc/config/riscv/multilib-generator > @@ -174,7 +174,7 @@ for cmodel in cmodels: > ext_combs = expand_combination(ext) > alts = sum([[x] + [x + y for y in ext_combs] for x in [arch] + extra], []) > alts = filter(lambda x: len(x) != 0, alts) > - alts = alts + list(map(lambda a : arch_canonicalize(a, args.misa_spec), alts)) > + alts = list(map(lambda a : arch_canonicalize(a, args.misa_spec), alts)) > > # Drop duplicated entry. > alts = unique(alts) > > then I can't link `-march=rv32imafdcv`, I need > `-march=rv32imacv_zicsr_zve32f_zve32x_zve64x_zvl128b_zvl32b_zvl64b`. That's > kind of a headache for users to type in. Yes, that's a headache for users, but arch string canonicalization is hiddened at the process, so the user could still just use rv32imafdcv at compile time and multi-lib config. And the driver and multilib-generator (with arch_canonicalize) script will handle those headache in the background.