From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe2b.google.com (mail-vs1-xe2b.google.com [IPv6:2607:f8b0:4864:20::e2b]) by sourceware.org (Postfix) with ESMTPS id B993F3858D33 for ; Mon, 16 Jan 2023 13:38:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B993F3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vs1-xe2b.google.com with SMTP id n190so25149966vsc.11 for ; Mon, 16 Jan 2023 05:38:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=SqC+pXgswTRV3k3K0Lh0P+G7e1+fwYvz4GHUDUAMpf8=; b=n8d+d/RZRdzYf63LmfYL0duT8XcI7NUDUpRcwbJS1BL02I1KRd7iNK5W2WHSHvJVNy OBG+R6TavfI4xSsULcQn1dYdmdnGepANV9mQ8iP7dr++ZJRgB7NpwJwDEHfTKPGJH9B1 C4UT/4APJTeRBKcsPSz3z+omL1YIarGGKIAUnI9KFL6l5pxiVuMGcoqmRWXNngt8dGR+ zxvwoPyBowWhI8eiEsEO6yI5OXJEpYraqFR6E2Kk86nUY/3lkKpQuv9POP/UKJUQhN9n ZzigE0AHdVqHGn23TOHaLXMU10UUgkQ8DFoIubuRtaPBuPMuBAdkDcFCH8BYPXKScOPE oaRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SqC+pXgswTRV3k3K0Lh0P+G7e1+fwYvz4GHUDUAMpf8=; b=TLCbxWKRkT/ykuhWyLJN45kV+dkT7NlekXYcO2q/6BkSXcN1otGMtwda6CJzw0KVkW 55PwMfZoiafgAU18AeM2L1uDgSjSxjT5AgJXZYDDIV21jZH24aA/pTdPJ1RDiY/RCBb3 cHt/GwHSckw8962EQlCpBj6+pPeJUeLjr5W9hJ3XY7jPhp2mdO23ZL3HSyqaW+SZsBd2 dVALFxNisf5T3uaFxwNPYDJaV+DsAra7d88u7AvmAVMcGAjxpcpmLnUE7tcoB18/14Zc WakBcZOuKD00yjCerwH5Z1zJk8otrKgBvfRa+1aktabv2MJne31dOmywcOQI/swrMSF3 ROpQ== X-Gm-Message-State: AFqh2kqxiO+uwOZxOwUSr3SdBKS6opD1aqK09jqrB5FJioEjPw+oKeY5 3ZjOlNfnq/SNWhFR3h69VZ7UGuUJrYx3Nu/53Jcdkmmt X-Google-Smtp-Source: AMrXdXt/F0NXnDbBqxw6Jrsb4QvX9OBbOLr8YnAUhpqaQddJqfBP3RcGIcCB8ItOXcV+6YxtozroFKn8KKyrFbBg3yw= X-Received: by 2002:a05:6102:21ad:b0:3d0:a76b:b50a with SMTP id i13-20020a05610221ad00b003d0a76bb50amr4220774vsb.30.1673876327869; Mon, 16 Jan 2023 05:38:47 -0800 (PST) MIME-Version: 1.0 References: <20230109232057.156867-1-juzhe.zhong@rivai.ai> In-Reply-To: <20230109232057.156867-1-juzhe.zhong@rivai.ai> From: Kito Cheng Date: Mon, 16 Jan 2023 21:38:36 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Call DCE to remove redundant instructions created by the PASS To: juzhe.zhong@rivai.ai Cc: gcc-patches@gcc.gnu.org, palmer@dabbelt.com Content-Type: multipart/alternative; boundary="000000000000ebb58505f261b3c8" X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000ebb58505f261b3c8 Content-Type: text/plain; charset="UTF-8" After discussing with Ju.Zhe, we decided to rearrange the pass of vsetvl insertion instead of call run_fast_dce within this pass. On Tue, Jan 10, 2023 at 7:21 AM wrote: > From: Ju-Zhe Zhong > > gcc/ChangeLog: > > * config/riscv/riscv-vsetvl.cc (pass_vsetvl::done): Add DCE. > * config/riscv/t-riscv: Add DCE. > > --- > gcc/config/riscv/riscv-vsetvl.cc | 2 ++ > gcc/config/riscv/t-riscv | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/gcc/config/riscv/riscv-vsetvl.cc > b/gcc/config/riscv/riscv-vsetvl.cc > index 7d8c3a32aaa..7aa2852b456 100644 > --- a/gcc/config/riscv/riscv-vsetvl.cc > +++ b/gcc/config/riscv/riscv-vsetvl.cc > @@ -87,6 +87,7 @@ along with GCC; see the file COPYING3. If not see > #include "predict.h" > #include "profile-count.h" > #include "riscv-vsetvl.h" > +#include "dce.h" > > using namespace rtl_ssa; > using namespace riscv_vector; > @@ -2627,6 +2628,7 @@ pass_vsetvl::done (void) > cleanup_cfg (0); > delete crtl->ssa; > crtl->ssa = nullptr; > + run_fast_dce (); > } > m_vector_manager->release (); > delete m_vector_manager; > diff --git a/gcc/config/riscv/t-riscv b/gcc/config/riscv/t-riscv > index d30e0235356..c95f4aff358 100644 > --- a/gcc/config/riscv/t-riscv > +++ b/gcc/config/riscv/t-riscv > @@ -54,7 +54,7 @@ riscv-c.o: $(srcdir)/config/riscv/riscv-c.cc $(CONFIG_H) > $(SYSTEM_H) \ > riscv-vsetvl.o: $(srcdir)/config/riscv/riscv-vsetvl.cc \ > $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) $(RTL_H) $(REGS_H) \ > $(TARGET_H) tree-pass.h df.h rtl-ssa.h cfgcleanup.h insn-config.h \ > - insn-attr.h insn-opinit.h tm-constrs.h cfgrtl.h cfganal.h lcm.h \ > + insn-attr.h insn-opinit.h tm-constrs.h cfgrtl.h cfganal.h lcm.h dce.h \ > predict.h profile-count.h $(srcdir)/config/riscv/riscv-vsetvl.h > $(COMPILER) -c $(ALL_COMPILERFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) \ > $(srcdir)/config/riscv/riscv-vsetvl.cc > -- > 2.36.1 > > --000000000000ebb58505f261b3c8--