From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id F37693857000 for ; Wed, 26 Oct 2022 09:02:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F37693857000 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52f.google.com with SMTP id y69so21368338ede.5 for ; Wed, 26 Oct 2022 02:02:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=enLp6t2MeO+X/ND1Ru4Y0yHvB9He6heVKcib6w3Ud9Y=; b=U814Uv2D5KFQ8wpONOYdriXW4tPyuP8ffNd6+NG6SJqBKzojXMcs5PVhAS/1apm/9w zMAbQn8osq0jlgiteBN64zJAV79NsLvpmvkW6jIUM/RwO11vTkgcziow/5GNvzUJ1XFJ B2DlzK7JcuHBdgGhN2xjiFDbbu8tzvd8n/AcUJfcOC3O6sl0GViw4X5UJzP60EwKWXSb wmEcoz/BGRfuKWPUOLiIHDbvGhEqMsdsmBTRF+mdGrh42U+bYeP6hRyupjTZhNpE+t0l sKuP1GG0ROLzLb4Qc0N2TTiGLde+j2q+gG2ob/YjWVrpQBb1wm2rtozEI3jYP+fw+F/l cjqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=enLp6t2MeO+X/ND1Ru4Y0yHvB9He6heVKcib6w3Ud9Y=; b=fM5CKDsdzbdvbKinX3fT+ivGhbmm1DkpiRU6q0fvTFsjPkjVYFDA+J7mdPHuKBRDya 9dDmpGjRpGYjkl51qnDEkwxDDhFOe8tW9rvUzjQeVPnNPUs/LJaP3lAUyKnUc+K6W5oM k6+M/6UuSLIWBY20CDgazzlTP0c1/3ImTMsgLNxNquYJjWanhFwT4O4KCSRK5+tRhAdq kvTxNgKlYR9pVZSjAIfcrsoGK1QLYsYnJ6yXAzXsTApIXiQQKwVrYz9f2IEIF79aI8f2 pEQePU0W8VIiAMbmEHUQLqZ2WI5PJFFrVMF7m9Qx7IExsT+0nFzZlCOCE6UGkLWMi1kJ LFuA== X-Gm-Message-State: ACrzQf3aDb9ad3lIKjIgSu6S+0fNIHS5IE/Fu8CnG9Cno0FNSCQ7e08k z11KmirPAfEwvOfW0wF0CWkRoy1jo0Vuiwjt16aToNSD X-Google-Smtp-Source: AMsMyM6NFrSutvm8tGaVmY6TkARdxZW6uGF01bT7oNgTO2AV/qMIuMxtKkU+esIGOKmfSfSgtaeWfrAwNghMUCPW3ho= X-Received: by 2002:a05:6402:249f:b0:453:eb1b:1f8b with SMTP id q31-20020a056402249f00b00453eb1b1f8bmr39032634eda.235.1666774961624; Wed, 26 Oct 2022 02:02:41 -0700 (PDT) MIME-Version: 1.0 References: <20221025135323.98303-1-juzhe.zhong@rivai.ai> In-Reply-To: <20221025135323.98303-1-juzhe.zhong@rivai.ai> From: Kito Cheng Date: Wed, 26 Oct 2022 17:02:29 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Fix a mistake in previous patch. To: juzhe.zhong@rivai.ai Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Committed with title tweak, thanks On Tue, Oct 25, 2022 at 9:53 PM wrote: > > From: Ju-Zhe Zhong > > I noticed that I have made a mistake in previous patch: > https://patchwork.sourceware.org/project/gcc/patch/20220817071950.271762-1-juzhe.zhong@rivai.ai/ > > The previous statement before this patch: > bool need_barrier_p = (get_frame_size () + cfun->machine->frame.arg_pointer_offset) != 0; > > However, I changed it in the previous patch: > bool need_barrier_p = known_ne (get_frame_size (), cfun->machine->frame.arg_pointer_offset); > This is incorrect. > > Now, I correct this statement in this patch. > > gcc/ChangeLog: > > * config/riscv/riscv.cc (riscv_expand_epilogue): Fix statement. > > --- > gcc/config/riscv/riscv.cc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc > index 08354a19c05..50ef38438a2 100644 > --- a/gcc/config/riscv/riscv.cc > +++ b/gcc/config/riscv/riscv.cc > @@ -5028,8 +5028,8 @@ riscv_expand_epilogue (int style) > rtx insn; > > /* We need to add memory barrier to prevent read from deallocated stack. */ > - bool need_barrier_p > - = known_ne (get_frame_size (), cfun->machine->frame.arg_pointer_offset); > + bool need_barrier_p = known_ne (get_frame_size () > + + cfun->machine->frame.arg_pointer_offset, 0); > > if (cfun->machine->naked_p) > { > -- > 2.36.1 >