From: Kito Cheng <kito.cheng@gmail.com>
To: Robin Dapp <rdapp.gcc@gmail.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
Jeff Law <jlaw@ventanamicro.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [RFA] [PR target/108248] [RISC-V] Break down some bitmanip insn types
Date: Fri, 21 Apr 2023 16:31:02 +0800 [thread overview]
Message-ID: <CA+yXCZBB01vnB+jokXMuR++odFX44H-QzsRDtYDZr-hZ7jt=zA@mail.gmail.com> (raw)
In-Reply-To: <7d4cc0d3-9ffb-6371-9658-0f93be64276d@gmail.com>
Hi Robin:
OK, Feel free to commit that to trunk.
and don't forgot to mention this:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109582
On Fri, Apr 21, 2023 at 3:45 PM Robin Dapp via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> > ../../gcc/config/riscv/generic.md:28:1: unknown value `smin' for attribute `type'
> > make[3]: *** [Makefile:2528: s-attrtab] Error 1
> >
>
> From 582c428258ce17ffac8ef1b96b4072f3d510480f Mon Sep 17 00:00:00 2001
> From: Robin Dapp <rdapp@ventanamicro.com>
> Date: Fri, 21 Apr 2023 09:38:06 +0200
> Subject: [PATCH] riscv: Fix <bitmanip_insn> fallout.
>
> The adjusted generic.md uses standard names instead of the types defined
> in the <bitmanip_insn> iterator (that match instruction names). Change this.
>
> gcc/ChangeLog:
>
> * config/riscv/generic.md: Change standard names to insn names.
> ---
> gcc/config/riscv/generic.md | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config/riscv/generic.md b/gcc/config/riscv/generic.md
> index db4fabbbd92..2c3376628c3 100644
> --- a/gcc/config/riscv/generic.md
> +++ b/gcc/config/riscv/generic.md
> @@ -27,7 +27,7 @@ (define_cpu_unit "fdivsqrt" "pipe0")
>
> (define_insn_reservation "generic_alu" 1
> (and (eq_attr "tune" "generic")
> - (eq_attr "type" "unknown,const,arith,shift,slt,multi,auipc,nop,logical,move,bitmanip,smin,smax,umin,umax,clz,ctz,cpop"))
> + (eq_attr "type" "unknown,const,arith,shift,slt,multi,auipc,nop,logical,move,bitmanip,min,max,minu,maxu,clz,ctz,cpop"))
> "alu")
>
> (define_insn_reservation "generic_load" 3
> --
> 2.40.0
>
>
prev parent reply other threads:[~2023-04-21 8:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 4:34 Jeff Law
2023-04-20 6:00 ` Kito Cheng
2023-04-21 7:36 ` Andreas Schwab
2023-04-21 7:44 ` Robin Dapp
2023-04-21 8:31 ` Kito Cheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+yXCZBB01vnB+jokXMuR++odFX44H-QzsRDtYDZr-hZ7jt=zA@mail.gmail.com' \
--to=kito.cheng@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jlaw@ventanamicro.com \
--cc=rdapp.gcc@gmail.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).