From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa2e.google.com (mail-vk1-xa2e.google.com [IPv6:2607:f8b0:4864:20::a2e]) by sourceware.org (Postfix) with ESMTPS id 3D75F3858C83 for ; Fri, 21 Apr 2023 08:31:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3D75F3858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vk1-xa2e.google.com with SMTP id 71dfb90a1353d-4404c9d9fceso466382e0c.2 for ; Fri, 21 Apr 2023 01:31:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682065873; x=1684657873; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=F5fuV0v4fhaJHdu1IXT09oXDE5VTwDuvFjskbnFiekA=; b=Lfsp/oUspRJRfVH49M1G2htGefdQZ4z2cjzNDsI8ojJpQ2Ift5OMPQ/+u/1KUFauQR CjMMAQ6gX9Ri3amK5LmAHm/CotqMk6fVrftfifClR//2f0TJ3E/pwWWlXQAsckLVuWVL a771l/nyGzXI15GO4E1rW4cZZMv6ddBJsopQfQOS0r1doRhJYoLx2Dz4lMoQEbHOMOKP 34+qEl8B7Dd2U/3GlV27KIeyVt0rv8DvhW0fw8TsZ3o8UBHaXh6ZsCD5COcArqLldJaL M/7Ja9Niv7sqvUtMgE5pW5ugOXxHSwGzmcxfi35OBDiXQu21YutNfR44PzwcnTGrrnCR pHSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682065873; x=1684657873; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F5fuV0v4fhaJHdu1IXT09oXDE5VTwDuvFjskbnFiekA=; b=ONzGuO5Wz5n1pCkJjgYquNEu8IqekS1mofKTEXa/COGa+7vN9ACcvm5ULe50NAq65t FlYyAFa/eL1ndb5GQBxNKZW1/XzlRxQKyY6UAU1O507obtpQfxLVEjEU4U8cluFSCSHA KStxu5KcYnW9BPtMHasKX8sIgwg+iZA02EEYDFpeOMUdVniHOqUmURPlH+KhwIk+j3yT /bM/XmGEKzAwAW6stDMsDbGovK6seKUw7edhAMNUbBHSrFGfNOy1dib4JMrxMdyVpP5O lshwG8oJxa70Kj8agFGHPdH6UvR/bxvVAUkr/XcV4rajlWxVzn/Bd/jr9PTI2MoIKBBA myfw== X-Gm-Message-State: AAQBX9d2Ei6MAou5yXZ6ZepMCOhUasO+IEE9WNVSyi7wgoXoSQfJfqu8 xR2Z8AoNvJ08cNXXGOqmPCpLC4Zh9Nx/6bmiapQ= X-Google-Smtp-Source: AKy350YwbbNBjHlf1xYLrWf+l/SD1Xkb16cwK7PCuMd3t7jk3SbF5welPfbmOJrTAkjFSM1Ol48ghihREAZkjzzWdZM= X-Received: by 2002:a1f:c1c6:0:b0:440:65a5:332a with SMTP id r189-20020a1fc1c6000000b0044065a5332amr457993vkf.5.1682065873370; Fri, 21 Apr 2023 01:31:13 -0700 (PDT) MIME-Version: 1.0 References: <3ee750e7-d3f5-12cc-4885-bbe2f6290861@ventanamicro.com> <874jp91yc9.fsf@igel.home> <7d4cc0d3-9ffb-6371-9658-0f93be64276d@gmail.com> In-Reply-To: <7d4cc0d3-9ffb-6371-9658-0f93be64276d@gmail.com> From: Kito Cheng Date: Fri, 21 Apr 2023 16:31:02 +0800 Message-ID: Subject: Re: [RFA] [PR target/108248] [RISC-V] Break down some bitmanip insn types To: Robin Dapp Cc: Andreas Schwab , Jeff Law , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Robin: OK, Feel free to commit that to trunk. and don't forgot to mention this: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D109582 On Fri, Apr 21, 2023 at 3:45=E2=80=AFPM Robin Dapp via Gcc-patches wrote: > > > ../../gcc/config/riscv/generic.md:28:1: unknown value `smin' for attrib= ute `type' > > make[3]: *** [Makefile:2528: s-attrtab] Error 1 > > > > From 582c428258ce17ffac8ef1b96b4072f3d510480f Mon Sep 17 00:00:00 2001 > From: Robin Dapp > Date: Fri, 21 Apr 2023 09:38:06 +0200 > Subject: [PATCH] riscv: Fix fallout. > > The adjusted generic.md uses standard names instead of the types defined > in the iterator (that match instruction names). Change t= his. > > gcc/ChangeLog: > > * config/riscv/generic.md: Change standard names to insn names. > --- > gcc/config/riscv/generic.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/riscv/generic.md b/gcc/config/riscv/generic.md > index db4fabbbd92..2c3376628c3 100644 > --- a/gcc/config/riscv/generic.md > +++ b/gcc/config/riscv/generic.md > @@ -27,7 +27,7 @@ (define_cpu_unit "fdivsqrt" "pipe0") > > (define_insn_reservation "generic_alu" 1 > (and (eq_attr "tune" "generic") > - (eq_attr "type" "unknown,const,arith,shift,slt,multi,auipc,nop,lo= gical,move,bitmanip,smin,smax,umin,umax,clz,ctz,cpop")) > + (eq_attr "type" "unknown,const,arith,shift,slt,multi,auipc,nop,lo= gical,move,bitmanip,min,max,minu,maxu,clz,ctz,cpop")) > "alu") > > (define_insn_reservation "generic_load" 3 > -- > 2.40.0 > >