From: Kito Cheng <kito.cheng@gmail.com>
To: Philipp Tomsich <philipp.tomsich@vrull.eu>
Cc: Lin Sinan <mynameisxiaou@gmail.com>,
gcc-patches@gcc.gnu.org, palmer@dabbelt.com, andrew@sifive.com,
Lin Sinan <sinan.lin@linux.alibaba.com>
Subject: Re: [PATCH] RISC-V: Fix wrong partial subreg check for bsetidisi
Date: Sun, 5 Mar 2023 17:27:42 +0800 [thread overview]
Message-ID: <CA+yXCZBH+crM1=VwNmqgmJzwm0V-i0aHf=Y2ses-ZkSi3L_phg@mail.gmail.com> (raw)
In-Reply-To: <CAAeLtUAi9H_0BGP4kSgniSf4xB45bxTSRWN1OwHDf87Mna9zvQ@mail.gmail.com>
Committed, thanks!
On Tue, Feb 28, 2023 at 5:32 PM Philipp Tomsich
<philipp.tomsich@vrull.eu> wrote:
>
> On Tue, 28 Feb 2023 at 06:00, Lin Sinan <mynameisxiaou@gmail.com> wrote:
> >
> > From: Lin Sinan <sinan.lin@linux.alibaba.com>
> >
> > The partial subreg check should be for subreg operand(operand 1) instead of
> > the immediate operand(operand 2). This change also fix pr68648.c in zbs.
>
> Good catch.
> Reviewed-by: <philipp.tomsich@vrull.eu>
prev parent reply other threads:[~2023-03-05 9:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 5:00 Lin Sinan
2023-02-28 5:12 ` Sinan Lin
2023-02-28 9:32 ` Philipp Tomsich
2023-03-05 9:27 ` Kito Cheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+yXCZBH+crM1=VwNmqgmJzwm0V-i0aHf=Y2ses-ZkSi3L_phg@mail.gmail.com' \
--to=kito.cheng@gmail.com \
--cc=andrew@sifive.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mynameisxiaou@gmail.com \
--cc=palmer@dabbelt.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sinan.lin@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).