From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id 2715E383D80F for ; Mon, 30 May 2022 03:50:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2715E383D80F Received: by mail-ej1-x634.google.com with SMTP id jx22so18289744ejb.12 for ; Sun, 29 May 2022 20:50:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8znSd7ihkOq+2VA1H+TMWGqOhFDirMa8Wg4KL4PnQjI=; b=zRaGfh9gozazYaWlBhJhNzPwF1w+kQmHLXoM3Qy4H+XDcsQHQ5G2XgC+3mnj7h6DP+ 7RwAAjlbiGRdz7R4dcSyOuoeaD/wbRvg0n1ns6J+vwX02wsZp6j2y9TSfyvAPH4JrrIB LzTbhYIMGP4cfcsxrhibT5vtHu1hitcPshr7XCcO3VRfyS8+fvTu0z5/m5bXyvpL8Cb3 p8PPocu80ZC/KUR0Ljom8QeWurlgX2NPLS8paPNHx1Zqp4R04DuZ2EASV5mp7FHece+Y Rf5rEzWxoCM9R45x7UW7Q8DkAYVOe4dUJJh/BtpAeOXlagLiWQRWrkisghWqYi/AaABb keiQ== X-Gm-Message-State: AOAM530bGKLemB9/9Wc2faQMss9Ffm7JIF+MzOLxhVds1+Q2YS0fzHje cD8oYsYkFFWzzYdWqXvpz+UM/ahadKwkta6V/kQ= X-Google-Smtp-Source: ABdhPJwaCYqvSMlEKIcMh7kT0oWuyTFeXIWBDx/UD6UG9WmEVd7tS0/0wQrFo72zFo5wHgWYa7KWCaHFlbQialHfHfo= X-Received: by 2002:a17:906:c156:b0:6ff:2415:fc18 with SMTP id dp22-20020a170906c15600b006ff2415fc18mr16501468ejc.94.1653882629735; Sun, 29 May 2022 20:50:29 -0700 (PDT) MIME-Version: 1.0 References: <20220527015646.2220532-1-vineetg@rivosinc.com> <20220527023636.2224696-1-vineetg@rivosinc.com> In-Reply-To: <20220527023636.2224696-1-vineetg@rivosinc.com> From: Kito Cheng Date: Mon, 30 May 2022 11:50:17 +0800 Message-ID: Subject: Re: [PATCH v3] RISC-V/testsuite: constraint some of tests to hard_float To: Vineet Gupta Cc: GCC Patches , "Maciej W . Rozycki" , Andrew Waterman , Philipp Tomsich , gnu-toolchain@rivosinc.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 May 2022 03:50:33 -0000 Committed, thanks! On Fri, May 27, 2022 at 10:37 AM Vineet Gupta wrote: > > Commit 9ddd44b58649d1d ("RISC-V: Provide `fmin'/`fmax' RTL pattern") added > tests which check for hard float instructions which obviously fails on > soft-float ABI builds. > > And my recent commit b646d7d279ae ("RISC-V: Inhibit FP <--> int register > moves via tune param") is guilty of same crime. > > So constraint with "dg-require-effective-target hard_float" > > This reduces bunch of new RV failures. > > | ========= Summary of gcc testsuite ========= > | | # of unexpected case / # of unique unexpected case > | | gcc | g++ | gfortran | > | rv64imac/ lp64/ medlow | 134 / 22 | 0 / 0 | - | BEFORE > | rv64imac/ lp64/ medlow | 22 / 9 | 0 / 0 | - | AFTER > | > > gcc/testsuite/Changelog: > * gcc.target/riscv/fmax.c: Add dg-require-effective-target hard_float. > * gcc.target/riscv/fmaxf.c: Ditto. > * gcc.target/riscv/fmin.c: Ditto. > * gcc.target/riscv/fminf.c: Ditto. > * gcc.target/riscv/smax-ieee.c: Ditto. > * gcc.target/riscv/smax.c: Ditto. > * gcc.target/riscv/smaxf-ieee.c: Ditto. > * gcc.target/riscv/smaxf.c: Ditto. > * gcc.target/riscv/smin-ieee.c: Ditto. > * gcc.target/riscv/smin.c: Ditto. > * gcc.target/riscv/sminf-ieee.c: Ditto. > * gcc.target/riscv/sminf.c: Ditto. > * gcc.target/riscv/pr105666.c: Ditto. > > Signed-off-by: Vineet Gupta > --- > v3: > Added fix to pr105666.c as well. > v2: > Fixed the SoB snafu in v1 > --- > gcc/testsuite/gcc.target/riscv/fmax.c | 1 + > gcc/testsuite/gcc.target/riscv/fmaxf.c | 1 + > gcc/testsuite/gcc.target/riscv/fmin.c | 1 + > gcc/testsuite/gcc.target/riscv/fminf.c | 1 + > gcc/testsuite/gcc.target/riscv/pr105666.c | 1 + > gcc/testsuite/gcc.target/riscv/smax-ieee.c | 1 + > gcc/testsuite/gcc.target/riscv/smax.c | 1 + > gcc/testsuite/gcc.target/riscv/smaxf-ieee.c | 1 + > gcc/testsuite/gcc.target/riscv/smaxf.c | 1 + > gcc/testsuite/gcc.target/riscv/smin-ieee.c | 1 + > gcc/testsuite/gcc.target/riscv/smin.c | 1 + > gcc/testsuite/gcc.target/riscv/sminf-ieee.c | 1 + > gcc/testsuite/gcc.target/riscv/sminf.c | 1 + > 13 files changed, 13 insertions(+) > > diff --git a/gcc/testsuite/gcc.target/riscv/fmax.c b/gcc/testsuite/gcc.target/riscv/fmax.c > index c71d35c9f9dc..e1b7fa8f918c 100644 > --- a/gcc/testsuite/gcc.target/riscv/fmax.c > +++ b/gcc/testsuite/gcc.target/riscv/fmax.c > @@ -1,4 +1,5 @@ > /* { dg-do compile } */ > +/* { dg-require-effective-target hard_float } */ > /* { dg-options "-fno-finite-math-only -fsigned-zeros -fno-signaling-nans -dp" } */ > > double > diff --git a/gcc/testsuite/gcc.target/riscv/fmaxf.c b/gcc/testsuite/gcc.target/riscv/fmaxf.c > index f9980166887a..8da0513dc8f6 100644 > --- a/gcc/testsuite/gcc.target/riscv/fmaxf.c > +++ b/gcc/testsuite/gcc.target/riscv/fmaxf.c > @@ -1,4 +1,5 @@ > /* { dg-do compile } */ > +/* { dg-require-effective-target hard_float } */ > /* { dg-options "-fno-finite-math-only -fsigned-zeros -fno-signaling-nans -dp" } */ > > float > diff --git a/gcc/testsuite/gcc.target/riscv/fmin.c b/gcc/testsuite/gcc.target/riscv/fmin.c > index 9634abd19af8..01993d49bc21 100644 > --- a/gcc/testsuite/gcc.target/riscv/fmin.c > +++ b/gcc/testsuite/gcc.target/riscv/fmin.c > @@ -1,4 +1,5 @@ > /* { dg-do compile } */ > +/* { dg-require-effective-target hard_float } */ > /* { dg-options "-fno-finite-math-only -fsigned-zeros -fno-signaling-nans -dp" } */ > > double > diff --git a/gcc/testsuite/gcc.target/riscv/fminf.c b/gcc/testsuite/gcc.target/riscv/fminf.c > index 9a3687be3092..32ce363e10d8 100644 > --- a/gcc/testsuite/gcc.target/riscv/fminf.c > +++ b/gcc/testsuite/gcc.target/riscv/fminf.c > @@ -1,4 +1,5 @@ > /* { dg-do compile } */ > +/* { dg-require-effective-target hard_float } */ > /* { dg-options "-fno-finite-math-only -fsigned-zeros -fno-signaling-nans -dp" } */ > > float > diff --git a/gcc/testsuite/gcc.target/riscv/pr105666.c b/gcc/testsuite/gcc.target/riscv/pr105666.c > index 904f3bc0763f..dd996eec8efc 100644 > --- a/gcc/testsuite/gcc.target/riscv/pr105666.c > +++ b/gcc/testsuite/gcc.target/riscv/pr105666.c > @@ -6,6 +6,7 @@ > spilling to stack. */ > > /* { dg-do compile } */ > +/* { dg-require-effective-target hard_float } */ > /* { dg-options "-march=rv64g -ffast-math" } */ > > #define NITER 4 > diff --git a/gcc/testsuite/gcc.target/riscv/smax-ieee.c b/gcc/testsuite/gcc.target/riscv/smax-ieee.c > index 3a98aeb45add..2dbccefe2f4d 100644 > --- a/gcc/testsuite/gcc.target/riscv/smax-ieee.c > +++ b/gcc/testsuite/gcc.target/riscv/smax-ieee.c > @@ -1,4 +1,5 @@ > /* { dg-do compile } */ > +/* { dg-require-effective-target hard_float } */ > /* { dg-options "-ffinite-math-only -fsigned-zeros -dp" } */ > > double > diff --git a/gcc/testsuite/gcc.target/riscv/smax.c b/gcc/testsuite/gcc.target/riscv/smax.c > index d806c632faed..1092cc49f25e 100644 > --- a/gcc/testsuite/gcc.target/riscv/smax.c > +++ b/gcc/testsuite/gcc.target/riscv/smax.c > @@ -1,4 +1,5 @@ > /* { dg-do compile } */ > +/* { dg-require-effective-target hard_float } */ > /* { dg-options "-ffinite-math-only -fno-signed-zeros -dp" } */ > > double > diff --git a/gcc/testsuite/gcc.target/riscv/smaxf-ieee.c b/gcc/testsuite/gcc.target/riscv/smaxf-ieee.c > index 6cf23d789b6e..31b9bfa4d91e 100644 > --- a/gcc/testsuite/gcc.target/riscv/smaxf-ieee.c > +++ b/gcc/testsuite/gcc.target/riscv/smaxf-ieee.c > @@ -1,4 +1,5 @@ > /* { dg-do compile } */ > +/* { dg-require-effective-target hard_float } */ > /* { dg-options "-ffinite-math-only -fsigned-zeros -dp" } */ > > float > diff --git a/gcc/testsuite/gcc.target/riscv/smaxf.c b/gcc/testsuite/gcc.target/riscv/smaxf.c > index d6a7a7f84cf7..aa1f22b45a17 100644 > --- a/gcc/testsuite/gcc.target/riscv/smaxf.c > +++ b/gcc/testsuite/gcc.target/riscv/smaxf.c > @@ -1,4 +1,5 @@ > /* { dg-do compile } */ > +/* { dg-require-effective-target hard_float } */ > /* { dg-options "-ffinite-math-only -fno-signed-zeros -dp" } */ > > float > diff --git a/gcc/testsuite/gcc.target/riscv/smin-ieee.c b/gcc/testsuite/gcc.target/riscv/smin-ieee.c > index c0a148c37cf1..ea36c2de89fe 100644 > --- a/gcc/testsuite/gcc.target/riscv/smin-ieee.c > +++ b/gcc/testsuite/gcc.target/riscv/smin-ieee.c > @@ -1,4 +1,5 @@ > /* { dg-do compile } */ > +/* { dg-require-effective-target hard_float } */ > /* { dg-options "-ffinite-math-only -fsigned-zeros -dp" } */ > > double > diff --git a/gcc/testsuite/gcc.target/riscv/smin.c b/gcc/testsuite/gcc.target/riscv/smin.c > index e325e9a1c7cc..d07a0fdc1525 100644 > --- a/gcc/testsuite/gcc.target/riscv/smin.c > +++ b/gcc/testsuite/gcc.target/riscv/smin.c > @@ -1,4 +1,5 @@ > /* { dg-do compile } */ > +/* { dg-require-effective-target hard_float } */ > /* { dg-options "-ffinite-math-only -fno-signed-zeros -dp" } */ > > double > diff --git a/gcc/testsuite/gcc.target/riscv/sminf-ieee.c b/gcc/testsuite/gcc.target/riscv/sminf-ieee.c > index 353e7a18704a..427617af08f1 100644 > --- a/gcc/testsuite/gcc.target/riscv/sminf-ieee.c > +++ b/gcc/testsuite/gcc.target/riscv/sminf-ieee.c > @@ -1,4 +1,5 @@ > /* { dg-do compile } */ > +/* { dg-require-effective-target hard_float } */ > /* { dg-options "-ffinite-math-only -fsigned-zeros -dp" } */ > > float > diff --git a/gcc/testsuite/gcc.target/riscv/sminf.c b/gcc/testsuite/gcc.target/riscv/sminf.c > index f0ba7b43bdf9..7df223e8bcad 100644 > --- a/gcc/testsuite/gcc.target/riscv/sminf.c > +++ b/gcc/testsuite/gcc.target/riscv/sminf.c > @@ -1,4 +1,5 @@ > /* { dg-do compile } */ > +/* { dg-require-effective-target hard_float } */ > /* { dg-options "-ffinite-math-only -fno-signed-zeros -dp" } */ > > float > -- > 2.32.0 >