From: Kito Cheng <kito.cheng@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
Andrew Waterman <andrew@sifive.com>,
Jim Wilson <jim.wilson.gcc@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] riscv: Allow -Wno-psabi to turn off ABI warnings [PR91229]
Date: Tue, 15 Mar 2022 20:30:32 +0800 [thread overview]
Message-ID: <CA+yXCZBLhVqUd5pTNbRgz=6YAcFjBAH5D33SRgO9Ezqdu23Hzw@mail.gmail.com> (raw)
In-Reply-To: <YjBw7ILOHjYx5h4r@tucnak>
Hi Jakub:
LGTM, Thanks!
On Tue, Mar 15, 2022 at 6:57 PM Jakub Jelinek via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Hi!
>
> While checking if all targets honor -Wno-psabi for ABI related warnings
> or messages, I found that almost all do, except for riscv.
> In the testsuite when we want to ignore ABI related messages we
> typically use -Wno-psabi -w, but it would be nice to get rid of those
> -w uses eventually.
>
> The following allows silencing those warnings with -Wno-psabi rather than
> just -w even on riscv.
>
> Ok for trunk?
>
> 2022-03-15 Jakub Jelinek <jakub@redhat.com>
>
> PR target/91229
> * config/riscv/riscv.cc (riscv_pass_aggregate_in_fpr_pair_p,
> riscv_pass_aggregate_in_fpr_and_gpr_p): Pass OPT_Wpsabi instead of 0
> to warning calls.
>
> --- gcc/config/riscv/riscv.cc.jj 2022-03-07 15:00:17.239592719 +0100
> +++ gcc/config/riscv/riscv.cc 2022-03-15 11:20:37.823661044 +0100
> @@ -2918,8 +2918,8 @@ riscv_pass_aggregate_in_fpr_pair_p (cons
>
> if ((n_old != n_new) && (warned == 0))
> {
> - warning (0, "ABI for flattened struct with zero-length bit-fields "
> - "changed in GCC 10");
> + warning (OPT_Wpsabi, "ABI for flattened struct with zero-length "
> + "bit-fields changed in GCC 10");
> warned = 1;
> }
>
> @@ -2960,8 +2960,8 @@ riscv_pass_aggregate_in_fpr_and_gpr_p (c
> && (num_int_old != num_int_new || num_float_old != num_float_new)))
> && (warned == 0))
> {
> - warning (0, "ABI for flattened struct with zero-length bit-fields "
> - "changed in GCC 10");
> + warning (OPT_Wpsabi, "ABI for flattened struct with zero-length "
> + "bit-fields changed in GCC 10");
> warned = 1;
> }
>
>
> Jakub
>
prev parent reply other threads:[~2022-03-15 12:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 10:56 Jakub Jelinek
2022-03-15 12:30 ` Kito Cheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+yXCZBLhVqUd5pTNbRgz=6YAcFjBAH5D33SRgO9Ezqdu23Hzw@mail.gmail.com' \
--to=kito.cheng@gmail.com \
--cc=andrew@sifive.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jim.wilson.gcc@gmail.com \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).