From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 6FA113858D20 for ; Tue, 15 Mar 2022 12:30:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6FA113858D20 Received: by mail-ej1-x636.google.com with SMTP id p15so40923844ejc.7 for ; Tue, 15 Mar 2022 05:30:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DIdDjxQUF7fPNDdKqyapnP/ijgfD9hozbfhajInQspU=; b=kUNKEQxxA8sQpqsfPw5GowhrsERJRfy3eJiCeY7oHIJ9ENIRTKS09M1+KR5bKDWhCV swngUQAkPybMvrZDGuL4f68nywSjiaQD6pCutX2HD4LY2PgRCKgSpGufc2krBsmy8O2g 0+EHYwXwTk3ZujudT/vj4ahb3Ug+i+ldlzkcSstDs+y3+TEwO1U/eIGwhRbtLMqVXOvV rBy1ReUpDRSGQvBKTWHh+0sZkj1myoGkRYt8IRN/jsFuCYbmRGJKHA42wB3EcY9xDYeW IttpiFACgPXds7SCgJx9MzVQ8S8w8Kty8BRfqw8QHRXJBUhFhcljOVzehrMcV5JcZO0A 5i/Q== X-Gm-Message-State: AOAM533Z/+qyMyY+XAKfb4rwYwIUnmIujpc2IiJVhoUQZ7FlGoN5ucJr rxJLUva1UqJTnxZKRyTPuzFtDZ0choOX8u/duj4= X-Google-Smtp-Source: ABdhPJy+cmCad+lV22d0kE+X5qE46ojLx7PgDTZdhVaRSGOvs6tjIIiY0zFf+Q2oJYCSPEw5p10n1OhsMiGeBiPD1lg= X-Received: by 2002:a17:906:314b:b0:6d6:da31:e545 with SMTP id e11-20020a170906314b00b006d6da31e545mr23359487eje.125.1647347443702; Tue, 15 Mar 2022 05:30:43 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Kito Cheng Date: Tue, 15 Mar 2022 20:30:32 +0800 Message-ID: Subject: Re: [PATCH] riscv: Allow -Wno-psabi to turn off ABI warnings [PR91229] To: Jakub Jelinek Cc: Palmer Dabbelt , Andrew Waterman , Jim Wilson , GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Mar 2022 12:30:47 -0000 Hi Jakub: LGTM, Thanks! On Tue, Mar 15, 2022 at 6:57 PM Jakub Jelinek via Gcc-patches wrote: > > Hi! > > While checking if all targets honor -Wno-psabi for ABI related warnings > or messages, I found that almost all do, except for riscv. > In the testsuite when we want to ignore ABI related messages we > typically use -Wno-psabi -w, but it would be nice to get rid of those > -w uses eventually. > > The following allows silencing those warnings with -Wno-psabi rather than > just -w even on riscv. > > Ok for trunk? > > 2022-03-15 Jakub Jelinek > > PR target/91229 > * config/riscv/riscv.cc (riscv_pass_aggregate_in_fpr_pair_p, > riscv_pass_aggregate_in_fpr_and_gpr_p): Pass OPT_Wpsabi instead of 0 > to warning calls. > > --- gcc/config/riscv/riscv.cc.jj 2022-03-07 15:00:17.239592719 +0100 > +++ gcc/config/riscv/riscv.cc 2022-03-15 11:20:37.823661044 +0100 > @@ -2918,8 +2918,8 @@ riscv_pass_aggregate_in_fpr_pair_p (cons > > if ((n_old != n_new) && (warned == 0)) > { > - warning (0, "ABI for flattened struct with zero-length bit-fields " > - "changed in GCC 10"); > + warning (OPT_Wpsabi, "ABI for flattened struct with zero-length " > + "bit-fields changed in GCC 10"); > warned = 1; > } > > @@ -2960,8 +2960,8 @@ riscv_pass_aggregate_in_fpr_and_gpr_p (c > && (num_int_old != num_int_new || num_float_old != num_float_new))) > && (warned == 0)) > { > - warning (0, "ABI for flattened struct with zero-length bit-fields " > - "changed in GCC 10"); > + warning (OPT_Wpsabi, "ABI for flattened struct with zero-length " > + "bit-fields changed in GCC 10"); > warned = 1; > } > > > Jakub >