From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by sourceware.org (Postfix) with ESMTPS id 4BBA2382EBF2 for ; Thu, 30 Jul 2020 16:41:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4BBA2382EBF2 Received: by mail-wm1-x341.google.com with SMTP id p14so6294756wmg.1 for ; Thu, 30 Jul 2020 09:41:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=JGS+tblSIl1vky/Ah4vKISrbesXyZt4mL7W/xkQMmdU=; b=MkhuP1V3TwQJL513oXiy3Ih65NBBjk3SRqBqvZYpveq1brawbOBgSIej9NfdJlRDiK GZGvGdL/cRcShYVty10xOMyQSSMe4z9r9cgjYkVlL9Lhp4E345ZlHM9mSTdANOQxpba6 bvkWumVLXOhsFTU9sC5fibZ8p3nnAjFHbZsXANqPLjs0IJQYo5Og8Hfsixj1LkZID2WG jT1ysqIx5cMhPKP4DgA1yi6DLYVHjGbmcrNwA6a94HDevxAbm+HK+42tRwTyAIlyq6kJ Gpw11Wea1MvegOik/g9IrCJAIEKHSoPxgw31Bj7/6nYhTGe14IB48Jbj6LoXXpzerVwM cbvg== X-Gm-Message-State: AOAM533syo5PUMmKp1t0Fim3ihJr79srNKXKPk6CzyCxM4QiQ3brs23B 210YtxX9SG21y84UiMCTg1D9+Dh5Qj8d2B14ckc= X-Google-Smtp-Source: ABdhPJyQJiO60Lr5qF5dobylMAridkc4thWSJHBPrv+lkz7eO/Qc0ai6qw/0z0zL/BDCJCPvt5k7dp0qPhL0cwNcCg4= X-Received: by 2002:a7b:cd09:: with SMTP id f9mr118166wmj.184.1596127260018; Thu, 30 Jul 2020 09:41:00 -0700 (PDT) MIME-Version: 1.0 References: <20200713081508.48727-1-cooper.qu@linux.alibaba.com> <7c1ffff6-d29c-9aaf-aabc-c51a38e41787@linux.alibaba.com> In-Reply-To: From: Kito Cheng Date: Fri, 31 Jul 2020 00:40:48 +0800 Message-ID: Subject: Re: [PATCH v2] [RISC-V] Add support for TLS stack protector canary access To: Cooper Qu Cc: Jim Wilson , guoren@linux.alibaba.com, GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jul 2020 16:41:04 -0000 Hi Cooper: Thanks for your patch! committed to trunk. https://gcc.gnu.org/git/?p=3Dgcc.git;a=3Dcommit;h=3Dc931e8d5a96463427040b0d= 11f9c4352ac22b2b0 On Wed, Jul 29, 2020 at 8:34 PM Cooper Qu via Gcc-patches wrote: > > Sorry for later replay, I will add testcases on a following patch if the > patch is accepted. > > > Regards, > > Cooper > > On 2020/7/28 =E4=B8=8A=E5=8D=889:23, Kito Cheng wrote: > > Add testcase later is OK to me. > > > > On Tue, Jul 28, 2020 at 6:55 AM Jim Wilson wrote: > >> On Sun, Jul 19, 2020 at 7:04 PM cooper w= rote: > >>> Ping > >>> > >>> On 2020/7/13 =E4=B8=8B=E5=8D=884:15, cooper wrote: > >>>> gcc/ > >>>> * config/riscv/riscv-opts.h (stack_protector_guard): New enum= . > >>>> * config/riscv/riscv.c (riscv_option_override): Handle > >>>> the new options. > >>>> * config/riscv/riscv.md (stack_protect_set): New pattern to h= andle > >>>> flexible stack protector guard settings. > >>>> (stack_protect_set_): Ditto. > >>>> (stack_protect_test): Ditto. > >>>> (stack_protect_test_): Ditto. > >>>> * config/riscv/riscv.opt (mstack-protector-guard=3D, > >>>> mstack-protector-guard-reg=3D, mstack-protector-guard-offset= =3D): New > >>>> options. > >>>> * doc/invoke.texi (Option Summary) [RISC-V Options]: > >>>> Add -mstack-protector-guard=3D, -mstack-protector-guard-reg= =3D, and > >>>> -mstack-protector-guard-offset=3D. > >>>> (RISC-V Options): Ditto. > >> The v2 patch looks fine to me. Meanwhile, Kito asked for testcases > >> which would be nice to have but I don't think is critical considering > >> that this has already been tested with a kernel build. Maybe the > >> testcases can be a follow on patch? I'd like to see forward movement > >> on this, even if we accept a patch without the testcases. > >> > >> Jim