From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <npickito@gmail.com>
Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com
 [IPv6:2a00:1450:4864:20::633])
 by sourceware.org (Postfix) with ESMTPS id 3045F3858C53
 for <gcc-patches@gcc.gnu.org>; Wed, 10 Aug 2022 15:51:21 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3045F3858C53
Received: by mail-ej1-x633.google.com with SMTP id qn6so16658390ejc.11
 for <gcc-patches@gcc.gnu.org>; Wed, 10 Aug 2022 08:51:21 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc;
 bh=0pjXEGM9wgoIopLZUfTpZLUsFOMHQc+83kv3Kibl7kU=;
 b=yV2XTaP8eCXNtgFgJxLaRWHcpfLmKWN4vcIpyAue+x+rWOAQ5F/bR2y2eW00TH2vm4
 MTvxpuxsYokzJ+Dlkyy1+HSQvmlnKcSoRmgbSHL6xpa4E0bb/rxqOxE+sT4V60JICzhV
 Z+xV7//dGLdpi7NJfrcYnGoEI8obSHLAnSi4L1OSX6qE+RFiUuJkB6RbHfytLhXDHLP8
 XWJ28euB26KU0PvL68EL7spyiKq5LtvnTDHYlKIFZK4HLn51AJ1rAuMoNju4xb0qGfy9
 lTerpJ+nBRS0NUeI+hSCYytoEc410NaVlAJfIo18kwFMRVONInkIXZjoOeBzDw1lBB29
 Ttxw==
X-Gm-Message-State: ACgBeo2+340qO2HDHzqWhutIy2abnUxaHZ3Gqxk6xNgafj+TcfngWTTx
 VYMp/Ui+hNF/cI81eVOmexAzH5RQc73voERF7yk=
X-Google-Smtp-Source: AA6agR5CooZHgA8hBLCj92Vh4Tv3DowkKMwueakdtISbAJO8G/yKBD6N44K5FNu1pEqjmWfq9PxMtG4zWLOYvKfbBMM=
X-Received: by 2002:a17:907:a428:b0:730:aee3:2da7 with SMTP id
 sg40-20020a170907a42800b00730aee32da7mr20004154ejc.613.1660146679311; Wed, 10
 Aug 2022 08:51:19 -0700 (PDT)
MIME-Version: 1.0
References: <20220806194122.19633-1-palmer@rivosinc.com>
In-Reply-To: <20220806194122.19633-1-palmer@rivosinc.com>
From: Kito Cheng <kito.cheng@gmail.com>
Date: Wed, 10 Aug 2022 23:51:06 +0800
Message-ID: <CA+yXCZBOjKLfsnU_iEcdVSam-O2mwuhQ4qzfRu+VVE_Ua=+PSQ@mail.gmail.com>
Subject: Re: [PATCH] RISC-V: Fix the sge<u> ..., x0, ... pattern
To: Palmer Dabbelt <palmer@rivosinc.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Aug 2022 15:51:23 -0000

LGTM, that's apparently some kind of copy & paste error (from *slt<u>
pattern) when we add this pattern.

On Sun, Aug 7, 2022 at 3:42 AM Palmer Dabbelt <palmer@rivosinc.com> wrote:
>
> There's no operand 2 here, so referencing it doesn't make sense.  I
> couldn't find a way to trigger bad assembly output so I don't have a
> test.
>
> gcc/ChangeLog
>
>         PR target/106543
>         * config/riscv/riscv.md (sge<u>_<X:mode><GPR:mode>): Remove
>         reference to non-existent operand.
> ---
> No new failures on the Linux multilibs on trunk.
> ---
>  gcc/config/riscv/riscv.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config/riscv/riscv.md b/gcc/config/riscv/riscv.md
> index 0796f91dd30..ed1c7f241e6 100644
> --- a/gcc/config/riscv/riscv.md
> +++ b/gcc/config/riscv/riscv.md
> @@ -2386,7 +2386,7 @@
>         (any_ge:GPR (match_operand:X 1 "register_operand" " r")
>                     (const_int 1)))]
>    ""
> -  "slt%i2<u>\t%0,zero,%1"
> +  "slt<u>\t%0,zero,%1"
>    [(set_attr "type" "slt")
>     (set_attr "mode" "<X:MODE>")])
>
> --
> 2.34.1
>