From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe34.google.com (mail-vs1-xe34.google.com [IPv6:2607:f8b0:4864:20::e34]) by sourceware.org (Postfix) with ESMTPS id 93DDD3858D33 for ; Thu, 20 Apr 2023 06:01:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 93DDD3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vs1-xe34.google.com with SMTP id ada2fe7eead31-4301281573aso31207137.3 for ; Wed, 19 Apr 2023 23:01:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681970460; x=1684562460; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lDxxQ4Xk3EDSTH6Vq8ZNwaDkr2X2BeZ3tVp9vnD/6Z0=; b=aBb5Yz91XUmKJLYW8zMtzl7ZsmqBVbFw0cw2BFNCCruaLdLeMykF1oolPeFz4N0RS0 50L+uT4uOP357e8H9YmVXhh8euCjrbX8TeuHHEYX+diLTPd6f0tvgEzG8Vscm8JW75mR jhi1Bif2gmAvCPaaSeechGNq1dr3MX7AXA07KSYY8WSQo+U52eniuwFsrnm/j/X8C1bC NkG+c081C0A1KA88Na3r1tRACp+hS8k1QxsY96nULtmX/d3eTDzQogQdIHc02E91T9ue Hlwa3bZLlqoilO9lHcVCHl3Lt3ek2+TD9uFy9UjHicGoUwaYvpfif4xEngQVD4wfuX/l 7llA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681970460; x=1684562460; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lDxxQ4Xk3EDSTH6Vq8ZNwaDkr2X2BeZ3tVp9vnD/6Z0=; b=fQNErdI/RpCSJGp37HjFAS2m+1/JLb6iFmwLTsqusD456NXYyUpGDojLiFyNmTBzU4 Ev86o3I0Z6wGZ9xbQ8d759Aja5cG5/nKFFfIlmEOQWZQ/rl/wlCZUDz4nDGWdR87fS1N 9p7TuYarxfIDxBTtQzKOiqt4BwUOQWlYFBDQ3kKUdk2lUsbUNQ0dbywDB9J9S+f4J7sm sppwv2DWcXzHGVq5h9Xuv2jAkhE9e2V8gwLymaT4NE+oGCiekGE/PaW5WcEZwG11jzkS 6yO+BSE/4bSdQzhboKcWZAjmPQDlS5pTkZA+Ln6PboIdk8smHd5f68oNDbDwWcBX2Shj FI/g== X-Gm-Message-State: AAQBX9cHFdUyouof5qLpKqZ5hYHXaztZYkQ++TDHy1NoopPjpWjHwQDS XOGuhvIAzrMfI+cMmDJyS2XKQjLdPsZbfs0X/Fc= X-Google-Smtp-Source: AKy350aM+Q9nccQnnAkClO81g1uq0sQhNWbLR4Kk/VOlnVAFud+EA+6frJJHPCt+/cH7YTaQd4ZbpIdlbX3g2mpe+CU= X-Received: by 2002:a67:ec52:0:b0:412:1d9a:b33c with SMTP id z18-20020a67ec52000000b004121d9ab33cmr361995vso.33.1681970459757; Wed, 19 Apr 2023 23:00:59 -0700 (PDT) MIME-Version: 1.0 References: <3ee750e7-d3f5-12cc-4885-bbe2f6290861@ventanamicro.com> In-Reply-To: <3ee750e7-d3f5-12cc-4885-bbe2f6290861@ventanamicro.com> From: Kito Cheng Date: Thu, 20 Apr 2023 14:00:48 +0800 Message-ID: Subject: Re: [RFA] [PR target/108248] [RISC-V] Break down some bitmanip insn types To: Jeff Law Cc: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: OK, thanks :) On Thu, Apr 20, 2023 at 12:35=E2=80=AFPM Jeff Law w= rote: > > This is primarily Raphael's work. All I did was adjust it to apply to > the trunk and add the new types to generic.md's scheduling model. > > > The basic idea here is to make sure we have the ability to schedule the > bitmanip instructions with a finer degree of control. Some of the > bitmanip instructions are likely to have differing scheduler > characteristics across different implementations. > > So rather than assign these instructions a generic "bitmanip" type, this > patch assigns them a type based on their RTL code by using the > iterator for the type. Naturally we have to add a few > new types. It affects clz, ctz, cpop, min, max. > > We didn't do this for things like shNadd, single bit manipulation, etc. > We certainly could if the needs presents itself. > > I threw all the new types into the generic_alu bucket in the generic > scheduling model. Seems as good a place as any. Someone who knows the > sifive uarch should probably add these types (and bitmanip) to the > sifive scheduling model. > > We also noticed that the recently added orc.b didn't have a type at all. > So we added it as a generic bitmanip type. > > This has been bootstrapped in a gcc-12 base and I've built and run the > testsuite without regressions on the trunk. > > Given it was primarily Raphael's work I could probably approve & commit > it. But I'd like to give the other RISC-V folks a chance to chime in. > > > OK for the trunk? > > Jeff