From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa35.google.com (mail-vk1-xa35.google.com [IPv6:2607:f8b0:4864:20::a35]) by sourceware.org (Postfix) with ESMTPS id 411993854574 for ; Wed, 23 Nov 2022 03:39:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 411993854574 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vk1-xa35.google.com with SMTP id v81so8171907vkv.5 for ; Tue, 22 Nov 2022 19:39:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=d6medgSn2JD5tQ4W03BKErCTcWAvhJ0VogmbmP3YqAs=; b=goefk61b+F/ZuJgx9+V5oYjBqP5BzPNZtuZ/cT5dTQwccJP3JWYfikj198ZYT1xdeN SrUIHWdBz5aMUVhQM8GCQEw/cs9XjMePpnQ7XZ3ilnXn7hMdUp5cvtR0AgxDOolr/2Mb d4wAoN2NxwfdaxsJ2cg75ygSj2CK26En9GiThTFYh2PyWI+Fl3HY5+dRbx+2DgxrRUYW UwsqXfeXvHIucxCXkLP7C6IUmNy2NUcUzx6K2B9wxPYB7sc0BV5D/Smgql2rJ4iplbz2 THdtaMKXurWFGGu1bj43UyUhEy4IxgcRn4TYjYr7VgmmaO+K6IOEj9EVxPPVTENX6LoE dLgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d6medgSn2JD5tQ4W03BKErCTcWAvhJ0VogmbmP3YqAs=; b=PmAZWQvTNnINk7iegCpopa7ySvbptdGdMCSvk3NCVShSl8KiKhdh0J5JBHkDMe02X+ hdHqErJKinap6gcvwIeZGfBFAJYQL+uoZU9gije4V3/XH/Tt0B6aaz+XgIvJPxhFHNeM iVwCCbvklTPRlrGNwwj+O8INWUu5YK3nszr1JH5CqzVGRWyLVMJmEFafhtfr6LA5gNC1 I4VovS83NYm8IYLoCT3TUM/Bdoq5WdguMcwh5Biht1u5IsY2i690SOST3yWqdPyTOGZF q72ShlnfdB7Xy0pIH0VCVFBsODLKNraaroKHEEHCuCaxKFG5qg9UhDOcOxILBbbkxUiM iiiQ== X-Gm-Message-State: ANoB5pkHqrRgWywaxVRr3dK903c0QNE7tJl9ZMrhFiJRgB8kXmWIdi4Z cEOHD5IlrEtKQfatYMIe1PQcEpxCzfuehjZdfy4= X-Google-Smtp-Source: AA0mqf6oUPGuMAuWOiwoWt19KQANHvs+0YPGHyWHfkn+vpXbdsQaCLF+X6IOR2waRCRf48m4P8XLEdu/2dgynzjYPx4= X-Received: by 2002:a05:6122:2186:b0:3bc:22fe:396c with SMTP id j6-20020a056122218600b003bc22fe396cmr8040522vkd.11.1669174791299; Tue, 22 Nov 2022 19:39:51 -0800 (PST) MIME-Version: 1.0 References: <293c6900-a6b8-9bcb-9752-5f41554e80c5@ventanamicro.com> In-Reply-To: <293c6900-a6b8-9bcb-9752-5f41554e80c5@ventanamicro.com> From: Kito Cheng Date: Wed, 23 Nov 2022 11:39:39 +0800 Message-ID: Subject: Re: [committed][RISC-V] Fix recent rvv/base/spill testcase failures To: Jeff Law Cc: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: LGTM, thanks :) On Wed, Nov 23, 2022 at 7:21 AM Jeff Law wrote: > > As Jaiwei noted, many (all?) of the rvv/base/spill tests started failing > after the introduction of shrink-wrapping. > > > The core issue is we're expecting the frame to have a constant size, but > it doesn't. So when using the to_constant method we abort. > > > The safest thing to do is to set no shrink-wrapping components when the > frame size is not fixed. We might be able to do better later -- iff we > know the offset to the GPRs/FPRs is fixed and fits into the appropriate > number of bits. > > > Bootstrapped and regression tested (C-only) on riscv64-linux-gnu. As > expected, it fixes a bucketload of failures in rvv/base/spill-*.c. > > > Installed on the trunk, > > Jeff