From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id D6DF33858C42 for ; Fri, 19 Jan 2024 02:42:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D6DF33858C42 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D6DF33858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705632135; cv=none; b=yB6xg3Qua7f5J8SjrA6y6215IO2uRhBXn1nt6cgH0kctXcamViq2bTv6IYfXjRVqjWhoXkjV1KIGLmB4ErZG2+80YBWxK0X8dC3MZQX1DkhV3OCakR4Z0ekPKiHj92amzkir3v+/V7QjkzBaineGUmuyDfX7OdA4lP1EE9hJPrU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705632135; c=relaxed/simple; bh=iNSCiette6U5/Y+/QJk5waHSoeQEaMQV+wwBxmkcR3w=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=fl3OwjoCfSHCRQAhxlI5iokxgjiJTK6T9nHFtUZkEq+OtN8psclXS0XtG+a1TbYBGf8uRIkdut2Xh1iBXz6g98MOR/pOYXOgTxwtbj65b59+Bc+8TT17doUo9iBwwv8GJnOVNqHoPLwj2Pc/LLACYpjL8wl51banD8gZviCx8qQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a2c375d2430so29573466b.1 for ; Thu, 18 Jan 2024 18:42:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705632130; x=1706236930; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3ZWcj9vcym6ba+ttLxWLz0KEVOJfvOyVOsnAEvrVm/8=; b=QgKQkBE6gMy2mEET+AhcNrqjt3W9nPHfVMCJl6DbK1s0usTQ2NM+c79l1fNxuWHQT1 gQZKsDrfZLIn2m++G02mo+0/25Vo8CjzhmihbOYnGr7TksKn9bslWHL5mMzRt+NDc2LY GQFPlQP1W3FkPOijSdtYdDBY06DMIHKd0mkuK7Z+mtV+zMbDvko7Kox3r++VQhydIqOp EL3fdE9qOIAEmdwiHzMtkL3ZZTQntEeJUGD2CmGc6YGlBaPexqok7uu6qDe5novCrwB3 GUe1/+I8ZGhll2GQqWdqfuuQnm18DF1TykrCrJ1h455SJH2KwJVrHT8BcN9NlG6RrySO bUYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705632130; x=1706236930; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3ZWcj9vcym6ba+ttLxWLz0KEVOJfvOyVOsnAEvrVm/8=; b=vP23prfQXujA7hROXLRwl48IQwzjk0li5zaYKLey2LFiFmhZihoc18OgynOl+TY9SE oxUIeGCD9AOYUEzSMj+pLRtOGvKvtiiI392Tvv8vXfAXxk6PIKN8x0B4XvDm2OYf/H0y s2OKVH/WscthxTBUpbugCXN1z3TCsxXX1OjfLWq5xTRBq00uZnbpn9wN9LmrE/HXwvvg U0k6CedZYPaJew4rLVhzLPVtf09UFWQfqJwm3LkJmVko/m6CFdSPIgzMKryyqcuDxsdp cMg7TozNz7r2oRv0PO1AyZBhagJqJ6XZUje5ZPrmCOfBj9B9Ud8qq9m4HMbNrnoNZj7s 8AdQ== X-Gm-Message-State: AOJu0YwhttrdbGjmoFaRiwL+hgdHUcH+HCmpqPn4LxtoxVNxLU1TFlHE hMN6N+1Rclaa8NiNKt5itx8n9S7W7jemp79YD68xmTTB021fYS/j1/qVsQL9GLRXC76esKVeL6T erfuYnaueTsIoP4LnZkLw19RpVrg= X-Google-Smtp-Source: AGHT+IEf+O7RmaroULObuWoKInXeZDsv743H179Zyqby/IGJ55MVXASvRNif7ADIJkbsIbf07xbRnIrm50t8FLYjQAc= X-Received: by 2002:a17:907:d404:b0:a28:ad97:e214 with SMTP id vi4-20020a170907d40400b00a28ad97e214mr1389897ejc.1.1705632130367; Thu, 18 Jan 2024 18:42:10 -0800 (PST) MIME-Version: 1.0 References: <20240119023457.1870618-1-kito.cheng@sifive.com> <59ABBD7F7EC1D927+2024011910352425760416@rivai.ai> In-Reply-To: <59ABBD7F7EC1D927+2024011910352425760416@rivai.ai> From: Kito Cheng Date: Fri, 19 Jan 2024 10:41:57 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Tweak the wording for the sorry message To: "juzhe.zhong@rivai.ai" Cc: "Kito.cheng" , "rep.dot.nop" , jeffreyalaw , Robin Dapp , gcc-patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks, pushed to trunk :) On Fri, Jan 19, 2024 at 10:36=E2=80=AFAM juzhe.zhong@rivai.ai wrote: > > OK > > ________________________________ > juzhe.zhong@rivai.ai > > > From: Kito Cheng > Date: 2024-01-19 10:34 > To: rep.dot.nop; jeffreyalaw; rdapp.gcc; juzhe.zhong; gcc-patches > CC: Kito Cheng > Subject: [PATCH] RISC-V: Tweak the wording for the sorry message > Use "does not" rather than "cannot", because it's implementation issue. > > gcc/ChangeLog: > > * config/riscv/riscv.cc (riscv_override_options_internal): Tweak > sorry message. > --- > gcc/config/riscv/riscv.cc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc > index f1d5129397f..dd6e68a08c2 100644 > --- a/gcc/config/riscv/riscv.cc > +++ b/gcc/config/riscv/riscv.cc > @@ -8798,13 +8798,13 @@ riscv_override_options_internal (struct gcc_optio= ns *opts) > We can only allow TARGET_MIN_VLEN * 8 (LMUL) < 65535. */ > if (TARGET_MIN_VLEN_OPTS (opts) > 4096) > - sorry ("Current RISC-V GCC cannot support VLEN greater than 4096bit = for " > + sorry ("Current RISC-V GCC does not support VLEN greater than 4096bi= t for " > "'V' Extension"); > /* FIXME: We don't support RVV in big-endian for now, we may enable RV= V with > big-endian after finishing full coverage testing. */ > if (TARGET_VECTOR && TARGET_BIG_ENDIAN) > - sorry ("Current RISC-V GCC cannot support RVV in big-endian mode"); > + sorry ("Current RISC-V GCC does not support RVV in big-endian mode")= ; > /* Convert -march to a chunks count. */ > riscv_vector_chunks =3D riscv_convert_vector_bits (opts); > -- > 2.34.1 > >