From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by sourceware.org (Postfix) with ESMTPS id C160F386100D for ; Fri, 12 Jan 2024 09:53:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C160F386100D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C160F386100D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::531 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705053227; cv=none; b=ULrQdqM5EgjqDVDGjLsWdvlH764oHrKpWl94E+ZS2g+waXZrmQw4hTktbp8J0+VAEZFnAXPy4Q3ZEXuUxrAGLXJQGCz621J4eSbZ4oa1B6qzbURaNrwwJTfva+w5LHkFOSee+H5YCtLiYk+r4B5RLEOQ9LOWdL9GkDpKskBi92k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705053227; c=relaxed/simple; bh=95Ox9/mYjSvLPRS7XLjXIDMVk4id/BnqvzXapxjO2Co=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=pmI9KhjWM3zYOtQFXSkqylWv1/E/kuePQ+9PLawrQ+KCYB7rHXlkh1eHTp/0WFz8ZRkbmuFQ3xOjx6o5j/UThbgj9fBcpd1T1v3CxLGHnivxx4dovJmIqRFANpGQNtA2huhSZpz+Xeb1DbwyYGj1B3WOSCB4fNKfHEIg4xJoVBA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-556c3f0d6c5so7425408a12.2 for ; Fri, 12 Jan 2024 01:53:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705053221; x=1705658021; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=z2B0CCwTIYGTzZgV2eGzmp9mtSUGXVnbAWS59f/syEI=; b=m9Lsqxsa7J1rEK2uMAlu/HRZgVfzPEPfMupiPiKpf5fmUlPNHZyAQxoR8iIQiVnuo3 Wo5qKEzQyg+FRXqQ2DgmAIRmjCWxl+eGyTIW4Cdwa454nXYwIXpRD+IQaClkeMQJOoyO gx8lnz64ER686qttZds/748tufyi5hXDArnHzkCaClq9rLn0E0jfm2rxAzzyJHKhc59M ueBK6L2TrGTsSRZo3F/cUNXrhZzUcgNAQQutSnoAk3+TjvdFkdZL6IVLxrVJgOOLh4Xb /9Ubca5cL1xYocBWKqcOhErXDbdcZJIuvyHjLI2Ojpt/laSIJgJ66IRw6Wt7HBBdarKR ag9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705053221; x=1705658021; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z2B0CCwTIYGTzZgV2eGzmp9mtSUGXVnbAWS59f/syEI=; b=QCLrjPHPobiw8Cg/mRt7jQxcjyb+gxsmb9n9tWo/0pkLq6RXEEDkPJPnCP160gOAaX jB+uCp2T3jzQX62Dolc8vyniwr102T7XvCiGibBqWeJ9EToQ5h2FwwE7i+OTMJ9dAAsL pxbG8xVFCSbSYi9QAryu6QBlC+VXIAhXYO0IagYtDIr2t88jCBQfvLZlfL/Jp7opbUGq /rk6gPqThw31rwf2XMmaKurLjES+QlwYq6GRhFkvHHGSx6AoR+q7vx5JyUgmT0FCRjlT U5kOCmSZY8nRL6d4EFFhlQ44kWf0pqfJ0YWwyrq4p+DO3+wdZFQXazcs6Pbj2e7dl3/6 EJ9w== X-Gm-Message-State: AOJu0YxyN8XYJk3UC/8bxCqByOv+KCHowFJv4rde9EoyFjk4UbR1q6lF FaQa6j4bT0FyR8FZ6lGyxVuwW56gGCrDevRWGoI= X-Google-Smtp-Source: AGHT+IFkYInGYcdtw2Lm6Dk3kCTMaZRcubwP9c4W/8UkVU9//o7HkT3dA6byweIJ/1oYxsin3FXB94ijsYZBkkeqgMk= X-Received: by 2002:a05:6402:1d93:b0:558:df90:e4c5 with SMTP id dk19-20020a0564021d9300b00558df90e4c5mr72812edb.123.1705053221124; Fri, 12 Jan 2024 01:53:41 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Kito Cheng Date: Fri, 12 Jan 2024 17:53:28 +0800 Message-ID: Subject: Re: [PATCH 2/2] RISC-V/testsuite: Also verify if-conversion runs for pr105314.c To: "Maciej W. Rozycki" Cc: gcc-patches@gcc.gnu.org, Andrew Waterman , Jim Wilson , Palmer Dabbelt Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,LIKELY_SPAM_BODY,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: LGTM On Fri, Jan 12, 2024 at 7:37=E2=80=AFAM Maciej W. Rozycki wrote: > > Verify that if-conversion succeeded through noce_try_store_flag_mask, as > per PR rtl-optimization/105314, tightening the test case and making it > explicit. > > gcc/testsuite/ > * gcc.target/riscv/pr105314.c: Scan the RTL "ce1" pass too. > --- > gcc/testsuite/gcc.target/riscv/pr105314.c | 2 ++ > 1 file changed, 2 insertions(+) > > gcc-test-riscv-pr105314-rtl.diff > Index: gcc/gcc/testsuite/gcc.target/riscv/pr105314.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- gcc.orig/gcc/testsuite/gcc.target/riscv/pr105314.c > +++ gcc/gcc/testsuite/gcc.target/riscv/pr105314.c > @@ -1,6 +1,7 @@ > /* PR rtl-optimization/105314 */ > /* { dg-do compile } */ > /* { dg-skip-if "" { *-*-* } { "-O0" "-Og" "-Os" "-Oz" } } */ > +/* { dg-options "-fdump-rtl-ce1" } */ > > long > foo (long a, long b, long c) > @@ -10,4 +11,5 @@ foo (long a, long b, long c) > return a; > } > > +/* { dg-final { scan-rtl-dump-times "if-conversion succeeded through noc= e_try_store_flag_mask" 1 "ce1" } } */ > /* { dg-final { scan-assembler-not "\\s(?:beq|bne)\\s" } } */