From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by sourceware.org (Postfix) with ESMTPS id 2769F3858D37 for ; Mon, 29 Jul 2024 13:37:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2769F3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2769F3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::533 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722260261; cv=none; b=qsKoWaH8mbjJyEsUKNC+KT5hcoVblntUmo/rQDybFqho1vF1e627GHijHM30lPN5fgmeJtxZJaTbjVzYbSQvng1a17NbJmNYbPL0Rsfdvli1nepakmIrMY/L7MPvaf61YXDUkKEtezNMBwkjlsvwnNY2qLijIYIuNFNWfLdf42I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722260261; c=relaxed/simple; bh=/XPL6xpwAHi/4MTVhv8LxiPyJx8WnZkdh8QCz5NS9Xs=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=h7mjFM0ziOtPoNE9w2mE9yHX5kWiTcWbQtYqcBIhiAH5lF9VXL9RiZf7J33KuGPJEzCSQU2GFL4y/5xCMel9Vx9cDFmZXkXv8Jx1ZwkkPin8yHc6BQTPKbUq65vtDGUNGfCEieUZ+78Bkv3NGvuFI3/hSRiue0Rfayri7it0usA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5a20de39cfbso5213036a12.1 for ; Mon, 29 Jul 2024 06:37:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722260257; x=1722865057; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/RhoijJBE5KLEpom/UJZTrE1LZ966y9ucgeZ0n3VEoE=; b=GhFurncFocptmM8bi/eLOhydYVk0i0Hb4eJrSCZdC1WTwPrF7PawCXa86bFNqoJeYI 7CeQ/N2QHVeQB+rXVZcz81HJ5elOuhRHxH7ly42VFSI4eeacM4XAoN4m2z66qXx3TjPA HDZcpnXZLcMp36DwwqV1+gwGkEHXF/ludJjG2GvfWTOS55gbjqkTDu7lZ+HU0bDZY/Vn 1FjbNAjR6HK4YxXJ9tHOAUyZv+5YOq/nshlwztQGDx6yMruk9zzxmsW35u9XQWiAW2Xw nbKCMsAzMHdHdeKvdaovD0l6U1YRJtSv22eYpxtDBBI+yzbkMwZqFzNc4X5iYJbwytzY BUZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722260257; x=1722865057; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/RhoijJBE5KLEpom/UJZTrE1LZ966y9ucgeZ0n3VEoE=; b=BWEYVC3pC0vrkLUxvXPFebzJm7wpGhWkXp5bZj9wrg+0D2E9fSPGzFeZ2nxmJxC0Vs DKBwF8a0XpAO7s7hytS4whsiIWXVfQcRmzcve4r3kQgmyjcAzyccyh5YZ8GPkk3lDHVW aAYPmAkZXLonLGq0DeDORPtUrM7G7MD4s1Ntodox4m8x0YeyWnVDIGNBDWDER2+G6P/L zyZ51l4QiBTrjWOQlL59r5+KezqJu7nzePC1bloxUGqHW+3lBDRtXpXMKWUmnPrerwAM tebYYIkQUXKtWfNtadidQXLhWvs0sht4iPUt6ntZeX++mO8pnWYPBDLOfy5usziCsr/l zUdg== X-Gm-Message-State: AOJu0YxQuaqyDsKw4RRRRqbcmfj9b32HEFHYSojpue/d78PTLrb0s7kL O9v+WC7tl6QioUvumAinQuxTmw4fnHglvVV67Z880VCDbLFNpRQskGXL1sdz1T4lWWzb/hwo0io sGPaB5bpXkeEaT0Al+EZL4QmyB9nHyc58 X-Google-Smtp-Source: AGHT+IF9ZSw0Rt1FwpFnIfSCf0x4odWgiUt5VbA3XfS+V+aEE3eqsuX5+cUzmZoRGnXxlFStK8rtwxE9AFYTWpKH1Mo= X-Received: by 2002:a17:907:94cb:b0:a77:cacf:58b5 with SMTP id a640c23a62f3a-a7d3ffc0597mr601255466b.1.1722260256141; Mon, 29 Jul 2024 06:37:36 -0700 (PDT) MIME-Version: 1.0 References: <20240724235038.3649303-1-ewlu@rivosinc.com> In-Reply-To: <20240724235038.3649303-1-ewlu@rivosinc.com> From: Kito Cheng Date: Mon, 29 Jul 2024 21:37:24 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Add configure check for B extention support To: Edwin Lu Cc: gcc-patches@gcc.gnu.org, gnu-toolchain@rivosinc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: LGTM, although I said no binutils check for zacas and zabha, but B is a different situation since GCC will add that if zba, zbb and zbs are all present. On Thu, Jul 25, 2024 at 7:51=E2=80=AFAM Edwin Lu wrote: > > Binutils 2.42 and before don't recognize the B extension in the march > strings even though it supports zba_zbb_zbs. Add a configure check to > ignore the B in the march string if found. > > gcc/ChangeLog: > > * common/config/riscv/riscv-common.cc (riscv_subset_list::to_stri= ng): > Skip b in march string > * config.in: Regenerate. > * configure: Regenerate. > * configure.ac: Add B assembler check > > Signed-off-by: Edwin Lu > --- > gcc/common/config/riscv/riscv-common.cc | 8 +++++++ > gcc/config.in | 6 +++++ > gcc/configure | 31 +++++++++++++++++++++++++ > gcc/configure.ac | 5 ++++ > 4 files changed, 50 insertions(+) > > diff --git a/gcc/common/config/riscv/riscv-common.cc b/gcc/common/config/= riscv/riscv-common.cc > index 682826c0e34..200a57e1bc8 100644 > --- a/gcc/common/config/riscv/riscv-common.cc > +++ b/gcc/common/config/riscv/riscv-common.cc > @@ -857,6 +857,7 @@ riscv_subset_list::to_string (bool version_p) const > bool skip_zaamo_zalrsc =3D false; > bool skip_zabha =3D false; > bool skip_zicsr =3D false; > + bool skip_b =3D false; > bool i2p0 =3D false; > > /* For RISC-V ISA version 2.2 or earlier version, zicsr and zifencei i= s > @@ -891,6 +892,10 @@ riscv_subset_list::to_string (bool version_p) const > /* Skip since binutils 2.42 and earlier don't recognize zabha. */ > skip_zabha =3D true; > #endif > +#ifndef HAVE_AS_MARCH_B > + /* Skip since binutils 2.42 and earlier don't recognize b. */ > + skip_b =3D true; > +#endif > > for (subset =3D m_head; subset !=3D NULL; subset =3D subset->next) > { > @@ -911,6 +916,9 @@ riscv_subset_list::to_string (bool version_p) const > if (skip_zabha && subset->name =3D=3D "zabha") > continue; > > + if (skip_b && subset->name =3D=3D "b") > + continue; > + > /* For !version_p, we only separate extension with underline for > multi-letter extension. */ > if (!first && > diff --git a/gcc/config.in b/gcc/config.in > index bc819005bd6..96e829b9c93 100644 > --- a/gcc/config.in > +++ b/gcc/config.in > @@ -629,6 +629,12 @@ > #endif > > > +/* Define if the assembler understands -march=3Drv*_b. */ > +#ifndef USED_FOR_TARGET > +#undef HAVE_AS_MARCH_B > +#endif > + > + > /* Define if the assembler understands -march=3Drv*_zaamo_zalrsc. */ > #ifndef USED_FOR_TARGET > #undef HAVE_AS_MARCH_ZAAMO_ZALRSC > diff --git a/gcc/configure b/gcc/configure > index 01acca7fb5c..c5725c4cd44 100755 > --- a/gcc/configure > +++ b/gcc/configure > @@ -30913,6 +30913,37 @@ if test $gcc_cv_as_riscv_march_zabha =3D yes; th= en > > $as_echo "#define HAVE_AS_MARCH_ZABHA 1" >>confdefs.h > > +fi > + > + { $as_echo "$as_me:${as_lineno-$LINENO}: checking assembler for -mar= ch=3Drv32i_b support" >&5 > +$as_echo_n "checking assembler for -march=3Drv32i_b support... " >&6; } > +if ${gcc_cv_as_riscv_march_b+:} false; then : > + $as_echo_n "(cached) " >&6 > +else > + gcc_cv_as_riscv_march_b=3Dno > + if test x$gcc_cv_as !=3D x; then > + $as_echo '' > conftest.s > + if { ac_try=3D'$gcc_cv_as $gcc_cv_as_flags -march=3Drv32i_b -o conft= est.o conftest.s >&5' > + { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 > + (eval $ac_try) 2>&5 > + ac_status=3D$? > + $as_echo "$as_me:${as_lineno-$LINENO}: \$? =3D $ac_status" >&5 > + test $ac_status =3D 0; }; } > + then > + gcc_cv_as_riscv_march_b=3Dyes > + else > + echo "configure: failed program was" >&5 > + cat conftest.s >&5 > + fi > + rm -f conftest.o conftest.s > + fi > +fi > +{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $gcc_cv_as_riscv_march_= b" >&5 > +$as_echo "$gcc_cv_as_riscv_march_b" >&6; } > +if test $gcc_cv_as_riscv_march_b =3D yes; then > + > +$as_echo "#define HAVE_AS_MARCH_B 1" >>confdefs.h > + > fi > > ;; > diff --git a/gcc/configure.ac b/gcc/configure.ac > index 3f20c107b6a..93d9236ff36 100644 > --- a/gcc/configure.ac > +++ b/gcc/configure.ac > @@ -5466,6 +5466,11 @@ configured with --enable-newlib-nano-formatted-io.= ]) > [-march=3Drv32i_zabha],,, > [AC_DEFINE(HAVE_AS_MARCH_ZABHA, 1, > [Define if the assembler understands -march=3Drv*_zabha.= ])]) > + gcc_GAS_CHECK_FEATURE([-march=3Drv32i_b support], > + gcc_cv_as_riscv_march_b, > + [-march=3Drv32i_b],,, > + [AC_DEFINE(HAVE_AS_MARCH_B, 1, > + [Define if the assembler understands -march=3Drv*_b.])]) > ;; > loongarch*-*-*) > gcc_GAS_CHECK_FEATURE([.dtprelword support], > -- > 2.34.1 >