From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa2e.google.com (mail-vk1-xa2e.google.com [IPv6:2607:f8b0:4864:20::a2e]) by sourceware.org (Postfix) with ESMTPS id E13123858401 for ; Mon, 24 Apr 2023 06:25:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E13123858401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vk1-xa2e.google.com with SMTP id 71dfb90a1353d-44062aa1b5bso1265676e0c.1 for ; Sun, 23 Apr 2023 23:25:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682317556; x=1684909556; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qEIbIDBsRRdz0G3Nx8/ymjqlcYPkU4s3OSDFA1Q/J7g=; b=Tto9FfmztCcw01kayZ6TC1fnrgZxDiaCxY4R1yn/hoJzWQaG5cvp7HzvAAVyzq9ucf igH04VpuhH6ZS2Xk2cWnAP4DV/G868kibS6HrsNv48/EPsKaxlAHz7u1ISaIKqxXKltj 03BGd0zT/eFIUdEZ6kEl97DQLUpGRKvX/m9DUa0DbUNfNmoZLpE74MTvHf3rC4c9OMLU dr/pX8KCvbzQVniZBBSssbQ8g3Tgmw262GORfybIE4LVnaOVzE2ytTkdx9hK4r34fDa4 wK6pk0oYkT10vF8ajR4LIvFgpaw25h7elWaedEsowAvkHOS++tBgmRw77/kHlz6pnKMj XqPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682317556; x=1684909556; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qEIbIDBsRRdz0G3Nx8/ymjqlcYPkU4s3OSDFA1Q/J7g=; b=VFtEr5v9/60fOvTYA1W8j3OBf/og+/2qrEgj4stMrdnFJ26q3OfEoZGLtipQo+axqC UehTn/56nWbhuq9FvdJpmXVEl3wbU2ZmARjfds1g6H5Kl/PzIQ5CHRyhb3c4fRteoMlm 2EikLACu2acmVor9M2ONSKxBu84KzBCi39KNsPYKdkWtuOxF9skOrrJ0KqHMwfPXLV9z 8QCBQLVNld7tAfZNY2WtJGsCdy0zUeWiSQgLwZWZ6jwOrxwhhqddqW7Z+5ep33UKC0/H 6xIAxbkYUEY88IIGJYz/uDmoi+RjXcg/kS5aPTQNdE013U1yMnQHeSwRHCZLkfN7vI1i rbCg== X-Gm-Message-State: AAQBX9cBVLbw1UvFEq+uHlE2GhJd4ozz4mZNjMghZuJJvRakbP6MvwBt szJAN2fXZdqrbm4pFGo4ZMKtSIjtPky1n9s9nZQ= X-Google-Smtp-Source: AKy350a25o4+YUuJhT/4g+NDZ7RUtynByfKttNk3iVj6eWnPeFU62D7SJGwSUIg/aNpuc0gxSQXFBCHDvBTQrU8Zft0= X-Received: by 2002:a1f:c142:0:b0:443:6ac8:bad7 with SMTP id r63-20020a1fc142000000b004436ac8bad7mr2845714vkf.0.1682317556209; Sun, 23 Apr 2023 23:25:56 -0700 (PDT) MIME-Version: 1.0 References: <20230423113354.141950-1-juzhe.zhong@rivai.ai> In-Reply-To: <20230423113354.141950-1-juzhe.zhong@rivai.ai> From: Kito Cheng Date: Mon, 24 Apr 2023 14:25:45 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Add function comment for cleanup_insns. To: juzhe.zhong@rivai.ai Cc: gcc-patches@gcc.gnu.org, palmer@dabbelt.com, jeffreyalaw@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Pushed On Sun, Apr 23, 2023 at 7:34=E2=80=AFPM wrote: > > From: Juzhe-Zhong > > Address Jeff's comment: https://patchwork.sourceware.org/project/gcc/patc= h/20230330012804.110539-1-juzhe.zhong@rivai.ai/ > Add a function comment. > > gcc/ChangeLog: > > * config/riscv/riscv-vsetvl.cc (pass_vsetvl::pre_vsetvl): Add fun= ction comment for cleanup_insns. > > --- > gcc/config/riscv/riscv-vsetvl.cc | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/gcc/config/riscv/riscv-vsetvl.cc b/gcc/config/riscv/riscv-vs= etvl.cc > index ac99028df43..fa68b8a0462 100644 > --- a/gcc/config/riscv/riscv-vsetvl.cc > +++ b/gcc/config/riscv/riscv-vsetvl.cc > @@ -3998,6 +3998,21 @@ pass_vsetvl::pre_vsetvl (void) > commit_edge_insertions (); > } > > +/* Before VSETVL PASS, RVV instructions pattern is depending on AVL oper= and > + implicitly. Since we will emit VSETVL instruction and make RVV instru= ctions > + depending on VL/VTYPE global status registers, we remove the such AVL= operand > + in the RVV instructions pattern here in order to remove AVL dependenc= ies when > + AVL operand is a register operand. > + > + Before the VSETVL PASS: > + li a5,32 > + ... > + vadd.vv (..., a5) > + After the VSETVL PASS: > + li a5,32 > + vsetvli zero, a5, ... > + ... > + vadd.vv (..., const_int 0). */ > void > pass_vsetvl::cleanup_insns (void) const > { > -- > 2.36.1 >