From: Kito Cheng <kito.cheng@gmail.com>
To: Robin Dapp <rdapp.gcc@gmail.com>
Cc: Juzhe-Zhong <juzhe.zhong@rivai.ai>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Kito Cheng <kito.cheng@sifive.com>,
Jeff Law <jeffreyalaw@gmail.com>
Subject: Re: [PATCH] RISC-V: Refactor Phase 3 (Demand fusion) of VSETVL PASS
Date: Tue, 22 Aug 2023 00:06:07 +0800 [thread overview]
Message-ID: <CA+yXCZBe9YUpc-KiCq1BMXGoK1jJeZGYa0xndEQYT3vRs73F_A@mail.gmail.com> (raw)
In-Reply-To: <a17912cb-d275-91f0-97b3-780ea47fc704@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 584 bytes --]
I think I could do some details review tomorrow on the plane, I am free
from the meeting hell tomorrow :p
Robin Dapp via Gcc-patches <gcc-patches@gcc.gnu.org> 於 2023年8月21日 週一 23:24
寫道：
> Hi Juzhe,
>
> thanks, this is a reasonable approach and improves readability noticeably.
> LGTM but I'd like to wait for other opinions (e.g. by Kito) as I haven't
> looked closely into the vsetvl pass before and cannot entirely review it
> quickly. As we already have good test coverage there is not much that
> can go wrong IMHO.
>
> Regards
> Robin
>
next prev parent reply other threads:[~2023-08-21 16:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 1:59 Juzhe-Zhong
2023-08-21 15:23 ` Robin Dapp
2023-08-21 16:06 ` Kito Cheng [this message]
2023-08-22 15:35 ` Kito Cheng
2023-08-22 23:02 ` 钟居哲
2023-08-23 1:27 ` juzhe.zhong
2023-08-23 12:34 ` juzhe.zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+yXCZBe9YUpc-KiCq1BMXGoK1jJeZGYa0xndEQYT3vRs73F_A@mail.gmail.com \
--to=kito.cheng@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@sifive.com \
--cc=rdapp.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).