From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe2d.google.com (mail-vs1-xe2d.google.com [IPv6:2607:f8b0:4864:20::e2d]) by sourceware.org (Postfix) with ESMTPS id 6AF5E38515C9 for ; Thu, 23 Mar 2023 08:33:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6AF5E38515C9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vs1-xe2d.google.com with SMTP id d18so13297659vsv.11 for ; Thu, 23 Mar 2023 01:33:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679560415; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0TgoI0MS66prEAzd8mJfmVPfi6VjvCEE8p+IZFw1gY8=; b=JQHwxwsPHSHJljkAAqaNufEI3LznOcXVAu8C2o/4so38z6eeCq86doCojZm5gs+ljx /OxefEmYbzL8yGhyxcdtNzQJSwPi4fh+oIQbUAUfSVlPGNP5r6Y1fZL9OTiQinoz2hWr Cm2KdtxyCh7zUUHkxzfD4TE99nj5V0W1TxTFrGYOkMSI+bPbKVX3lTI3WeBWSaqQ0kxQ +v99In/XiTqrJ0/wdBZx2qv1Qqiihz8k4Ds2n8oVG43P6IKZrGkw+sqBoyAfsoOPPq5l XUejVYeDSJPjaNyKUtb1Yntu3qmstElKpAF85QjsHr3qAV5d6aKSE8ZimzkSsz4jn2l4 noOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679560415; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0TgoI0MS66prEAzd8mJfmVPfi6VjvCEE8p+IZFw1gY8=; b=xEFlBQyWVIbNq7M0UlAWWacRoG1a/7/98DhXYmtWaA8ny0ZK0/aa7W67px8upTw/WY j/SLUge60hyR5knu4AYmXZqciRflyUxMqTQL3mpVu6EtNdh/fyoIpMHIR/Zw+cRsGPK+ 8UlbJVJM2WrVt1Fr2CIhMgGoquDuoiBm9NXYu/docQm74AymvqKgvQ9k/pVkzEWhc4Se BYBMcCcmCyUblaVsja5yKzMHVmJCl8O3qbonhvHPfqZ0ZsJCMK5JKBxvJdctmIuqARWR JqK4W10QFDDTXw1KI3s6ZjTYMXgi5pQD7aOXlGLPpnJJOes+uzZKVJJsjqbtfsKFUS1g myWQ== X-Gm-Message-State: AO0yUKVGbr1bPsZZi78WEaOZhx/dqDbOn+MshTzVvDVZ238pwlOPEILG BfhSvZOAb1oLSB+bbP/cWqRE/0UgyVYV99KTDx4= X-Google-Smtp-Source: AK7set/ChaWQxClNnk3I76uVN4SnjyxHuCE1uLfd8RFCuWBRRNOKBRsWnZf29tWTIU+1VCG/VxZJwruNSfo66nHf+5Y= X-Received: by 2002:a05:6102:3385:b0:426:6d5:a55a with SMTP id i5-20020a056102338500b0042606d5a55amr1587358vsh.1.1679560415440; Thu, 23 Mar 2023 01:33:35 -0700 (PDT) MIME-Version: 1.0 References: <20230321073849.21470-1-zhusonghe@eswincomputing.com> In-Reply-To: <20230321073849.21470-1-zhusonghe@eswincomputing.com> From: Kito Cheng Date: Thu, 23 Mar 2023 16:33:23 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Fix loss of function to script 'multilib-generator' To: Songhe Zhu Cc: gcc-patches@gcc.gnu.org, palmer@dabbelt.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Nice catch, committed to the trunk! On Tue, Mar 21, 2023 at 3:39=E2=80=AFPM Songhe Zhu wrote: > > The arch 'rv32imac' will not be created when excuting > './multilib-generator rv32imc-ilp32--a' > > The output is: > MULTILIB_OPTIONS =3D march=3Drv32imc mabi=3Dilp32 > MULTILIB_DIRNAMES =3D rv32imc ilp32 > MULTILIB_REQUIRED =3D march=3Drv32imc/mabi=3Dilp32 > MULTILIB_REUSE =3D > > Analysis : The alts:['rv32imc', 'rv32imac'] will change > to ['rv32imac', 'rv32imc'] through function:unique(alts) processing, > This is the wrong alts should not be changed. > This patch fix it. > > gcc/ChangLog: > * config/riscv/multilib-generator: Adjusting the loop of 'alt' in= 'alts'. > > Signed-off-by: Songhe Zhu > --- > gcc/config/riscv/multilib-generator | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/riscv/multilib-generator b/gcc/config/riscv/multi= lib-generator > index 9a6ce0223c9..0a3d4c07757 100755 > --- a/gcc/config/riscv/multilib-generator > +++ b/gcc/config/riscv/multilib-generator > @@ -175,7 +175,7 @@ for cmodel in cmodels: > # Drop duplicated entry. > alts =3D unique(alts) > > - for alt in alts[1:]: > + for alt in alts: > if alt =3D=3D arch: > continue > arches[alt] =3D 1 > -- > 2.17.1 >