From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id CF4253854174 for ; Mon, 31 Oct 2022 13:39:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CF4253854174 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x630.google.com with SMTP id f27so29490110eje.1 for ; Mon, 31 Oct 2022 06:39:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=urV9zKmm6aMLq7iIf2WnH2rP13kqZ8G7C+n7R7KbZ/o=; b=V8PGUrcKnTtdmod0zLyJoEHnSkqM6/BpO1H3LTypGppmprrdnINSD/3ais431g7IZQ vx8gySlFQkzlcW9PM+1qTNRjDiUdbRTtarm+++24nNZibn/OehYuF1SG0gMobGe/CLar 7j6KiFrlzSDrSANe2F5gvQIpeQVHCCmQJyHf221AYL6V4fwiaMfeB9acuyx4kJTYo/OM mQ4l8WRmsZki3QTDVk9FQB/GK+Bh3yHIS6UsLXtjNW8Rtn852W9SHwRyKgLk9jUOX1tC x0vPh1R6TaS9y7NrFV+9Kyp6ji682g4YuU/4BPF3eYCMP/norgP34utd+/PQK3mz2STR 4BcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=urV9zKmm6aMLq7iIf2WnH2rP13kqZ8G7C+n7R7KbZ/o=; b=oGpagMl9IosAsoKie0VJhMhPjH8H32VMGjQD5cgyWMwtf8+wMP1IENg69J3NmUuNGi JpgeWzu3AaWIV1M+KBOCX9F22DCYPt+2Ua1CBJCRWE4la71Kb+0WSM+arjcIpiueL/Tm yVDApBjmroGn/dJlOtGji3eRQLnwD5M1N9KWZBgl43wl0LMhaneyE0bpd6+hFhDnzFQN KB0MrDCfGXk9QVIAZrsS7AME1sTDkjfA6AMaPbPZ0pt4k3ZPxusOGJUQPM3MjMTTf+fW 9H7Qe4hLdUXMqHmKNWdDRS73hHwEfivxbLPHOs0UZTppJ3pD8er5dHbULUDVBDRFnHfw MePg== X-Gm-Message-State: ACrzQf1njcM/fcPE5Czd9CAx6uTLer+flX0XyCqOYAn4CNqfYN+SwP7B wbBKgh8t36ltp2VOUjvJ91nlvMiXH9nFDN9ssPs= X-Google-Smtp-Source: AMsMyM7E1ipPTL0ZN+cGBRZ+XRXq32herdOxvyY5GVzIak4wR/MI4bCP0TMIaCH1eu/KtR52Eu64j/va7vIFHatPaHY= X-Received: by 2002:a17:907:a087:b0:7ad:a4c4:873b with SMTP id hu7-20020a170907a08700b007ada4c4873bmr12574946ejc.58.1667223547223; Mon, 31 Oct 2022 06:39:07 -0700 (PDT) MIME-Version: 1.0 References: <20221027144152.335455-1-juzhe.zhong@rivai.ai> <1c75b0d5-74e9-d63b-ebdd-76a4f2dc6153@gmail.com> In-Reply-To: <1c75b0d5-74e9-d63b-ebdd-76a4f2dc6153@gmail.com> From: Kito Cheng Date: Mon, 31 Oct 2022 21:38:54 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Change constexpr back to CONSTEXPR To: Jeff Law Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Committed, thanks! On Fri, Oct 28, 2022 at 6:47 AM Jeff Law via Gcc-patches wrote: > > > On 10/27/22 08:41, juzhe.zhong@rivai.ai wrote: > > From: Ju-Zhe Zhong > > > > According to https://github.com/gcc-mirror/gcc/commit/f95d3d5de72a1c43e8d529bad3ef59afc3214705. > > Since GCC 4.8.6 doesn't support constexpr, we should change it back to CONSTEXPR. > > gcc/ChangeLog: > > > > * config/riscv/riscv-vector-builtins-bases.cc: Change constexpr back to CONSTEXPR. > > * config/riscv/riscv-vector-builtins-shapes.cc (SHAPE): Ditto. > > * config/riscv/riscv-vector-builtins.cc (struct registered_function_hasher): Ditto. > > * config/riscv/riscv-vector-builtins.h (struct rvv_arg_type_info): Ditto. > > OK. Please install. > > > Maybe we can move past gcc-4.8 as a bootstrapping requirement one day ;-) > > > Jeff > >