public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kito Cheng <kito.cheng@gmail.com>
To: Jim Wilson <jimw@sifive.com>
Cc: Geng Qi <gengqi@linux.alibaba.com>,
	GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] RISC-V: For '-march' and '-mabi' options, add 'Negative' property mentions itself.
Date: Tue, 11 May 2021 17:23:54 +0800	[thread overview]
Message-ID: <CA+yXCZBofmbfh8=0T+0OjUCpfDDEvpZ3dz_C8KpbxKvT-HGUAw@mail.gmail.com> (raw)
In-Reply-To: <CAFyWVaZu+bP-=thADOYF_wpgmRZ+o0BhGrBp=kh1eNkg=YF8ZA@mail.gmail.com>

It seems useful, I've backported to GCC 9/10/11.

Without this patch:
$ riscv64-unknown-elf-gcc -march=rv32imafd ~/hello.c -march=rv64gc
/scratch1/kitoc/riscv-gnu-workspace/rv64gc/install/bin/../lib/gcc/riscv64-unknown-elf/11.1.0/../../../../riscv64-unknown-elf/bin/ld:
unrecognised
emulation mode: elf3264lriscv
Supported emulations: elf64lriscv elf32lriscv elf64briscv elf32briscv
collect2: error: ld returned 1 exit status

With this patch:
$ riscv64-unknown-elf-gcc -march=rv32imafd ~/hello.c -march=rv64gc
// No error!

On Fri, Apr 30, 2021 at 11:42 AM Jim Wilson <jimw@sifive.com> wrote:
>
> On Wed, Apr 28, 2021 at 1:30 AM Geng Qi via Gcc-patches <
> gcc-patches@gcc.gnu.org> wrote:
>
> > gcc/ChangeLog:
> >         * config/riscv/riscv.opt (march=,mabi=): Negative itself.
> >
>
> Thanks.  I committed this.
>
> Do we need to backport to release branches?  This looks like an uncommon
> problem, or we would have noticed this before.
>
> Jim

      reply	other threads:[~2021-05-11  9:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28  8:29 Geng Qi
2021-04-30  2:25 ` Jim Wilson
2021-05-11  9:23   ` Kito Cheng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+yXCZBofmbfh8=0T+0OjUCpfDDEvpZ3dz_C8KpbxKvT-HGUAw@mail.gmail.com' \
    --to=kito.cheng@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gengqi@linux.alibaba.com \
    --cc=jimw@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).