From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by sourceware.org (Postfix) with ESMTPS id 2AEF53858281 for ; Mon, 17 Oct 2022 08:05:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2AEF53858281 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x530.google.com with SMTP id u21so14846626edi.9 for ; Mon, 17 Oct 2022 01:05:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nQy1jpOqJucmY1h5dlSiAVmGhGjMh/RszNxEQhmRnZU=; b=eAR6WoM5NfHdiJ5PLjSHMHqi+fwW19Tp9nfe7mU8CpS8poq2UuxGaAO8vgLPMCECHS BQBQ4PYckv8O1fdgM1pEY5zQI5HiG3d9VwsQNk66HqZ2QpgQQcvvPGm6g6eOCmao/i8C Rvb/tu0N7XHMry3/TSxHySfsRnknU1D00EZeZtH1szhkXV9jNHyHpXkjL3WDpedg/D/D 39SdTBW8toVdGCFGS4NZCTxAwK5aD2k9aMWUSSaaqoGjAAmCLLzs0IaQ8z5kXNIzAqlz 2zXTArZf05j/VUVmFFQ43Uc0meIq0vGZAU8NixD7rLF7PP2bqZSqgPeX/FZOJdp22bYH 3Y3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nQy1jpOqJucmY1h5dlSiAVmGhGjMh/RszNxEQhmRnZU=; b=LHHQgtU+55LEaXHcEj5TWwrKqloKNnxEUIOg0iNhMOvy4FLjDzaYjY237N+C6FzTzO yM572PLWI/UGzBU13SC6gcmNW8uGhLbQEZVovza7CwxTF0ZOzV1WmcIyTYln92gRVJms pSFxS+W2amcV8w7SeuK9T7ZkMN5uPfaSl3RhZzBcJvrQcY/8KmshTToXYxTKPM2Ylmpa eTt/Mpqmt7Phz60SfDofSrmRwbUVStvBd4HZSd+JFZSKQau2l7h8h3QM2Q0fxk+F+AVK HdOY+DhW9sjRtqx9ZgopDDpSq7v9obYklxVLz8v8M0UbFFANc5jiZRBUQXNL8MpsQjm7 06UQ== X-Gm-Message-State: ACrzQf2mOAUmwKKk4REn/G4GfccOcHaVuiF4JacpjcmlFXZWyFR6GzN6 gEisFpKD7KuwjmT58eV2Z2a8VToXyPHc/yRR0c4YDtnKZvY= X-Google-Smtp-Source: AMsMyM5XJqMtWewmJqtsiuVmZDir2C+OSoC1lRz2B7/zNKf39dsj4nXZ8wFZJUZrQ0IjSzbEnUVId7QAStEMAmzbQOE= X-Received: by 2002:a05:6402:1391:b0:459:cb69:9a2b with SMTP id b17-20020a056402139100b00459cb699a2bmr9010856edv.201.1665993929711; Mon, 17 Oct 2022 01:05:29 -0700 (PDT) MIME-Version: 1.0 References: <20221014230236.134044-1-juzhe.zhong@rivai.ai> In-Reply-To: <20221014230236.134044-1-juzhe.zhong@rivai.ai> From: Kito Cheng Date: Mon, 17 Oct 2022 16:05:16 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Reorganize mangle_builtin_type.[NFC] To: juzhe.zhong@rivai.ai Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Committed :) On Sat, Oct 15, 2022 at 7:03 AM wrote: > > From: Ju-Zhe Zhong > > Hi, this patch fixed my mistake in the previous commit patch. > Since "mangle_builtin_type" is a global function will be called in riscv.cc. > It's reasonable move it down and put them together stay with other global functions. > > gcc/ChangeLog: > > * config/riscv/riscv-vector-builtins.cc (mangle_builtin_type): Move down the function. > --- > gcc/config/riscv/riscv-vector-builtins.cc | 26 +++++++++++------------ > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/gcc/config/riscv/riscv-vector-builtins.cc b/gcc/config/riscv/riscv-vector-builtins.cc > index 99c482582d3..55d45651618 100644 > --- a/gcc/config/riscv/riscv-vector-builtins.cc > +++ b/gcc/config/riscv/riscv-vector-builtins.cc > @@ -155,19 +155,6 @@ lookup_vector_type_attribute (const_tree type) > return lookup_attribute ("RVV type", TYPE_ATTRIBUTES (type)); > } > > -/* If TYPE is a built-in type defined by the RVV ABI, return the mangled name, > - otherwise return NULL. */ > -const char * > -mangle_builtin_type (const_tree type) > -{ > - if (TYPE_NAME (type) && TREE_CODE (TYPE_NAME (type)) == TYPE_DECL) > - type = TREE_TYPE (TYPE_NAME (type)); > - if (tree attr = lookup_vector_type_attribute (type)) > - if (tree id = TREE_VALUE (chain_index (0, TREE_VALUE (attr)))) > - return IDENTIFIER_POINTER (id); > - return NULL; > -} > - > /* Return a representation of "const T *". */ > static tree > build_const_pointer (tree t) > @@ -250,6 +237,19 @@ register_vector_type (vector_type_index type) > builtin_types[type].vector_ptr = build_pointer_type (vectype); > } > > +/* If TYPE is a built-in type defined by the RVV ABI, return the mangled name, > + otherwise return NULL. */ > +const char * > +mangle_builtin_type (const_tree type) > +{ > + if (TYPE_NAME (type) && TREE_CODE (TYPE_NAME (type)) == TYPE_DECL) > + type = TREE_TYPE (TYPE_NAME (type)); > + if (tree attr = lookup_vector_type_attribute (type)) > + if (tree id = TREE_VALUE (chain_index (0, TREE_VALUE (attr)))) > + return IDENTIFIER_POINTER (id); > + return NULL; > +} > + > /* Initialize all compiler built-ins related to RVV that should be > defined at start-up. */ > void > -- > 2.36.1 >