From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa30.google.com (mail-vk1-xa30.google.com [IPv6:2607:f8b0:4864:20::a30]) by sourceware.org (Postfix) with ESMTPS id 842D03851C20 for ; Thu, 26 Jan 2023 19:13:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 842D03851C20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vk1-xa30.google.com with SMTP id t2so1350815vkk.9 for ; Thu, 26 Jan 2023 11:13:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=tC8ciG2nkbsAvFUTSxEqB0sQZnfkRfatIqGJELMr6NQ=; b=oixGmGPswQ//sAgdTeXn8SuoiUQhpeMIPLf6AKJFtBUrQK//MDjAlSTLqKQQzHUORO BlQBnhmg8f6XYxxmhyqrx4PtKD4MQ6uWHUnKkurDIdNgaVD7FOsOPRUsNmPWaXbDEnVA aGuZk+1TQw7iRX5FYlqfA2Oo9+GTcqsnT9UhJ9nPdlZxM8MqxkjJg+FpGP4dAhSqJxWK du3YcU77JeI3l2nPGcM4yNyr5PGK3hQ7oGYwi7Tii/ATlohLgxFuL8MgD+IjfthH++hW GZ9HcBFaItSEOLFAg6apctFxFnoCIZWhZOuFkHg3qZHEdqDDi4S/HpWAmAMcfDJ+JB/G 2dYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tC8ciG2nkbsAvFUTSxEqB0sQZnfkRfatIqGJELMr6NQ=; b=1VGb5hkeo5/SJyNZBMDD/IEs2LWd9bh+2RyNne0uyocEuaP3lDNHzKGV3Lx1Ulyeyc ZZwlg8H/G72lyCMGI0CYGqZWBSpC9Cuadro8zCgQI88dMigY6lwWeDsQqqXw0aOeaQuH MflwMDvKK2kz+KideXBi6Av3I9CuSjzaHc+OslYEh2aeODhk7Wix6TsyJpJM/k/w01Pp sBMAva76w8pYqpPMTVajI8Q7zSWjgPIrgV185VwSduRggVEn+t7K+e6SgcUO3Aqsw9Zk iMuzsi4C/N/jWZcihiU+p1zlMbJ7wQN3ztgA1vj/9wTcMrBFz+oFHeudgBXmOgXD5dzc Kcug== X-Gm-Message-State: AO0yUKXS7zT6CaerT7s+lsTfPNFROYRtffeYz4Ie/sXXiZ+yhNk8Vo8m iqw3Sn/3eGyu4qDUMC2RZ+ov73rG+RDOKimPutg= X-Google-Smtp-Source: AK7set+HgFpi3rvTYyS56viO4MJE0WW7i7nQcXWZoIIYnY14w3ZhMYDVmgwlSOKIyE3gEHNHPGOokwADmismcOXx4w0= X-Received: by 2002:a1f:1fc3:0:b0:3e8:dc72:948 with SMTP id f186-20020a1f1fc3000000b003e8dc720948mr161065vkf.11.1674760404458; Thu, 26 Jan 2023 11:13:24 -0800 (PST) MIME-Version: 1.0 References: <20230103071159.147469-1-juzhe.zhong@rivai.ai> In-Reply-To: <20230103071159.147469-1-juzhe.zhong@rivai.ai> From: Kito Cheng Date: Fri, 27 Jan 2023 03:13:12 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Fix wrong in_group flag in validate_change call function To: juzhe.zhong@rivai.ai Cc: gcc-patches@gcc.gnu.org, palmer@dabbelt.com Content-Type: multipart/alternative; boundary="000000000000fde56f05f32f8ac3" X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000fde56f05f32f8ac3 Content-Type: text/plain; charset="UTF-8" committed, thanks. On Tue, Jan 3, 2023 at 3:12 PM wrote: > From: Ju-Zhe Zhong > > Since we only change insn which is not in group. The flag currently is not > correct. > > gcc/ChangeLog: > > * config/riscv/riscv-vsetvl.cc (change_insn): Adjust in_group in > validate_change. > > --- > gcc/config/riscv/riscv-vsetvl.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/riscv/riscv-vsetvl.cc > b/gcc/config/riscv/riscv-vsetvl.cc > index 1afe76304fb..ad0457ed89d 100644 > --- a/gcc/config/riscv/riscv-vsetvl.cc > +++ b/gcc/config/riscv/riscv-vsetvl.cc > @@ -787,7 +787,7 @@ change_insn (rtx_insn *rinsn, rtx new_pat) > print_rtl_single (dump_file, PATTERN (rinsn)); > } > > - validate_change (rinsn, &PATTERN (rinsn), new_pat, true); > + validate_change (rinsn, &PATTERN (rinsn), new_pat, false); > > if (dump_file) > { > -- > 2.36.3 > > --000000000000fde56f05f32f8ac3--