From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe34.google.com (mail-vs1-xe34.google.com [IPv6:2607:f8b0:4864:20::e34]) by sourceware.org (Postfix) with ESMTPS id 4417D3971338 for ; Mon, 19 Dec 2022 02:49:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4417D3971338 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vs1-xe34.google.com with SMTP id f189so7459882vsc.11 for ; Sun, 18 Dec 2022 18:49:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RkJwA1sKOT/bsY3qbpanVceDXNeiLmtptS6nU0q53Bo=; b=ZPuJlCGtVHSjP/Kjl1vIA6O19qW/iqNjr1RiTsz4pzDxrsEhKsHf3pVPaUWdAfoVzf IkuAoiGorWi37wUzPtfXDFoj+oW980xEnubcXEs7o1D7QpI1puqa3JZXpGttdWumUaj3 Tjrn+51VX/9QGypQJE71ajV0HV9uFFMPYXeRFNqIsW4bmM6iqVMdFrt5MHdcc/dXap2l 0Kpceh5kPdzD89Ww4m1/QEOGCxeDr83azwBdaDeXhq64KFAXTMaJFLn6EL9pjuKF5/sk 8y8W3X0CUN2x0WiSxxIQ68apek0lr/bOIWvvLEPwhT/Kp61a1p4ARcj2EsbHFg4Zfb/K Qa+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RkJwA1sKOT/bsY3qbpanVceDXNeiLmtptS6nU0q53Bo=; b=Pylpqn3GHTNTa48E6OL6vZuOzFx8EKUROUeNpNtnFNXTaPWZG/A23p9vtX4y5/CQ6a R7AK8r8jDQmbV9Lhj5jmzyMk2yjFFVKpeUDos5tmAk5NlgXoLrFp7ovs/PqKHM9znK7Z INnok6q2k7wAjpCbEG8/jH55yjPyiprBgEB1MhRuF1U9MoEy4ATJBjAzL06ZP3SIENn1 AQx3gpiFv20Hu+4I4EdVSXLzuTaVcITAzRkT3joWJg39V7STb9y8SYZqAc7ZWAJf50pI +Z9lVl61nfU4E6epat7F0g5wiCWGZhx5LFX4sR4BQ2TnZrdGaV+VGXwgZi/yov/FfO9c BJ1A== X-Gm-Message-State: ANoB5pmvMtXNUAvtRBpCr8ZrVKabpumeMv5s26rgDRdWzOKM+9+O3be/ GvTGTft+3xpMvq+ujKdZvn5wPBNF13Sbpj2uM08= X-Google-Smtp-Source: AA0mqf4gK+z/+Y/9MajytdByBwSllE9jca352VmjavCUx+E5crGUEszxlfTgh+iDsz/90OjuD6MAw8TBbuX8hv/08rg= X-Received: by 2002:a67:f2c4:0:b0:3b0:f932:5a40 with SMTP id a4-20020a67f2c4000000b003b0f9325a40mr21457498vsn.30.1671418148189; Sun, 18 Dec 2022 18:49:08 -0800 (PST) MIME-Version: 1.0 References: <20221219010838.3878675-1-christoph.muellner@vrull.eu> <20221219010838.3878675-2-christoph.muellner@vrull.eu> In-Reply-To: <20221219010838.3878675-2-christoph.muellner@vrull.eu> From: Kito Cheng Date: Mon, 19 Dec 2022 10:48:56 +0800 Message-ID: Subject: Re: [PATCH v2 01/11] riscv: attr: Synchronize comments with code To: Christoph Muellner Cc: gcc-patches@gcc.gnu.org, Kito Cheng , Jim Wilson , Palmer Dabbelt , Andrew Waterman , Philipp Tomsich , Jeff Law , Cooper Qu , Lifang Xia , Yunhai Shang , Zhiwei Liu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: LGTM, you can commit this separately if you want :) On Mon, Dec 19, 2022 at 9:09 AM Christoph Muellner wrote: > > From: Christoph M=C3=BCllner > > The comment above the enumeration of existing attributes got out of > order and a few entries were forgotten. > This patch synchronizes the comments according to the list. > This commit does not include any functional change. > > gcc/ChangeLog: > > * config/riscv/riscv.md: Sync comments with code. > > Signed-off-by: Christoph M=C3=BCllner > --- > gcc/config/riscv/riscv.md | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/gcc/config/riscv/riscv.md b/gcc/config/riscv/riscv.md > index df57e2b0b4a..a8bb331f25c 100644 > --- a/gcc/config/riscv/riscv.md > +++ b/gcc/config/riscv/riscv.md > @@ -220,7 +220,6 @@ (define_attr "enabled" "no,yes" > ;; mfc transfer from coprocessor > ;; const load constant > ;; arith integer arithmetic instructions > -;; auipc integer addition to PC > ;; logical integer logical instructions > ;; shift integer shift instructions > ;; slt set less than instructions > @@ -236,9 +235,13 @@ (define_attr "enabled" "no,yes" > ;; fcvt floating point convert > ;; fsqrt floating point square root > ;; multi multiword sequence (or user asm statements) > +;; auipc integer addition to PC > +;; sfb_alu SFB ALU instruction > ;; nop no operation > ;; ghost an instruction that produces no real code > ;; bitmanip bit manipulation instructions > +;; rotate rotation instructions > +;; atomic atomic instructions > ;; Classification of RVV instructions which will be added to each RVV .m= d pattern and used by scheduler. > ;; rdvlenb vector byte length vlenb csrr read > ;; rdvl vector length vl csrr read > -- > 2.38.1 >