From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by sourceware.org (Postfix) with ESMTPS id 779923858D35 for ; Thu, 21 Dec 2023 09:44:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 779923858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 779923858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::535 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703151845; cv=none; b=DqYMh6sEqg1cSzU0JhNJUe8p/mr4oim3HplF8KxuFG6hhJ5K8F44+RyoFqcNmAgpC9jmMnQiHqnd1fSqaQkw0veZDXVGO7cStJ/kzYcjY7405n33DsY2l1vULs0WgImUBsLJVPU9+R9ItiZLgJBVlNxjObWqk9HS/qx+OtJNkRE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703151845; c=relaxed/simple; bh=unc6v2skMqGqHkEDtRJfm+hpJOUatENGWsy1y9Krptk=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=E2ntFzZycwCRQfSm45JzOuh8IDHW6JhdT6szx8ytH0+3P7DTVPdjbRSIlS7UgX8bj9CX64DT+QZqlotcVOnO4bcTlwF3hvzfeV8UsFTVgu1e6cuyiiCL9+yaUc5Adsb3nrvvK73KbNCii+5WBn7yGY1btIgc2/NasP6Xll/bl3c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-54c70c70952so693989a12.3 for ; Thu, 21 Dec 2023 01:44:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703151842; x=1703756642; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qOoRVCDEkl1oR4XVnuNECofC/y6WuiOlfJ6RhDiGOeQ=; b=Jt/QftwFnAJZ7/sEjmTMyinvc3AB4b6zqgbwNZIdf0AghtwR6RTgATJz6zpBlhZWdW gvCqv9pet2fdkg0KaZNMF4uWAsAHtE3NcSb4Qq/GjmQOeAhpJBkuVdtWprBPkZvafqaT mEf0dJg26/JDl3HhMzfK+W7iYh82bSbwX6Xtap6SmjdTBlkU+up6Hxm9+Jj1tP1xGgsY 2lYY9y20DIxzx3TnlhoMUNERvpbkJLQWVxjSHMW3orDn2Xob1o3oo7NFtwiMiwFWl6MO xPrpiBb9cziE9C6sVS4oEd9lUjVV/uS6vVLPG2LpYkEhGrWbnZhr31h6i+TxwzcOvdb/ yVoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703151842; x=1703756642; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qOoRVCDEkl1oR4XVnuNECofC/y6WuiOlfJ6RhDiGOeQ=; b=bcs1lB5Y+1cRlj8nKSYMt9vxqdeyMO9PEB9hvU/dHwU8Fit3XzurAWVCuZniWSTfEe q3yEV0RZnIwuLxp+Wh8PY/At0iTbr6dEEt6LuDAqqd155GlPDvb3ffQGLOz2e0svKieg PwrtgUGKIMJOZA+QWWIyamvIRxn9+f7NjuvDG1Ude1xNkGDB/ua3NJGtKgBPKEcs+IwF tGoiX8cStQMLaTqRhQQQsKok7ZwTNT6qJsPaVmqYwngFsJ2i0GbAseEaBZFTU7IbomNz sI+LdR52PGMTVQfW1rRsTlpFE6k9Ri72eiUmuuxij1q87Fawe5C/mnCfHjCAGGTQCRWH lTwg== X-Gm-Message-State: AOJu0YzeXPVXsJ1vMNuvKlwfJWWKTJ2f6K7RPtrvQvu3uKZ8mV9+wRgd Jdypv/IpHDwXzY46BmvyQzlCdAIe2TQuj6vSeV4= X-Google-Smtp-Source: AGHT+IHgSA5gs68L0/DI0bZz9goQupp8HlGQHTqMZ1YVoK6TW5FYNiLUBMHN117EKG/FSbFPpNv0v3lVpJJwtO57l2g= X-Received: by 2002:a17:906:3f56:b0:a19:a19b:426b with SMTP id f22-20020a1709063f5600b00a19a19b426bmr6970504ejj.214.1703151841633; Thu, 21 Dec 2023 01:44:01 -0800 (PST) MIME-Version: 1.0 References: <20231220122055.343-1-cooper.joshua@linux.alibaba.com> <20231220123249.555-1-cooper.joshua@linux.alibaba.com> <60201857-c9c2-4e20-a79d-cc4bdbfb17bb@gmail.com> In-Reply-To: <60201857-c9c2-4e20-a79d-cc4bdbfb17bb@gmail.com> From: Kito Cheng Date: Thu, 21 Dec 2023 17:43:49 +0800 Message-ID: Subject: Re: [PATCH v3 4/6] RISC-V: Adds the prefix "th." for the instructions of XTheadVector. To: Jeff Law Cc: =?UTF-8?B?6ZKf5bGF5ZOy?= , "cooper.joshua" , gcc-patches , "jim.wilson.gcc" , palmer , andrew , "philipp.tomsich" , =?UTF-8?Q?Christoph_M=C3=BCllner?= , jinma , Cooper Qu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Why not just check the prefix is 'v'? I don't think xtheadvector able to work with other vector stuffs like vector crypto or any other new vector stuffs, then we don't need extra attribute. On Thu, Dec 21, 2023 at 12:42=E2=80=AFPM Jeff Law w= rote: > > > > On 12/20/23 15:48, =E9=92=9F=E5=B1=85=E5=93=B2 wrote: > > >> So rather than looking at the mode, would it make more sense to hav= e an > >>>attribute (or re-use an existing attribute) to identify which opcodes > >>>are going to need prefixing? We've got access to the INSN via > >>>current_output_insn. So we can lookup attributes trivially. > > > > Yes, I totally aggree with Jeff's idea. We have addes many attributes > > for each RVV instructions. > > For example, VSETVL PASS is highly depending on those attribute to do > > the optimizations. > Also note that with attributes, we can potentially even deal with cases > where some alternatives need special handling while other alternatives > simply aren't available with the thead extension. Not sure if that's > going to be needed or not, but it's worth remembering. > > Jeff