From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa33.google.com (mail-vk1-xa33.google.com [IPv6:2607:f8b0:4864:20::a33]) by sourceware.org (Postfix) with ESMTPS id C09953858D33 for ; Thu, 16 Feb 2023 14:00:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C09953858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vk1-xa33.google.com with SMTP id m65so1214573vkh.10 for ; Thu, 16 Feb 2023 06:00:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1676556026; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=JFaYkbFBgH+v3j8NtZ12lfPJkF49s2RkBVLGIITlIgA=; b=aJq7CPE9BsXqaBBL+G7Nicav0iMCzF5Fdahiw0eLKUsIZxbrJui49+xak/uSKBkIbn Lgzp5bDioGOB0gjfY/q+jWsw9RCH1QV4M+GC+6m9J0aIdOJh+mGocX6vWvZbpfqRJxnO siln9Bnx7LpGPpgGI0JPtY+39O8/zpVkDEyYTXqXThNCxe1RmEymtyWBNC5b1ENfaR+H H7m3WmVV7qE3okrKZ5PBIgVWE/tr0mM89zw5KCG8VE9B4xi/i6Mm94iri4C0eWBot+r3 952hoo0PRBjm8nD3Kvp8RI1iG97vBroYx6cBLisluYNcftKcM8ST1g/26xzhOzM5f5tV 5frw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676556026; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JFaYkbFBgH+v3j8NtZ12lfPJkF49s2RkBVLGIITlIgA=; b=ynxbAv5OC7Cm2Zypf9gCVEpAetaWRY3BNMuHB5KraY7qZOI7eZOwX87LWCVjD+3zJd rlB56PwE50PZAe/02UAuyW8/z/JGHxQKDdGjQpebGQlT31ub6pa8QK+AZlaSQIxJe0+s UcmEPo8sgEmUPcisfWzzBRQdWSWBg8PX6vyn/P1WXDKgXMbRZvHukUAEKK04ylyz3S3K C/rhqp/mxMVfaTn6xJQdfr1zp2aT6hOHvWAt/6jmafgJGcWG6t7Dqob7C3zC8eag/uz2 ayXXvLy7NVkvsKgrjqCx+qbzo/Tbn8m1FcF+QMFCp/LzvWsosZLYiabs/0aSr4myhgdr OQtw== X-Gm-Message-State: AO0yUKWBz75pbKmRxNKoGXw7tcGgsOmOiTUtUrBk/ZdX1fRBEqZ6xJE7 aOr5r6/gFpJgoh+S+4VIeOmUmkFB/6dDGLso7KU= X-Google-Smtp-Source: AK7set/Gfi9Srn/hizZryNL4NxXUv2k8mnEZ70UfpfpRkqu2Y98jGr/T79k9p1F2e43RGK4BdXbEVmYMsZymWIz1WA0= X-Received: by 2002:a1f:2f45:0:b0:401:b0cc:f96f with SMTP id v66-20020a1f2f45000000b00401b0ccf96fmr926735vkv.11.1676556025904; Thu, 16 Feb 2023 06:00:25 -0800 (PST) MIME-Version: 1.0 References: <20230216075005.2600-1-shihua@iscas.ac.cn> In-Reply-To: From: Kito Cheng Date: Thu, 16 Feb 2023 22:00:14 +0800 Message-ID: Subject: Re: [PATCH V2 0/5] RISC-V: Implement Scalar Cryptography Extension To: Markku-Juhani Olavi Saarinen Cc: Liao Shihua , gcc-patches@gcc.gnu.org, jiawei@iscas.ac.cn, palmer@dabbelt.com, shiyulong@iscas.ac.cn, ben.marshall@pqshield.com, christoph.muellner@vrull.eu Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Markku-Juhani: Scalar crypto is ratified I know, but the scalar crypto intrinsic part isn't standardized - and even the APIs listed in riscv_scalar_crypto.h are not documented anywhere yet. So what I mean is I am happy to accept this patch except the riscv_scalar_crypto.h header. Once the API has documented and merged I am happy to accept that part too. On Thu, Feb 16, 2023 at 9:52 PM Markku-Juhani Olavi Saarinen wrote: > > On Thu, Feb 16, 2023, 13:29 Kito Cheng wrote: > > > Hi Shihua: > > > > Thanks for your patches! This patch set is generally in good shape, > > but I would prefer to remove riscv_scalar_crypto.h at this moment > > since it's NOT standardized yet. > > > > Hi Kito, > > I'm not sure if you're referring to the scalar crypto extensions (which > were fully ratified in November 2021 by RVI, are included in several > profiles, and available in commercial silicon IP), or this particular > header file. Note that the single header is perhaps the most convenient way > to access these subextensions that make up the scalar crypto extension 1.0. > > Cheers, > Markku > > > > > Do you mind sending a new version of this patch set which does not > > include that and also update the testcases? > > > > > > > > On Thu, Feb 16, 2023 at 3:52 PM Liao Shihua wrote: > > > > > > This series adds basic support for the Scalar Cryptography extensions: > > > * Zbkb > > > * Zbkc > > > * Zbkx > > > * Zknd > > > * Zkne > > > * Zknh > > > * Zksed > > > * Zksh > > > > > > The implementation follows the version Scalar Cryptography v1.0.0 of the > > specification, > > > and the intrinsic of Scalar Cryptography extensions follows riscv-c-api > > > which can be found here: > > > https://github.com/riscv/riscv-crypto/releases/tag/v1.0.0-scalar > > > https://github.com/riscv-non-isa/riscv-c-api-doc/pull/31 > > > > > > It works by Wu Siyu and Liao Shihua . > > > > > > Liao Shihua (5): > > > Add prototypes for RISC-V Crypto built-in functions > > > Implement ZBKB, ZBKC and ZBKX extensions > > > Implement ZKND and ZKNE extensions > > > Implement ZKNH extensions > > > Implement ZKSH and ZKSED extensions > > > > > > gcc/config.gcc | 2 +- > > > gcc/config/riscv/bitmanip.md | 20 +- > > > gcc/config/riscv/constraints.md | 8 + > > > gcc/config/riscv/crypto.md | 435 ++++++++++++++++++ > > > gcc/config/riscv/riscv-builtins.cc | 26 ++ > > > gcc/config/riscv/riscv-crypto.def | 94 ++++ > > > gcc/config/riscv/riscv-ftypes.def | 10 + > > > gcc/config/riscv/riscv.md | 4 +- > > > gcc/config/riscv/riscv_scalar_crypto.h | 218 +++++++++ > > > gcc/testsuite/gcc.target/riscv/zbkb32.c | 36 ++ > > > gcc/testsuite/gcc.target/riscv/zbkb64.c | 28 ++ > > > gcc/testsuite/gcc.target/riscv/zbkc32.c | 17 + > > > gcc/testsuite/gcc.target/riscv/zbkc64.c | 17 + > > > gcc/testsuite/gcc.target/riscv/zbkx32.c | 18 + > > > gcc/testsuite/gcc.target/riscv/zbkx64.c | 18 + > > > gcc/testsuite/gcc.target/riscv/zknd32.c | 18 + > > > gcc/testsuite/gcc.target/riscv/zknd64.c | 36 ++ > > > gcc/testsuite/gcc.target/riscv/zkne32.c | 18 + > > > gcc/testsuite/gcc.target/riscv/zkne64.c | 30 ++ > > > gcc/testsuite/gcc.target/riscv/zknh-sha256.c | 29 ++ > > > .../gcc.target/riscv/zknh-sha512-32.c | 43 ++ > > > .../gcc.target/riscv/zknh-sha512-64.c | 31 ++ > > > gcc/testsuite/gcc.target/riscv/zksed.c | 20 + > > > gcc/testsuite/gcc.target/riscv/zksh.c | 19 + > > > 24 files changed, 1183 insertions(+), 12 deletions(-) > > > create mode 100644 gcc/config/riscv/crypto.md > > > create mode 100644 gcc/config/riscv/riscv-crypto.def > > > create mode 100644 gcc/config/riscv/riscv_scalar_crypto.h > > > create mode 100644 gcc/testsuite/gcc.target/riscv/zbkb32.c > > > create mode 100644 gcc/testsuite/gcc.target/riscv/zbkb64.c > > > create mode 100644 gcc/testsuite/gcc.target/riscv/zbkc32.c > > > create mode 100644 gcc/testsuite/gcc.target/riscv/zbkc64.c > > > create mode 100644 gcc/testsuite/gcc.target/riscv/zbkx32.c > > > create mode 100644 gcc/testsuite/gcc.target/riscv/zbkx64.c > > > create mode 100644 gcc/testsuite/gcc.target/riscv/zknd32.c > > > create mode 100644 gcc/testsuite/gcc.target/riscv/zknd64.c > > > create mode 100644 gcc/testsuite/gcc.target/riscv/zkne32.c > > > create mode 100644 gcc/testsuite/gcc.target/riscv/zkne64.c > > > create mode 100644 gcc/testsuite/gcc.target/riscv/zknh-sha256.c > > > create mode 100644 gcc/testsuite/gcc.target/riscv/zknh-sha512-32.c > > > create mode 100644 gcc/testsuite/gcc.target/riscv/zknh-sha512-64.c > > > create mode 100644 gcc/testsuite/gcc.target/riscv/zksed.c > > > create mode 100644 gcc/testsuite/gcc.target/riscv/zksh.c > > > > > > -- > > > 2.38.1.windows.1 > > > > >