From: Kito Cheng <kito.cheng@gmail.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 1/1] RISC-V: Imply 'Zicsr' from 'Zcmt'
Date: Thu, 31 Aug 2023 17:10:11 +0800 [thread overview]
Message-ID: <CA+yXCZC8C=00zRGawUinRexvjEaWvABfwXAraBtVpB-yOQ8CTA@mail.gmail.com> (raw)
In-Reply-To: <b5e431af-b954-4b0e-b3a2-634a37f0ed5a@irq.a4lg.com>
Hi Tsukasa:
I guess you might did something wrong during commit this patch and
"RISC-V: Add stub support for existing extensions"
https://github.com/gcc-mirror/gcc/commit/f30d6a48635b5b180e46c51138d0938d33abd942
On Tue, Aug 29, 2023 at 4:55 PM Tsukasa OI via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> On 2023/08/29 17:42, Kito Cheng wrote:
> > LGTM, did you have commit access for GCC repo? you should obtain it if
> > you don't have it yet, I think you are already an important member of
> > the RISC-V GNU toolchain community :)
>
> Not yet (only Binutils/GDB). Jeff is mainly merging my changes to the
> trunk so far.
>
> Thanks for mentioning and sponsoring me for write access to GCC. I
> truly appreciate that mentioning me as an important member and write
> access to the GCC repository will be also helpful.
>
> I'll contact GCC overseers later.
>
> Sincerely,
> Tsukasa
>
> >
> > https://gcc.gnu.org/gitwrite.html#authenticated , and you can add me
> > to the cc list as your sponsor.
> >
> >
> >
> > On Tue, Aug 29, 2023 at 11:42 AM Tsukasa OI via Gcc-patches
> > <gcc-patches@gcc.gnu.org> wrote:
> >>
> >> From: Tsukasa OI <research_trasio@irq.a4lg.com>
> >>
> >> As the specification states, the 'Zcmt' extension depends on the 'Zca' and
> >> 'Zicsr' extensions. This commit reflects this implication.
> >>
> >> gcc/ChangeLog:
> >>
> >> * common/config/riscv/riscv-common.cc
> >> (riscv_implied_info): Add implication from 'Zcmt' to 'Zicsr'.
> >> ---
> >> gcc/common/config/riscv/riscv-common.cc | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/gcc/common/config/riscv/riscv-common.cc b/gcc/common/config/riscv/riscv-common.cc
> >> index a5b62cda3a09..1315c8a745ec 100644
> >> --- a/gcc/common/config/riscv/riscv-common.cc
> >> +++ b/gcc/common/config/riscv/riscv-common.cc
> >> @@ -142,6 +142,7 @@ static const riscv_implied_info_t riscv_implied_info[] =
> >> {"zcb", "zca"},
> >> {"zcmp", "zca"},
> >> {"zcmt", "zca"},
> >> + {"zcmt", "zicsr"},
> >>
> >> {NULL, NULL}
> >> };
> >> --
> >> 2.42.0
> >>
> >
next prev parent reply other threads:[~2023-08-31 9:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 3:40 [PATCH 0/1] " Tsukasa OI
2023-08-29 3:40 ` [PATCH 1/1] " Tsukasa OI
2023-08-29 8:42 ` Kito Cheng
2023-08-29 8:54 ` Tsukasa OI
2023-08-31 9:10 ` Kito Cheng [this message]
2023-08-31 9:13 ` Tsukasa OI
2023-08-31 9:16 ` Kito Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+yXCZC8C=00zRGawUinRexvjEaWvABfwXAraBtVpB-yOQ8CTA@mail.gmail.com' \
--to=kito.cheng@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=research_trasio@irq.a4lg.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).