From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id DC91D3856DC1 for ; Wed, 25 May 2022 14:00:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DC91D3856DC1 Received: by mail-ej1-x631.google.com with SMTP id f21so28210396ejh.11 for ; Wed, 25 May 2022 07:00:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WwMfKRhqswRvX5JocbDC3y/MEOqySDMjtoy/nVoMRv8=; b=N3u/TYJ2MEcVWepoQ7oPAEsIQsnL2VDRM4LJe5wCqiu+6K/GD+T6uzIXV21Khv2iLI zEqMcyvWDgkMRmXsu7ZZ71yAZivhjE1zghgqv/AixlkYfbn6TSqy1B9q/7vqS2tepZXs TheoJ03tZjPz0ROMbrFfLqo5BXtw9ulFNetYQoHLrX4y53NR8J1T9LCjD0oyeFGtqbTP DM4SDPgA+9rnwfd/1XEBbtoW30vzrc/cP4MSZygcn04zOVtpfebpm8nrN40tRLxjHbgO fJt0gbPk6C6R9X0Z3zHdHScrLIbG2KiGg8Z/TIf40lQ0KbRK61k1vAfEyZ8cs9ahubCg FWAQ== X-Gm-Message-State: AOAM5321DfsoBtHvAHjes+y9fjIlmzc4fz3ussbweAxiTsEkHouz8JFM xjZrOT/1zKuBY7o6/bcMspZyy/5GI25uxidWDvU= X-Google-Smtp-Source: ABdhPJxP1MOr4NJTve5HQwV4hzptl2y/Ppw/aPSOvy4J2lt5JkhjFntOruRAQ6fVTuz5iXZ3K1NYDtgMCC6r1v7P+QY= X-Received: by 2002:a17:907:3ea5:b0:6fe:ce25:7a69 with SMTP id hs37-20020a1709073ea500b006fece257a69mr16139987ejc.626.1653487222281; Wed, 25 May 2022 07:00:22 -0700 (PDT) MIME-Version: 1.0 References: <6210fc0f-caaf-7bf8-4ab1-ec08760914d7@embecosm.com> In-Reply-To: <6210fc0f-caaf-7bf8-4ab1-ec08760914d7@embecosm.com> From: Kito Cheng Date: Wed, 25 May 2022 22:00:11 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Don't unconditionally add m, a, f, d in arch-canonicalize To: Simon Cook Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GAPPY_SUBJECT, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2022 14:00:25 -0000 Committed, Thanks for fixing my stupid bug :P On Wed, May 25, 2022 at 9:26 PM Simon Cook wrote: > > This solves an issue where rv32i, etc. are canonicalized to rv32imafd > since the g->i addition of 'm', 'a', 'f', 'd' is not actually gated by > whether the input was rv32g/rv64g. > > gcc/ChangeLog: > > * config/riscv/arch-canonicalize: Only add mafd extension if > base was rv32/rv64g. > --- > gcc/config/riscv/arch-canonicalize | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/riscv/arch-canonicalize > b/gcc/config/riscv/arch-canonicalize > index 71b2232b29e..fd7651ac491 100755 > --- a/gcc/config/riscv/arch-canonicalize > +++ b/gcc/config/riscv/arch-canonicalize > @@ -73,8 +73,8 @@ def arch_canonicalize(arch, isa_spec): > std_exts = [] > if arch[:5] in ['rv32e', 'rv32i', 'rv32g', 'rv64i', 'rv64g']: > new_arch = arch[:5].replace("g", "i") > - std_exts = ['m', 'a', 'f', 'd'] > if arch[:5] in ['rv32g', 'rv64g']: > + std_exts = ['m', 'a', 'f', 'd'] > if not is_isa_spec_2p2: > extra_long_ext = ['zicsr', 'zifencei'] > else: > -- > 2.32.1