From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id D580D3858424 for ; Sun, 19 Nov 2023 05:53:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D580D3858424 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D580D3858424 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::629 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700373205; cv=none; b=NvDHjggGGiTOugxDwGDfdQF4KWTj+nqHD2wLqVyaFdnOX2dMBgCrevcUhf5t2pA5uzrAOUoXsNLkI58fGpvYfpQibAx+RVgccPd7vB66RTZ0D+vjqBfFP1NFhcFdoE9uwITIFI/WAndjTFw8/YXZsWDRZ/Tkk9xjhQPCu/wzG84= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700373205; c=relaxed/simple; bh=9vFa77aGESJtF83NRTV8J7lyFGqrq3e+q6bz2zwVqFE=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=wFvpEJvAicrq7IIPYnEnz+fT9Z+voJXo9zhiuFtA7hckIkxorgbG7DUnBJILUFledq9W3CnrEs67RRsLXUrFBuZHkXgMFXuf6L+Qb6PWAgfFwu5YnsCrPKnl2U9QeMFv1jWxTBHnT0DW/zDLphTF6Uft4+QV6LLzQqgih++8QpA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-9d0b4dfd60dso434456766b.1 for ; Sat, 18 Nov 2023 21:53:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700373202; x=1700978002; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=np3aPq5QRsFkvTEaTyKqkavzkLI2bkh4Im3FG/Np0n8=; b=YkJItYe9RzaFpz5lXzHBm03MwaqclGBI82Sm8FnneEv7hIK8pzq4hCMzftL+6YZXhw duFnXYBeQxAFpVAP1PIZnPpBoVUIE9XhVfu6fdvAfKq3jNZ5JlHVezNlxDyaEJ8J085i kWdtkHt4VPzlu/VsobezQ+T9VYBnq1g6susjy1d5nUay0Ua8Toe3g2o/7yaaIRgozWpo Ek9AujQqa/ZzcEVhPkYhXxKFhSNoF9VkH19NiUrmmaCWL4ittQPkGi4mCIeLlMVflnle OaNIfKa8Km0HTvTtAr/e8RtcVp7mW3iddoixXCEQRmiZzvIRn2UdldryIYFo1tqXRFxo kreA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700373202; x=1700978002; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=np3aPq5QRsFkvTEaTyKqkavzkLI2bkh4Im3FG/Np0n8=; b=wokF2l3Rog2xcXQ5mtb5X7UBHLZQO3fDBoFlybGUH5iqzMwTrVj3L//Jcb8T2R3PET PgCnmcw6SW10Xfmy6D2aZw/7j6jJ23Bz000X+b5SIPXRlDXrPM3LvtGcQPgOEqXL4uk2 Cqo7xaLVUXV6S9QqBWnzOxnrFkjdh9AXMLnEDs9Z4D+UDDGwpGT/DexI3KSvSqWuN//f wQJ470AqWvfx4emPAHikZ8EgOanK+oTYzUJI0xpc6I8PqVU4br2D2GOAPs4ZqkBgtNUr FxXJPn5SfjguqrSO7FkPqcLafmnf2EoeLpfkTvtnISTzmRRSML8aHo8AAx85ynYMA+W+ yRNA== X-Gm-Message-State: AOJu0YytICN7WmZBwlwHfXbukIv5Df/4G/z29iJ8ZHMcozpGSx1tvah4 rrvTLrUIGfBBdhhZP7eF8ZhitweYPmi6ihRCvUs= X-Google-Smtp-Source: AGHT+IEWN428lKvdsOzkR+TOIzxxXhkzD1w4Ji7KYLT+xRAiqIxVlQG1QkIfwfqCVVdXpeLjBKYgfpYaH3IiB4Hf8CQ= X-Received: by 2002:a17:907:d046:b0:9e2:b87d:9c5c with SMTP id vb6-20020a170907d04600b009e2b87d9c5cmr4100453ejc.36.1700373202347; Sat, 18 Nov 2023 21:53:22 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Kito Cheng Date: Sun, 19 Nov 2023 13:53:10 +0800 Message-ID: Subject: Re: [PATCH 07/44] RISC-V: Use `nullptr' in `riscv_expand_conditional_move' To: "Maciej W. Rozycki" Cc: gcc-patches@gcc.gnu.org, Andrew Waterman , Jim Wilson , Palmer Dabbelt Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: LGTM On Sun, Nov 19, 2023 at 1:37=E2=80=AFPM Maciej W. Rozycki wrote: > > Use `nullptr' for consistency rather than 0 to initialize `invert_ptr'. > > gcc/ > * config/riscv/riscv.cc (riscv_expand_conditional_move): Use > `nullptr' rather than 0 to initialize a pointer. > --- > gcc/config/riscv/riscv.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > gcc-riscv-expand-conditional-move-nullptr.diff > Index: gcc/gcc/config/riscv/riscv.cc > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- gcc.orig/gcc/config/riscv/riscv.cc > +++ gcc/gcc/config/riscv/riscv.cc > @@ -4024,7 +4024,7 @@ riscv_expand_conditional_move (rtx dest, > if (!equality_operator (op, VOIDmode) || op1 !=3D CONST0_RTX (mode= )) > { > enum rtx_code new_code =3D NE; > - bool *invert_ptr =3D 0; > + bool *invert_ptr =3D nullptr; > bool invert =3D false; > > if (code =3D=3D LE || code =3D=3D GE)