From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x92a.google.com (mail-ua1-x92a.google.com [IPv6:2607:f8b0:4864:20::92a]) by sourceware.org (Postfix) with ESMTPS id 44A913858D1E for ; Wed, 19 Apr 2023 01:38:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 44A913858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ua1-x92a.google.com with SMTP id o2so21168190uao.11 for ; Tue, 18 Apr 2023 18:38:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681868306; x=1684460306; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0yMe3ICrqzgS0IRC7qOBCf+xqXcFV1pyftl7kUyGIc0=; b=KEwcKHIu0CK0NlAIAYpDHHwjLt0mdxTCsPIIY7tgSBFCH3qPWAoLrPXe09gGhVhli0 qiBBdOYohHSKOVNIn3LXBkI/3W2FIzaEb6RS/7G+3+O1TFGiT9Z0I+SyeRh8xy4dxueM njuGIuBpMKIx3kiPMIPoEeYdKw5RIi3bBKLC/T4phPm6/2Zm4LO7pYc3qUM49Jt/6rS0 HKQGpISmZ5rJ4oVc2QEXlcmiftDh1xp64YOW5VlRKMSP7JjBdDrQq8Pi0ZpLeW3PeX0I PpaDdadZermaB2/5GG/hcgOC4hxZH3fXtQZ4CbayEibl5q9RmL2lUpvzl/ExtJ6cIS9x VYaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681868306; x=1684460306; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0yMe3ICrqzgS0IRC7qOBCf+xqXcFV1pyftl7kUyGIc0=; b=gnWM6h2T7dHEXd5KC8T3rSOAyYOnUk3gC9g6NlQpdU3RojC+ZWzFf0V8PTzfqNLKxk GbQiNLjGCXzEvk+VM9G7lUxgtpPei3p5HFTu1a63s7r/0pFqLrb+Vu/JzjgNVrWSl9A1 qAlgKvtuR0FzzBxCLNkBw0vFnnoqV/9Xypri4UqqryNQO+vBqqDUd3qczSQBMnOlZgSY SX86DZazp1Kf/+rnsSIAfUfEU5rB0P8QYpZLscMJrbc/GOG/4X1+XpJ+raGnjn/WfAsE QMwo5U8M8oUs7J+feDLfJZHWIewg081ygbB0T+AwpuF4UtyCIS0WHWTTIbXz6JSRiBCz eFnQ== X-Gm-Message-State: AAQBX9ecTAb8y1HaeDoMQBwgofvk/Pyxk7P2M76UOwxH7JXf73jGdEJa dFYm1vtFa+7YjDx8Oscm3FjO7Os3FxJFpTlXsa4= X-Google-Smtp-Source: AKy350YSQdzjaxip1y/wkjtrrb0gv+mRia0sry5EaGoVC9Kqhp2YPpajtKudZRfQu68MztNmAy3szgdR9CgtjTG+HD0= X-Received: by 2002:a1f:5fd4:0:b0:43b:c7bc:7203 with SMTP id t203-20020a1f5fd4000000b0043bc7bc7203mr6685804vkb.7.1681868306367; Tue, 18 Apr 2023 18:38:26 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Kito Cheng Date: Wed, 19 Apr 2023 09:38:15 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Update multilib-generator to handle V To: Palmer Dabbelt Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: OK, thanks, I know what the problem is, I tried rv64 but didn't try rv32, I have another fix in my mind, and will post another fix soon. On Wed, Apr 19, 2023 at 9:29=E2=80=AFAM Palmer Dabbelt wrote: > > On Tue, 18 Apr 2023 18:26:18 PDT (-0700), Kito Cheng wrote: > > And which -march -mabi you used will got issue? > > > > On Wed, Apr 19, 2023 at 8:51=E2=80=AFAM Palmer Dabbelt wrote: > >> > >> On Tue, 18 Apr 2023 17:47:31 PDT (-0700), Kito Cheng wrote: > >> > Do you mind shared gcc configure and the option you tried? > >> > >> Just riscv-gnu-toolchain with "--enbale-multilib --enable-linux". > >> > >> > On Wed, Apr 19, 2023 at 4:01=E2=80=AFAM Palmer Dabbelt wrote: > >> >> > >> >> On Tue, 18 Apr 2023 08:44:24 PDT (-0700), gcc-patches@gcc.gnu.org w= rote: > >> >> >> Yep, if I drop the non-canonicial strings via > >> >> >> > >> >> >> diff --git a/gcc/config/riscv/multilib-generator b/gcc/confi= g/riscv/multilib-generator > >> >> >> index 58b7198b243..a63a4d69c18 100755 > >> >> >> --- a/gcc/config/riscv/multilib-generator > >> >> >> +++ b/gcc/config/riscv/multilib-generator > >> >> >> @@ -174,7 +174,7 @@ for cmodel in cmodels: > >> >> >> ext_combs =3D expand_combination(ext) > >> >> >> alts =3D sum([[x] + [x + y for y in ext_combs] for x in= [arch] + extra], []) > >> >> >> alts =3D filter(lambda x: len(x) !=3D 0, alts) > >> >> >> - alts =3D alts + list(map(lambda a : arch_canonicalize(a= , args.misa_spec), alts)) > >> >> >> + alts =3D list(map(lambda a : arch_canonicalize(a, args.= misa_spec), alts)) > >> >> >> > >> >> >> # Drop duplicated entry. > >> >> >> alts =3D unique(alts) > >> >> >> > >> >> >> then I can't link `-march=3Drv32imafdcv`, I need > >> >> >> `-march=3Drv32imacv_zicsr_zve32f_zve32x_zve64x_zvl128b_zvl32b_zv= l64b`. That's > >> >> >> kind of a headache for users to type in. > >> >> > > >> >> > Yes, that's a headache for users, but arch string canonicalizatio= n is > >> >> > hiddened at the process, > >> >> > so the user could still just use rv32imafdcv at compile time and > >> >> > multi-lib config. > >> >> > > >> >> > And the driver and multilib-generator (with arch_canonicalize) sc= ript > >> >> > will handle those headache in the background. > >> >> > >> >> Sorry, I'm not exactly sure what you're trying to say. I just rebu= ilt > >> >> GCC with this patch (and t-linux-multilib regenerated from it), it'= s not > >> >> resolving multlibs for the short names. > > `-march=3Drv32imafdcv` is the broken one, > `-march=3Drv32imacv_zicsr_zve32f_zve32x_zve64x_zvl128b_zvl32b_zvl64b` > resolves multilibs (there's a bit more above).