public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kito Cheng <kito.cheng@gmail.com>
To: Kito Cheng <kito.cheng@sifive.com>
Cc: gcc-patches@gcc.gnu.org, jim.wilson.gcc@gmail.com, palmer@dabbelt.com
Subject: Re: [PATCH] RISC-V: Support --target-help for -mcpu/-mtune
Date: Mon, 24 Oct 2022 18:18:47 +0800	[thread overview]
Message-ID: <CA+yXCZCLtmzjYbTEykrg3=0URVgq+LhPdEuFGgDKHAsMD6ZS9g@mail.gmail.com> (raw)
In-Reply-To: <20220930020523.21483-1-kito.cheng@sifive.com>

committed.

On Fri, Sep 30, 2022 at 10:06 AM Kito Cheng <kito.cheng@sifive.com> wrote:
>
> gcc/ChangeLog:
>
>         * common/config/riscv/riscv-common.cc (riscv_tunes): New.
>         (riscv_get_valid_option_values): New.
>         (TARGET_GET_VALID_OPTION_VALUES): New.
>         * config/riscv/riscv-cores.def (RISCV_TUNE): New, define options
>         for tune here.
>         (RISCV_CORE): Fix comment.
>         * config/riscv/riscv.cc (riscv_tune_info_table): Move definition to
>         riscv-cores.def.
> ---
>  gcc/common/config/riscv/riscv-common.cc | 46 +++++++++++++++++++++++++
>  gcc/config/riscv/riscv-cores.def        | 35 ++++++++++++++++---
>  gcc/config/riscv/riscv.cc               |  9 ++---
>  3 files changed, 80 insertions(+), 10 deletions(-)
>
> diff --git a/gcc/common/config/riscv/riscv-common.cc b/gcc/common/config/riscv/riscv-common.cc
> index c39ed2e2696..697bfe435c8 100644
> --- a/gcc/common/config/riscv/riscv-common.cc
> +++ b/gcc/common/config/riscv/riscv-common.cc
> @@ -224,6 +224,14 @@ static const riscv_cpu_info riscv_cpu_tables[] =
>      {NULL, NULL, NULL}
>  };
>
> +static const char *riscv_tunes[] =
> +{
> +#define RISCV_TUNE(TUNE_NAME, PIPELINE_MODEL, TUNE_INFO) \
> +    TUNE_NAME,
> +#include "../../../config/riscv/riscv-cores.def"
> +    NULL
> +};
> +
>  static const char *riscv_supported_std_ext (void);
>
>  static riscv_subset_list *current_subset_list = NULL;
> @@ -1683,6 +1691,41 @@ riscv_compute_multilib (
>      return xstrdup (multilib_infos[best_match_multi_lib].path.c_str ());
>  }
>
> +vec<const char *>
> +riscv_get_valid_option_values (int option_code,
> +                              const char *prefix ATTRIBUTE_UNUSED)
> +{
> +  vec<const char *> v;
> +  v.create (0);
> +  opt_code opt = (opt_code) option_code;
> +
> +  switch (opt)
> +    {
> +    case OPT_mtune_:
> +      {
> +       const char **tune = &riscv_tunes[0];
> +       for (;*tune; ++tune)
> +         v.safe_push (*tune);
> +
> +       const riscv_cpu_info *cpu_info = &riscv_cpu_tables[0];
> +       for (;cpu_info->name; ++cpu_info)
> +         v.safe_push (cpu_info->name);
> +      }
> +      break;
> +    case OPT_mcpu_:
> +      {
> +       const riscv_cpu_info *cpu_info = &riscv_cpu_tables[0];
> +       for (;cpu_info->name; ++cpu_info)
> +         v.safe_push (cpu_info->name);
> +      }
> +      break;
> +    default:
> +      break;
> +    }
> +
> +  return v;
> +}
> +
>  #undef TARGET_COMPUTE_MULTILIB
>  #define TARGET_COMPUTE_MULTILIB riscv_compute_multilib
>  #endif
> @@ -1701,4 +1744,7 @@ static const struct default_options riscv_option_optimization_table[] =
>  #undef TARGET_HANDLE_OPTION
>  #define TARGET_HANDLE_OPTION riscv_handle_option
>
> +#undef  TARGET_GET_VALID_OPTION_VALUES
> +#define TARGET_GET_VALID_OPTION_VALUES riscv_get_valid_option_values
> +
>  struct gcc_targetm_common targetm_common = TARGETM_COMMON_INITIALIZER;
> diff --git a/gcc/config/riscv/riscv-cores.def b/gcc/config/riscv/riscv-cores.def
> index ecb5e213d98..b84ad999ac1 100644
> --- a/gcc/config/riscv/riscv-cores.def
> +++ b/gcc/config/riscv/riscv-cores.def
> @@ -17,19 +17,46 @@
>     along with GCC; see the file COPYING3.  If not see
>     <http://www.gnu.org/licenses/>.  */
>
> +/* This is a list of tune that implement RISC-V.
> +
> +   Before using #include to read this file, define a macro:
> +
> +      RISCV_TUNE(TUNE_NAME, PIPELINE_MODEL, TUNE_INFO)
> +
> +   The TUNE_NAME is the name of the micro-arch, represented as a string.
> +   The PIPELINE_MODEL is the pipeline model of the micro-arch, represented as a
> +   string, defined in riscv.md.
> +   The TUNE_INFO is the detail cost model for this core, represented as an
> +   identifier, reference to riscv.cc.  */
> +
> +#ifndef RISCV_TUNE
> +#define RISCV_TUNE(TUNE_NAME, PIPELINE_MODEL, TUNE_INFO)
> +#endif
> +
> +RISCV_TUNE("rocket", generic, rocket_tune_info)
> +RISCV_TUNE("sifive-3-series", generic, rocket_tune_info)
> +RISCV_TUNE("sifive-5-series", generic, rocket_tune_info)
> +RISCV_TUNE("sifive-7-series", generic, sifive_7_tune_info)
> +RISCV_TUNE("thead-c906", generic, thead_c906_tune_info)
> +RISCV_TUNE("size", generic, optimize_size_tune_info)
> +
> +#undef RISCV_TUNE
> +
>  /* This is a list of cores that implement RISC-V.
>
>     Before using #include to read this file, define a macro:
>
> -      RISCV_CORE(CORE_NAME, ARCH, MICRO_ARCH, TUNE_INFO)
> +      RISCV_CORE(CORE_NAME, ARCH, MICRO_ARCH)
>
>     The CORE_NAME is the name of the core, represented as a string.
>     The ARCH is the default arch of the core, represented as a string,
>     can be NULL if no default arch.
>     The MICRO_ARCH is the name of the core for which scheduling decisions
> -   will be made, represented as an identifier.
> -   The TUNE_INFO is the detail cost model for this core, represented as an
> -   identifier, reference to riscv-tunes.def.  */
> +   will be made, represented as an identifier.  */
> +
> +#ifndef RISCV_CORE
> +#define RISCV_CORE(CORE_NAME, ARCH, MICRO_ARCH)
> +#endif
>
>  RISCV_CORE("sifive-e20",      "rv32imc",    "rocket")
>  RISCV_CORE("sifive-e21",      "rv32imac",   "rocket")
> diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
> index 0d618315828..00b7df02e2e 100644
> --- a/gcc/config/riscv/riscv.cc
> +++ b/gcc/config/riscv/riscv.cc
> @@ -395,12 +395,9 @@ static const unsigned gpr_save_reg_order[] = {
>
>  /* A table describing all the processors GCC knows about.  */
>  static const struct riscv_tune_info riscv_tune_info_table[] = {
> -  { "rocket", generic, &rocket_tune_info },
> -  { "sifive-3-series", generic, &rocket_tune_info },
> -  { "sifive-5-series", generic, &rocket_tune_info },
> -  { "sifive-7-series", sifive_7, &sifive_7_tune_info },
> -  { "thead-c906", generic, &thead_c906_tune_info },
> -  { "size", generic, &optimize_size_tune_info },
> +#define RISCV_TUNE(TUNE_NAME, PIPELINE_MODEL, TUNE_INFO)       \
> +  { TUNE_NAME, PIPELINE_MODEL, & TUNE_INFO},
> +#include "riscv-cores.def"
>  };
>
>  void riscv_frame_info::reset(void)
> --
> 2.37.2
>

  reply	other threads:[~2022-10-24 10:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-30  2:05 Kito Cheng
2022-10-24 10:18 ` Kito Cheng [this message]
2022-10-25  5:01   ` [PATCH] riscv: fix cross compiler Martin Liška
2022-10-25  5:02     ` Martin Liška
2022-10-25  5:10       ` Kito Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+yXCZCLtmzjYbTEykrg3=0URVgq+LhPdEuFGgDKHAsMD6ZS9g@mail.gmail.com' \
    --to=kito.cheng@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jim.wilson.gcc@gmail.com \
    --cc=kito.cheng@sifive.com \
    --cc=palmer@dabbelt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).