From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com [IPv6:2607:f8b0:4864:20::934]) by sourceware.org (Postfix) with ESMTPS id 2BD563858C00 for ; Thu, 13 Apr 2023 16:00:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2BD563858C00 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ua1-x934.google.com with SMTP id f32so10741739uad.0 for ; Thu, 13 Apr 2023 09:00:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681401610; x=1683993610; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8Mn+KzpkAK9DwjB3fEzrAUIzeOwFBe2bweWNFU0eG4g=; b=D7FI0UxvXy4rprfq1ITB1e+OUbIhMWkXtB8KVXP0CdbsL19zoJyFvIs0JoANFsTgbz 8saxDekX14MSc3YZJFBvBLLpuwuyShtkMtlHoo2xtaP1ZMSKaqhsyaLCZm80eFktOgMg MUSH+HBOiKG2fMuNDjXtUzUcbHOE4jxDo5quuK0kYpjEn3x3gMhNATBvwSfk+E4fnLS2 zbPTbN6uJwPFx9sa/IwBEFlrw/kM63QVTz7LdYP95ik6tV4646tJRpP1zBe7iOZK62Jd 2wCNor1aapnrlwoWqpP+am8zqfDDp8bY48rr0Eers9mYvq8DHIb5RQWQVZGIRRU/rDLY iRrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681401610; x=1683993610; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8Mn+KzpkAK9DwjB3fEzrAUIzeOwFBe2bweWNFU0eG4g=; b=jEhbWmtc8+pYu7Bj0uvD1I4RneXoE5B84Xd6OjF/lXLu5jh5JsW8vrFFxPAEPIyZWh GPePdFpXhL8fUhcv8LNL3V8F57/GCmeAc9RJ1RQOfzZcHpF8nP/oLCy0RmYyjG27s1Kx wf4u3pB/p2npatfUKeg2wMWt2EIjtBfG/t2qfO+FGL4H0G5bBL8oshOUiUq4+PICqRFR tL5+q30VH7HvnpzVNLTM8BSnK9RMvS+BpzutVlR2x2r0FcgRH1Thz5z7AdoJ8EmBXTYz 5Fvqn9SmPrRmQCQcRDU+1z8RFdbkNVyCOPq434+l9qiyv5iSAvUjZxTHeby5EW/s12WP Y0TQ== X-Gm-Message-State: AAQBX9c2AUS68iZelpJXf2zNILFsonsgn1fW9hC7miXB7SlkuIsLpEd3 t+iF5LHlIaV6I4QpyAPYbmQ/aVnSvlnZrC+BpdA= X-Google-Smtp-Source: AKy350Y21QyiuqIPfO/0xrjwy65qEoY2A5YtlGS2hjvf9c2ynEaaraUbDe/oidbgqudsPr5Tg9j6w/grGopzxc+gy3s= X-Received: by 2002:ab0:5b07:0:b0:68b:94c5:7683 with SMTP id u7-20020ab05b07000000b0068b94c57683mr1375587uae.0.1681401609975; Thu, 13 Apr 2023 09:00:09 -0700 (PDT) MIME-Version: 1.0 References: <20230413151018.31791-1-palmer@rivosinc.com> In-Reply-To: <20230413151018.31791-1-palmer@rivosinc.com> From: Kito Cheng Date: Thu, 13 Apr 2023 23:59:58 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Set the ABI for the RVV tests To: Palmer Dabbelt Cc: gcc-patches@gcc.gnu.org Content-Type: multipart/alternative; boundary="000000000000affa3a05f939d19c" X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000affa3a05f939d19c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ok, thanks :) Palmer Dabbelt =E6=96=BC 2023=E5=B9=B44=E6=9C=8813=E6= =97=A5 =E9=80=B1=E5=9B=9B=EF=BC=8C23:12=E5=AF=AB=E9=81=93=EF=BC=9A > The RVV test harness currently sets the ISA according to the target > tuple, but doesn't also set the ABI. This just sets the ABI to match > the ISA, though we should really also be respecting the user's specific > ISA to test. > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/rvv/rvv.exp (gcc_mabi): New variable. > --- > I've still got some rv32-related multilib failures so there might be > something else going on here, but I think at least this is going to be > necessary. > --- > gcc/testsuite/gcc.target/riscv/rvv/rvv.exp | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp > b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp > index 7a9a2b6ac48..4b5509db385 100644 > --- a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp > +++ b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp > @@ -31,15 +31,17 @@ if ![info exists DEFAULT_CFLAGS] then { > } > > set gcc_march "rv64gcv_zfh" > +set gcc_mabi "lp64d" > if [istarget riscv32-*-*] then { > set gcc_march "rv32gcv_zfh" > + set gcc_mabi "ilp32d" > } > > # Initialize `dg'. > dg-init > > # Main loop. > -set CFLAGS "$DEFAULT_CFLAGS -march=3D$gcc_march -O3" > +set CFLAGS "$DEFAULT_CFLAGS -march=3D$gcc_march -mabi=3D$gcc_mabi -O3" > dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/base/*.\[cS\]]] \ > "" $CFLAGS > gcc-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/vsetvl/*.\[cS\]]] > \ > -- > 2.39.2 > > --000000000000affa3a05f939d19c--