public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kito Cheng <kito.cheng@gmail.com>
To: "Maciej W. Rozycki" <macro@embecosm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
	Andrew Waterman <andrew@sifive.com>
Subject: Re: [committed] RISC-V: Use a tab rather than space with FSFLAGS
Date: Thu, 9 Jun 2022 22:56:11 +0800	[thread overview]
Message-ID: <CA+yXCZCafBYkOSDAM4qJxg7gZkiEvHqt5G8QMjrOiNLUbtdOXQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.2206082217140.10833@tpp.orcam.me.uk>

Thanks :)


On Thu, Jun 9, 2022 at 9:35 PM Maciej W. Rozycki <macro@embecosm.com> wrote:
>
> Consistently use a tab rather than a space as the separator between the
> assembly instruction mnemonic and its operand with FSFLAGS instructions
> produced with the unordered FP comparison RTL insns.
>
>         gcc/
>         * config/riscv/riscv.md
>         (*f<quiet_pattern>_quiet<ANYF:mode><X:mode>4_default)
>         (*f<quiet_pattern>_quiet<ANYF:mode><X:mode>4_snan): Emit a tab
>         rather than space with FSFLAGS.
> ---
> Hi,
>
>  Committed as obvious.
>
>   Maciej
> ---
>  gcc/config/riscv/riscv.md |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> gcc-riscv-fcmp-tab.diff
> Index: gcc/gcc/config/riscv/riscv.md
> ===================================================================
> --- gcc.orig/gcc/config/riscv/riscv.md
> +++ gcc/gcc/config/riscv/riscv.md
> @@ -2344,7 +2344,7 @@
>           QUIET_COMPARISON))
>      (clobber (match_scratch:X 3 "=&r"))]
>    "TARGET_HARD_FLOAT && ! HONOR_SNANS (<ANYF:MODE>mode)"
> -  "frflags\t%3\n\tf<quiet_pattern>.<fmt>\t%0,%1,%2\n\tfsflags %3"
> +  "frflags\t%3\n\tf<quiet_pattern>.<fmt>\t%0,%1,%2\n\tfsflags\t%3"
>    [(set_attr "type" "fcmp")
>     (set_attr "mode" "<UNITMODE>")
>     (set (attr "length") (const_int 12))])
> @@ -2357,7 +2357,7 @@
>           QUIET_COMPARISON))
>      (clobber (match_scratch:X 3 "=&r"))]
>    "TARGET_HARD_FLOAT && HONOR_SNANS (<ANYF:MODE>mode)"
> -  "frflags\t%3\n\tf<quiet_pattern>.<fmt>\t%0,%1,%2\n\tfsflags %3\n\tfeq.<fmt>\tzero,%1,%2"
> +  "frflags\t%3\n\tf<quiet_pattern>.<fmt>\t%0,%1,%2\n\tfsflags\t%3\n\tfeq.<fmt>\tzero,%1,%2"
>    [(set_attr "type" "fcmp")
>     (set_attr "mode" "<UNITMODE>")
>     (set (attr "length") (const_int 16))])

      reply	other threads:[~2022-06-09 14:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-09 13:35 Maciej W. Rozycki
2022-06-09 14:56 ` Kito Cheng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+yXCZCafBYkOSDAM4qJxg7gZkiEvHqt5G8QMjrOiNLUbtdOXQ@mail.gmail.com \
    --to=kito.cheng@gmail.com \
    --cc=andrew@sifive.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=macro@embecosm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).