From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id 38A233885C0B for ; Wed, 26 Oct 2022 08:34:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 38A233885C0B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52c.google.com with SMTP id z97so40241384ede.8 for ; Wed, 26 Oct 2022 01:34:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=WZAMpCkw9uWaw9Enjww1F+1rfiGPwvZ8Ice1uaJ60EY=; b=NGmkBKTTqTnOIIt7vnLE0RWbdfhtxDA9Oej3x++ihX4MevfapcdbCwEg8/+DiCLHJV 4fiGTkTkEdfR2VU6HyIjKNEwGI0pWFYUL7iZD8WntKnxC0IyxlLiJMs6azfND8Hvxjxs D1GRpYvQqc2rp+KDgAlqcisuBvOzGSC+eWPc37l941LZ7wV0UBj+aTMFW1Ly2wqZyG4h 3jA9rIy963h85Dxxm50HAKfgdxakbPgz6vk4y6mlMGKVe/alBitS5Dk1oTt78TfMJURZ g03bUS683Y5NYPS61d3LW0xTTXpJMjexoe5dbaXCiq0OFY3e37Oao50HvaDUaVtVZdtm kejw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WZAMpCkw9uWaw9Enjww1F+1rfiGPwvZ8Ice1uaJ60EY=; b=wn1E8b4RreKab5Nbhw+qfVxc5bh0yqoYKFk5fAxRmmu6xsaZVamvFX390B0xwB/gzN v2+iRQGsblyT1aZEmwCHHD23fq244P7f/CSLCq5DRjjj/BDinSL167tL65a2fXjYAbKc DGDoaQNZHABTbMc7dY20naswQ5RyrQG0vZbgaye1xYDXiNbrPZdasvJ5I4CiMrWjtiEp fv7dEkIVgml/O5uWeCxA+r1kaWzjhnPEtEJtjtB/4zFowigD5QfDGRdL4zXEuYOfxZL+ 0RpJ7cCy3K9WbO3TSjTVd4sDqSCcCn0x1vrY5nLXVPq21JX+wR9PsanJgI2F1iX0myRP cbdg== X-Gm-Message-State: ACrzQf1Owr0n+gGOa02fTF2PneKqZN3NdOPo2Ao7yiThky01HnjQ6M5v ewKLKn+pzAsY3lIbHH7V0cMV1hQJNJ2EGO4nvyY= X-Google-Smtp-Source: AMsMyM6o5nINyr2KHpiZ8B3QWdXzbVZbJptCTbKYyH7p5ag55//Kpn/tD0l07MueZvf0y+l+RpM5AwT2EKlLOSDskpw= X-Received: by 2002:a05:6402:496:b0:443:a5f5:d3b with SMTP id k22-20020a056402049600b00443a5f50d3bmr40911627edv.331.1666773286744; Wed, 26 Oct 2022 01:34:46 -0700 (PDT) MIME-Version: 1.0 References: <20221024095530.16284-1-kito.cheng@sifive.com> <2be969b2-8188-2141-d8ed-b54d9af7c947@gmail.com> In-Reply-To: <2be969b2-8188-2141-d8ed-b54d9af7c947@gmail.com> From: Kito Cheng Date: Wed, 26 Oct 2022 16:34:34 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Add h extension support To: Jeff Law Cc: Kito Cheng , gcc-patches@gcc.gnu.org, jim.wilson.gcc@gmail.com, palmer@dabbelt.com, andrew@sifive.com, christoph.muellner@vrull.eu Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks for the review, committed :) On Mon, Oct 24, 2022 at 11:05 PM Jeff Law via Gcc-patches wrote: > > > On 10/24/22 03:55, Kito Cheng wrote: > > `h` was the prefix of multi-letter extension name, but it become a > > extension in later RISC-V isa spec. > > > > Fortunately we don't have any extension really defined is prefixed > > with `h`, so we can just change that. > > > > gcc/ChangeLog: > > > > * common/config/riscv/riscv-common.cc (riscv_ext_version_table): > > Add `h`. > > (riscv_supported_std_ext): Ditto. > > (multi_letter_subset_rank): Remove `h`. > > (riscv_subset_list::parse_std_ext): Handle `h` as single letter > > extension. > > (riscv_subset_list::parse): Ditto. > > > > gcc/testsuite/ChangeLog: > > > > * testsuite/gcc.target/riscv/arch-18.c: New. > > * testsuite/gcc.target/riscv/arch-5.c: Remove test for prefixed > > with `h`. > > * testsuite/gcc.target/riscv/predef-23.c: New. > > OK. > > > Jeff > >