From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa2b.google.com (mail-vk1-xa2b.google.com [IPv6:2607:f8b0:4864:20::a2b]) by sourceware.org (Postfix) with ESMTPS id 16FE9385773A for ; Fri, 21 Apr 2023 10:16:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 16FE9385773A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vk1-xa2b.google.com with SMTP id 71dfb90a1353d-446ed123287so347301e0c.1 for ; Fri, 21 Apr 2023 03:16:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682072207; x=1684664207; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KZ3tJ3Ft1dj3xI8VCjJHqKoy/JJZI07q+QfT/JVB080=; b=hxkiHlkEq0C1474D25nv8cbn5amdP6kJxxQAaVfa04OhV2r73CV5vfoB6vRsn45943 h4dQj/lKwwIrt4+QB7amJ44bMf6ojCFkP+pXqbCvywe1xRQQHsEGOTc04wD3YPpIG2Gg ZHXu4Shei9cd1KCNjUCK0juOJlJjQQjUnuK0AhJpxdd2roEfnx/vJ5nKh2KeVRZP8XRA AcbPRs0sBpkMtheYLUMxHJ9N1WsNtz+/3zd8TOzuJXfvTsBoX+h5MLckyRbD+Ef05Aof 6KV+0bEN4mU59HOGjMN4xxE686jdYvGLDrFzzlWgwM5Cj7QceoJZ7802/gC4dO8VXA7q JXYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682072207; x=1684664207; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KZ3tJ3Ft1dj3xI8VCjJHqKoy/JJZI07q+QfT/JVB080=; b=Gmi8d6ufAqMP5ruUYwK8FVcHxdnvFKws1Nop7TswkwgKfG/U2b12k6XSfnle7gYU6H A253+Scs4F18XV6nhGept5N12yKk9ZMpRXTZp7wpchWQ3BSoFq6fsRL5wKqaznYcvyU0 ub0Odw33MCSCdcxjeqA5djZBTsao3NPgzbvWyRl5t0wJ1Ssn8hQtZXeRzSQuH9vXGpR3 36win0VWqkldkcBeG/mxN5wjbXoy42gaDW7M42pD3Fb0yRtYHztew3KSkhpCVAbXnFdI Wk/MPSmZ2l4AcJ2XWo6EBd4JvW6yyPUdejh8K8z8krT7irkyFPJyr2eMgZ49HKNmpCDS 2BXA== X-Gm-Message-State: AAQBX9dx3qu2oV0yGu0KxhZOSjsF0xBXPEQSiaJdQuJ5RZI1+2RBe8jB 5pQ4OroxA13hW0mGbj2g9DA1vQ4j2r71JjKl54U= X-Google-Smtp-Source: AKy350YF3+rY9ypeZF8xIiEkiHR+6zwVeGwgRgcO+L1ecUscMz4rhLYUJQxWK8BJiM9gAtCqZT/eEkSQkDGd8wGieNg= X-Received: by 2002:a1f:4154:0:b0:440:441:37c1 with SMTP id o81-20020a1f4154000000b00440044137c1mr491046vka.8.1682072207342; Fri, 21 Apr 2023 03:16:47 -0700 (PDT) MIME-Version: 1.0 References: <20230419032117.930737-1-pan2.li@intel.com> <2908B8F5933F9196+20230419174105693011142@rivai.ai> In-Reply-To: From: Kito Cheng Date: Fri, 21 Apr 2023 18:16:36 +0800 Message-ID: Subject: Re: Re: [PATCH] RISC-V: Allow VMS{Compare} (V1, V1) shortcut optimization To: "Li, Pan2" Cc: "juzhe.zhong@rivai.ai" , gcc-patches , "Kito.cheng" , "Wang, Yanzhang" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I got a bunch of new fails including ICE for gcc testsuite, and some cases are hanging there, could you take a look? $ riscv64-unknown-linux-gnu-gcc gcc.target/riscv/rvv/vsetvl/avl_single-92.c -O2 -march=3Drv32gcv -mabi=3Dilp32 during RTL pass: expand /scratch1/kitoc/riscv-gnu-workspace/riscv-gnu-toolchain-trunk/gcc/gcc/tests= uite/gcc.target/riscv/rvv/vsetvl/avl_single-92.c: In function 'f': /scratch1/kitoc/riscv-gnu-workspace/riscv-gnu-toolchain-trunk/gcc/gcc/tests= uite/gcc.target/riscv/rvv/vsetvl/avl_single-92.c:8:13: internal compiler error: in maybe_gen_insn, at optabs.cc:8102 8 | vbool64_t mask =3D *(vbool64_t*) (in + 1000000); | ^~~~ 0x130d278 maybe_gen_insn(insn_code, unsigned int, expand_operand*) ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/optabs.cc:8102 On Fri, Apr 21, 2023 at 5:47=E2=80=AFPM Li, Pan2 via Gcc-patches wrote: > > Kindly ping for the PATCH v2. Just FYI there will be some underlying inve= stigation based on this PATCH like VMSEQ. > > Pan > > -----Original Message----- > From: Li, Pan2 > Sent: Wednesday, April 19, 2023 7:27 PM > To: 'Kito Cheng' ; 'juzhe.zhong@rivai.ai' > Cc: 'gcc-patches' ; 'Kito.cheng' ; Wang, Yanzhang > Subject: RE: Re: [PATCH] RISC-V: Allow VMS{Compare} (V1, V1) shortcut opt= imization > > Update the Patch v2 for more detail information for clarification. Please= help to review continuously. > > https://gcc.gnu.org/pipermail/gcc-patches/2023-April/616175.html > > Pan > > -----Original Message----- > From: Li, Pan2 > Sent: Wednesday, April 19, 2023 6:33 PM > To: Kito Cheng ; juzhe.zhong@rivai.ai > Cc: gcc-patches ; Kito.cheng ; Wang, Yanzhang > Subject: RE: Re: [PATCH] RISC-V: Allow VMS{Compare} (V1, V1) shortcut opt= imization > > Sure thing. > > For Changlog, I consider it was generated automatically in previous. LOL. > > Pan > > -----Original Message----- > From: Kito Cheng > Sent: Wednesday, April 19, 2023 5:46 PM > To: juzhe.zhong@rivai.ai > Cc: Li, Pan2 ; gcc-patches ; = Kito.cheng ; Wang, Yanzhang > Subject: Re: Re: [PATCH] RISC-V: Allow VMS{Compare} (V1, V1) shortcut opt= imization > > HI JuZhe: > > Thanks for explaining! > > > Hi Pan: > > I think that would be helpful if JuZhe's explaining that could be written= into the commit log. > > > > gcc/ChangeLog: > > > > * config/riscv/riscv-v.cc (emit_pred_op): > > * config/riscv/riscv-vector-builtins-bases.cc: > > * config/riscv/vector.md: > > And don't forgot write some thing in ChangeLog...:P