From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id 4A0423857833 for ; Tue, 5 Dec 2023 16:12:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4A0423857833 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4A0423857833 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::536 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701792752; cv=none; b=gJKm4rZBlsfEq1oEfGJF21fn+BKzKhRiJ2/S0KGTkZPwE9PoSKKzWKamQ9mNDBGIAqf+MiW/jY6r7K9U9vnLaAmSfQjIr12YAppIEBkXoQyNZ/IH8bXokwvwJuUqlAXQVFT1vwSR5z6Gdi1v5OnuyaV0KFvBkd1qf7l1l21VWj0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701792752; c=relaxed/simple; bh=upQjqrGo8JajNfeWdAaxGmzIEuXoyRWj8TCftO1xCsg=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=A2ufJSygl1fSXOM/3kVtsHsDt1OpL51KYRa260y+HMNpKtswsdtuxzawjZ6MT+mBAPArmfmg3W9eWyWrVF0ffgdGhfID8k66Q7XX9SaocXMowjR9rSmpZ9aGcgegqomHlSRf+oUvjcpfmf6dukR/a+eaeuo/6kA16fR3ClUEAqc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-54cd2281ccbso2739865a12.2 for ; Tue, 05 Dec 2023 08:12:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701792749; x=1702397549; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=upQjqrGo8JajNfeWdAaxGmzIEuXoyRWj8TCftO1xCsg=; b=CphRdJJptCvzNwUy8NPfK7OkVQbhIBUp9hOPPmOTtebm10Dh7D7J1AsdzoCk/QH8zk 4WGT8wLhjUmMD6WRLDOewTNKjg1W8qhhqW0FUbN4iLMLZgtV746EuC+un2vCEc9VB9Rc COVgBqWsHzSI3G3JiUJL7LPJM0UXYhcb6kF6FdpKmZguGChejCCNSTNosOcUG1BiJ0ZQ EKVPGPf817yMgAugYKW7dgKDQOA8GpIuiUTdf3Q04YC2+wLQGFNcLX8Nx63jctVgCUmV xJ2K5f9KDHyhvMiB9nY+sfzbEBGAmqSDHoVdnoOiKHQO24zVR3WACEAEOJ/t+2+8ftuC 2shg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701792749; x=1702397549; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=upQjqrGo8JajNfeWdAaxGmzIEuXoyRWj8TCftO1xCsg=; b=TKZ4WWb6ZcwRQVCDpvztARzKA757AEy9TX5a6uDtzah5xU5IDsOlPss8js9fILd3nA 3IP67sxBf2LKY3wMw9VrnnRdpWwPl+Orof54HXH4xuujOL6iIdU+oGUv1PL4gTJ2KuiF G/MgyhMclPorhK89YEAWEZ6H4WwtFVfKw/ONE98dVikPgWmMUlK5VorrOvTzJjZksSoH brvma+cptwzIJDEKVz79vtfdHb4zRtsehcATHKr95JmvExLiVdVLQ3UiVKU4GPYEHBE5 dhAd1+V9YrTJI7adEhFvdarb6C1u7TUjzdGGlAQr/AOiqN2/cIcnFR5iw9XMVQXtr1LA tCPA== X-Gm-Message-State: AOJu0Yyx+HsJs5tk2GI08FtgtYswBNTTNtTobDcGn3FX2iXuYM0D05Iu 3J0t3Gcu1iwAFHw5iSSekcsqajrGVHb1rB2F3Hh/mIYhEkVN5Q== X-Google-Smtp-Source: AGHT+IHa1UKgJN8q8RMwGqOildfcElhWl6Y/A6CrtwyBmwDtjcELMQDCYP+W8AuRemKtc2jh04U63TUsgOg0yUGG618= X-Received: by 2002:a17:906:286:b0:a1a:bb89:e2ef with SMTP id 6-20020a170906028600b00a1abb89e2efmr2534582ejf.16.1701792748769; Tue, 05 Dec 2023 08:12:28 -0800 (PST) MIME-Version: 1.0 References: <20231109115736.541131-1-mary.bennett@embecosm.com> <20231109115736.541131-2-mary.bennett@embecosm.com> In-Reply-To: <20231109115736.541131-2-mary.bennett@embecosm.com> From: Kito Cheng Date: Wed, 6 Dec 2023 00:12:17 +0800 Message-ID: Subject: Re: [PATCH 1/1] RISC-V: Add support for XCVsimd extension in CV32E40P To: Mary Bennett Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: There are few formatting issues, but I think this is generally OK for intrinsic support only, but one question before I formally say LGTM for this patch: are you interested in making it able to code gen with GNU vector and also for auto vectorization stuff? If so, I can spend more time on reviewing that and give mooooore comments.