From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <npickito@gmail.com>
Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com
 [IPv6:2a00:1450:4864:20::42a])
 by sourceware.org (Postfix) with ESMTPS id 8B41F385EC56
 for <gcc-patches@gcc.gnu.org>; Thu,  7 Jan 2021 03:35:46 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8B41F385EC56
Received: by mail-wr1-x42a.google.com with SMTP id q18so4265054wrn.1
 for <gcc-patches@gcc.gnu.org>; Wed, 06 Jan 2021 19:35:46 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=dq+oRuc1fcTL4L1NxHXF3NP/RZy4e+hpbUt+wCA5AqM=;
 b=mZnfxhQHBnrfbflojyBNUX6+Od0RYNuGtz7v/iGDD0zE0FpBus3h8xYaH9lOt9srz/
 XtxO5yrDuDHMeBrxBb4MBgWtrk+cKweqHMYKIvntQLkRVNa20obvYazuzzv1IcZrSRQ7
 EnRryMFRHUQzoHH8GAlhB5Ucgvv5fWrFoaZcOWhkNrFdkHr2qn11w+BmplJ8h+RQNq8Y
 EY9nfsIrDtu57UzitK86Vjr/tXmai2Vhtim5z3nlc1w88ZKrNxXj3AYwjb007eTdd31k
 rnRQ0lW3R3/x37mlsN4SEvrkeCVC/UyX6SBomv7uLbAE6YWYyskwDJnsgITOi8hcuBGt
 7OBA==
X-Gm-Message-State: AOAM530+O2ds63VCoOSSK/dvZKA2XWAwf9RcSevL+JJfJIC7UgCH0sqh
 ixcBygRAXTejnlPGi4zMtaJE1E2XuDcwKprMCR4=
X-Google-Smtp-Source: ABdhPJyQL6TEEEUGhbmBJCmgQHL4exkuy7sAAS5FbQ787TGS1uQtxpIvPQDGtFyrJgTjDwuHmaVYMSZN863dk1U1jr4=
X-Received: by 2002:adf:dd09:: with SMTP id a9mr6845078wrm.90.1609990545478;
 Wed, 06 Jan 2021 19:35:45 -0800 (PST)
MIME-Version: 1.0
References: <20210106173303.27988-1-philipp.tomsich@vrull.eu>
In-Reply-To: <20210106173303.27988-1-philipp.tomsich@vrull.eu>
From: Kito Cheng <kito.cheng@gmail.com>
Date: Thu, 7 Jan 2021 11:35:34 +0800
Message-ID: <CA+yXCZCq69h3m39TwW6nEjuub=Mukd3HMYpEFbHsc-4BPaVxVg@mail.gmail.com>
Subject: Re: [PATCH] RISC-V: Zihintpause: add __builtin_riscv_pause
To: Philipp Tomsich <philipp.tomsich@vrull.eu>, Jim Wilson <jimw@sifive.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Kito Cheng <kito.cheng@sifive.com>, 
 Andrew Waterman <andrew@sifive.com>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Jan 2021 03:35:48 -0000

Hi Philipp:

Could you add zihintpause to -march parser and guard that on the
pattern and builtin like zifencei[1-2]?

And could you sent a PR to
https://github.com/riscv/riscv-c-api-doc/blob/master/riscv-c-api.md to
mention __builtin_riscv_pause?

Thanks!

[1] march parser change:
https://github.com/gcc-mirror/gcc/commit/b03be74bad08c382da47e048007a78fa3fb4ef49
[2] Default version for ext.:
https://github.com/gcc-mirror/gcc/commit/4b81528241ca682025d92558ff6aeec91dafdca8


> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/riscv/builtin_pause.c
> @@ -0,0 +1,10 @@
> +/* { dg-do compile } */
> +/* { dg-options "-O2" }  */
> +
> +void test_pause()

I would suggest you change the function name in the testcase,
otherwise the scan-assembler test will always pass even if you didn't
generate "pause" instruction.


> +{
> +  __builtin_riscv_pause ();
> +}
> +
> +/* { dg-final { scan-assembler "pause" } } */
> +
> --
> 2.18.4
>