From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x92b.google.com (mail-ua1-x92b.google.com [IPv6:2607:f8b0:4864:20::92b]) by sourceware.org (Postfix) with ESMTPS id 034913858D37 for ; Fri, 28 Apr 2023 07:19:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 034913858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ua1-x92b.google.com with SMTP id a1e0cc1a2514c-772002b8694so3285318241.3 for ; Fri, 28 Apr 2023 00:19:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682666370; x=1685258370; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9aLxZ5W8YO+vGR4ByrZnpEloB0pkulkS4eEFXAC7kDI=; b=NQz0L55HMYz7hI0WLGLDmaMjVNXxRiU3zwveMrrCigD00LKq/2sO0WyZhT7HTdroQl w8slInSQ6GSmUYzlPvJjC5UO+CU4AGdxnfA/anfmMrNGP3QoJksyO1Q3hE3fTQL1ux2J 4hKULZpY2V/Nh4uz6K9EiQZv2Gv6UoDnsP3KdMloDUY5febxUjw52wJD3UPxmoSPficv YqcjJ0I/dFI3E+gv8n+0zyzoewimze94Ffe04E9oEV0n274aj78HMibirl4ORZmTa+ta vgh9MabMOzDY7yptTrk+up0vvGXDQUqBSDmIiMB62GoFkEz+nADN/i6woE2hkiLEqBNK JAcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682666370; x=1685258370; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9aLxZ5W8YO+vGR4ByrZnpEloB0pkulkS4eEFXAC7kDI=; b=T0uhULgpexNFPjp64SI2iQzfspllmpTaRNuLxDqMmtJ5kmpLiMfzf/sHIHuZ9XjMth fAJGH7bOaP0lGKwtzJkKag0vyw176x7V0wduZZIhATSzDM9VWX+pJrFv6+z2YzGx+1CW q14jMBys8vXbdvr4oWFBlnG84T9NuaIzkxDL0zSctCTRYN+T+PAKP1wi6tpxUmDxiWNV 1KoOhAx7+xu6g0lb4ioIn5N9lRv79ccviW6EvrMvMC5zrZQHHBzB6ftVwNBYXCgt+5tu P3keOxuahTEW34XnIvu8GYNFhYp7dvxeINDDudroI6SNFn6P6opNMaOAGImz/CVBc001 qVBg== X-Gm-Message-State: AC+VfDzf14fK5qasuAv6stkj75ZDAQpFuqYMPIBbnVwgnGApr+aVoILE qHrD0RwWn0unq8FTs3yRhl+0uv2acvl0Um+dqqQ= X-Google-Smtp-Source: ACHHUZ5lYpSvEux4euqjje23Xsb2fImJzIPS1bQoT5PMF/rWXsGDOIl+MAj4Xz/DdIWpJf8OdY0FOmKiU8PHGMtaONw= X-Received: by 2002:a1f:3fd4:0:b0:412:17fe:7bc1 with SMTP id m203-20020a1f3fd4000000b0041217fe7bc1mr1693529vka.0.1682666370088; Fri, 28 Apr 2023 00:19:30 -0700 (PDT) MIME-Version: 1.0 References: <20230428061210.2988035-1-christoph.muellner@vrull.eu> <20230428061210.2988035-5-christoph.muellner@vrull.eu> In-Reply-To: <20230428061210.2988035-5-christoph.muellner@vrull.eu> From: Kito Cheng Date: Fri, 28 Apr 2023 15:19:19 +0800 Message-ID: Subject: Re: [PATCH 04/11] riscv: thead: Adjust constraints of th_addsl INSN To: Christoph Muellner Cc: gcc-patches@gcc.gnu.org, Kito Cheng , Jim Wilson , Palmer Dabbelt , Andrew Waterman , Philipp Tomsich , Cooper Qu , Lifang Xia , Yunhai Shang , Zhiwei Liu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: LGTM, personally I also like this way too. On Fri, Apr 28, 2023 at 2:13=E2=80=AFPM Christoph Muellner wrote: > > From: Christoph M=C3=BCllner > > A recent change adjusted the constraints of ZBA's shNadd INSN. > Let's mirror this change here as well. > > gcc/ChangeLog: > > * config/riscv/thead.md: Adjust constraints of th_addsl. > > Signed-off-by: Christoph M=C3=BCllner > --- > gcc/config/riscv/thead.md | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/gcc/config/riscv/thead.md b/gcc/config/riscv/thead.md > index 6a06d0dfcf2..aa933960a98 100644 > --- a/gcc/config/riscv/thead.md > +++ b/gcc/config/riscv/thead.md > @@ -22,10 +22,9 @@ > (define_insn "*th_addsl4" > [(set (match_operand:X 0 "register_operand" "=3Dr") > (plus:X (ashift:X (match_operand:X 1 "register_operand" "r") > - (match_operand 2 "const_int_operand" "n")) > + (match_operand:QI 2 "imm123_operand" "Ds3")) > (match_operand:X 3 "register_operand" "r")))] > - "TARGET_XTHEADBA > - && (INTVAL (operands[2]) >=3D 0) && (INTVAL (operands[2]) <=3D 3)" > + "TARGET_XTHEADBA" > "th.addsl\t%0,%3,%1,%2" > [(set_attr "type" "bitmanip") > (set_attr "mode" "")]) > -- > 2.40.1 >