From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa2b.google.com (mail-vk1-xa2b.google.com [IPv6:2607:f8b0:4864:20::a2b]) by sourceware.org (Postfix) with ESMTPS id 6316C3858D33 for ; Thu, 16 Feb 2023 13:28:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6316C3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vk1-xa2b.google.com with SMTP id f17so1193584vkm.2 for ; Thu, 16 Feb 2023 05:28:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1676554125; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UFqmf0tNM0QccJtYGb+rDb0EB5qp17pwEVfESAsr7eQ=; b=QWpW8oUR9kYqewm2244bsiiYM06Q9FUHaPoVVJT2/hmri7nKyajPtb5sx7FP7IqiKe 8Fmrw4TmsLAwxglRd6CeZ0xhKG31HGzVDqoND1brKkbft8qgTNxTV47x76/wJBVdHp7w +c3pVqlUKSXkTz+YLJvaQV7BoRRR8ADnLeYmdQ7DtsSIasoJhX0H7FWJtrEByoXmkkCS G6U8YAJ76H17DgJEgPhyUc3OALrMCGLuxsrv9q4x3rqMWyUvd1460W3q2t5aDxrHak21 J4t4PrkqE247ncOQcfg/VbfujXq3HwyVLtGsNcvhz4teiZW4tt+vHjxJZzCtRCBm7JUV p+WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676554125; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UFqmf0tNM0QccJtYGb+rDb0EB5qp17pwEVfESAsr7eQ=; b=lj4cuZK6yYAcKmX01AkaGUGalGnunqvzCTLHDC6pVf/cP4EeAzAQxQFQqIxKJW4B6R bqcUS/6tIGf22IySVp/1JfTYzmEO5qAhyBykMGMypDMzOVNDKB/lMF73WNsxZSLkrqZJ gLscMhJsvoPXYDhQWfkeV41+WTw3I+uzb0C7fJEcsFleik6QpbI2qazY4zhGkc/qy0Tu RHph2by9P5qGgYbpoQ/eLvUqv2k1CLXf12pHqMZ/SgKDYaB0eJnUOJQQrmcuZMo1MXb2 8ItEvXHf059LzImhUF6ToBYIvQzqgNwibo3nVgBGyqnc9BHIBW98JHTOwyAI7m9lh+4w nVpA== X-Gm-Message-State: AO0yUKWlFEByuYj7AwLOnYIVCsORpXcjk2Yg/nibmuqrLISHWfmHpJcG LWBk0fH/k6MM1EWFdaogV2sXV9Be7D55GeQ+Vvk= X-Google-Smtp-Source: AK7set/5wOTaPfa2a/qvYPq6so5UdjKouAIynhpKS+1fP0g6BO0JepcUun86fQeOwxINw/DQr2ss1IPwOcwlCCGvWxY= X-Received: by 2002:a1f:2f45:0:b0:401:b0cc:f96f with SMTP id v66-20020a1f2f45000000b00401b0ccf96fmr911557vkv.11.1676554125535; Thu, 16 Feb 2023 05:28:45 -0800 (PST) MIME-Version: 1.0 References: <20230216075005.2600-1-shihua@iscas.ac.cn> In-Reply-To: <20230216075005.2600-1-shihua@iscas.ac.cn> From: Kito Cheng Date: Thu, 16 Feb 2023 21:28:34 +0800 Message-ID: Subject: Re: [PATCH V2 0/5] RISC-V: Implement Scalar Cryptography Extension To: Liao Shihua Cc: gcc-patches@gcc.gnu.org, jiawei@iscas.ac.cn, mjos@iki.fi, palmer@dabbelt.com, shiyulong@iscas.ac.cn, ben.marshall@pqshield.com, christoph.muellner@vrull.eu Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Shihua: Thanks for your patches! This patch set is generally in good shape, but I would prefer to remove riscv_scalar_crypto.h at this moment since it's NOT standardized yet. Do you mind sending a new version of this patch set which does not include that and also update the testcases? On Thu, Feb 16, 2023 at 3:52 PM Liao Shihua wrote: > > This series adds basic support for the Scalar Cryptography extensions: > * Zbkb > * Zbkc > * Zbkx > * Zknd > * Zkne > * Zknh > * Zksed > * Zksh > > The implementation follows the version Scalar Cryptography v1.0.0 of the specification, > and the intrinsic of Scalar Cryptography extensions follows riscv-c-api > which can be found here: > https://github.com/riscv/riscv-crypto/releases/tag/v1.0.0-scalar > https://github.com/riscv-non-isa/riscv-c-api-doc/pull/31 > > It works by Wu Siyu and Liao Shihua . > > Liao Shihua (5): > Add prototypes for RISC-V Crypto built-in functions > Implement ZBKB, ZBKC and ZBKX extensions > Implement ZKND and ZKNE extensions > Implement ZKNH extensions > Implement ZKSH and ZKSED extensions > > gcc/config.gcc | 2 +- > gcc/config/riscv/bitmanip.md | 20 +- > gcc/config/riscv/constraints.md | 8 + > gcc/config/riscv/crypto.md | 435 ++++++++++++++++++ > gcc/config/riscv/riscv-builtins.cc | 26 ++ > gcc/config/riscv/riscv-crypto.def | 94 ++++ > gcc/config/riscv/riscv-ftypes.def | 10 + > gcc/config/riscv/riscv.md | 4 +- > gcc/config/riscv/riscv_scalar_crypto.h | 218 +++++++++ > gcc/testsuite/gcc.target/riscv/zbkb32.c | 36 ++ > gcc/testsuite/gcc.target/riscv/zbkb64.c | 28 ++ > gcc/testsuite/gcc.target/riscv/zbkc32.c | 17 + > gcc/testsuite/gcc.target/riscv/zbkc64.c | 17 + > gcc/testsuite/gcc.target/riscv/zbkx32.c | 18 + > gcc/testsuite/gcc.target/riscv/zbkx64.c | 18 + > gcc/testsuite/gcc.target/riscv/zknd32.c | 18 + > gcc/testsuite/gcc.target/riscv/zknd64.c | 36 ++ > gcc/testsuite/gcc.target/riscv/zkne32.c | 18 + > gcc/testsuite/gcc.target/riscv/zkne64.c | 30 ++ > gcc/testsuite/gcc.target/riscv/zknh-sha256.c | 29 ++ > .../gcc.target/riscv/zknh-sha512-32.c | 43 ++ > .../gcc.target/riscv/zknh-sha512-64.c | 31 ++ > gcc/testsuite/gcc.target/riscv/zksed.c | 20 + > gcc/testsuite/gcc.target/riscv/zksh.c | 19 + > 24 files changed, 1183 insertions(+), 12 deletions(-) > create mode 100644 gcc/config/riscv/crypto.md > create mode 100644 gcc/config/riscv/riscv-crypto.def > create mode 100644 gcc/config/riscv/riscv_scalar_crypto.h > create mode 100644 gcc/testsuite/gcc.target/riscv/zbkb32.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zbkb64.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zbkc32.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zbkc64.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zbkx32.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zbkx64.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zknd32.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zknd64.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zkne32.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zkne64.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zknh-sha256.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zknh-sha512-32.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zknh-sha512-64.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zksed.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zksh.c > > -- > 2.38.1.windows.1 >