From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa33.google.com (mail-vk1-xa33.google.com [IPv6:2607:f8b0:4864:20::a33]) by sourceware.org (Postfix) with ESMTPS id 6EF0F385B506 for ; Fri, 27 Jan 2023 09:36:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6EF0F385B506 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vk1-xa33.google.com with SMTP id az23so2175412vkb.8 for ; Fri, 27 Jan 2023 01:36:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gu2xAL1qLDnSuvtgIphIFEgPNMqIklfUC9sro4mZ+hY=; b=hQkvpgZKrrAw8zo3LPdqbWmzHMvPhNJtLw6scJs6yONhA83lc8ZgnHKZ+vb5qEdXn8 +lypSnyaPxmXaiWDPRhXmFhI971Dahu+sNXiJFUP6BVY7mENLHz8hPhu4/7nwmQiUMwi ShVpMOZVY602BXUKSsVPyugpFADPxouAM+ARH0stC6Zz/DiJcjA2k+3+YuFVv0lIzXyI 7N8vr20Uoye7CavxssInLdvGJiZHPirgqEVQu3VDCy8d1rd9o/isl1JILy6Wbh+lZvER FQWA7bTpQ/7Ci2EDQj85l461JNtvImsE7OKThG1TSb+TEGCslewtFI2hXjav51+qgbPT DXkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gu2xAL1qLDnSuvtgIphIFEgPNMqIklfUC9sro4mZ+hY=; b=1ddFzrQSMalsWdaFEI+QjxI28xcgOzaSaCzgDZjn1U5oclZaLBwfiluveIQRidLrYM BlzZ2W8BJiDN2XdyajETfQtuQVtNu+bOrp+5VfbdbheSScWX/afT73VXMTjkkLEcJ/TC /DnPi8RRIPU1j1LvUpdZ3MbAj6j0DZRBHns9SBopHv7RPy9B5nDU2IZkSX/3J9o8wyN9 ZEUhMUomL229bopd8pr26Sykg+o31aRBLOmVjtawzwJEBm2fPBF5Oqo+KY9Dq5VdA13J Yj7rJGTC5mANGXRa/RySet6njMX2KPjd0P3n/5Em170ABIV7mjLajFEEKbg4g06f/J0A Ci4g== X-Gm-Message-State: AFqh2ko5FOmmiqIy5hTtnWTGXEMc3rpTojeSGpS2Wnv7jTJvFb4jaBpf PyGOd0aYiW4ALa3GLiMaSC5Yh0R5kNxjGcIieFg= X-Google-Smtp-Source: AMrXdXsH9PYJzXM/0sYFrJ6CPfUVqAN4MRnM57KRJScmBvtSwV4Sj3kMj7o6Hd3c7Z7qoKQfT5TXAw6COP7T912/tTE= X-Received: by 2002:ac5:cda4:0:b0:3da:e97f:4dd7 with SMTP id l4-20020ac5cda4000000b003dae97f4dd7mr4857744vka.36.1674812201623; Fri, 27 Jan 2023 01:36:41 -0800 (PST) MIME-Version: 1.0 References: <20230118025014.65261-1-juzhe.zhong@rivai.ai> <7bd8c0ff-754f-5224-795e-ac101bbf1e03@gmail.com> In-Reply-To: <7bd8c0ff-754f-5224-795e-ac101bbf1e03@gmail.com> From: Kito Cheng Date: Fri, 27 Jan 2023 17:36:30 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Change VSETVL PASS always call split_all_insns To: Jeff Law Cc: juzhe.zhong@rivai.ai, gcc-patches@gcc.gnu.org, palmer@dabbelt.com Content-Type: multipart/alternative; boundary="00000000000057e4c605f33b9ad7" X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000057e4c605f33b9ad7 Content-Type: text/plain; charset="UTF-8" committed, thanks On Mon, Jan 23, 2023 at 3:39 AM Jeff Law via Gcc-patches < gcc-patches@gcc.gnu.org> wrote: > > > On 1/17/23 19:50, juzhe.zhong@rivai.ai wrote: > > From: Ju-Zhe Zhong > > > > Since LCM will destroy CFG, we are going to reorder the location of > VSETVL PASS > > at least before bbro (block-reorder PASS) which is before split3 PASS. > We need > > to call it in VSETVL PASS to get final RVV instructions patterns. > Just for the record. LCM does not destroy the CFG, it just splits > critical edges. > > > > > gcc/ChangeLog: > > > > * config/riscv/riscv-vsetvl.cc (pass_vsetvl::execute): Always > call split_all_insns. > OK. > jeff > --00000000000057e4c605f33b9ad7--