From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <npickito@gmail.com>
Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633])
	by sourceware.org (Postfix) with ESMTPS id BBDE03858C56
	for <gcc-patches@gcc.gnu.org>; Wed, 31 Aug 2022 15:35:18 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BBDE03858C56
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-ej1-x633.google.com with SMTP id nc14so24238617ejc.4
        for <gcc-patches@gcc.gnu.org>; Wed, 31 Aug 2022 08:35:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date;
        bh=sfI7e1sNM0I8lL95fT1vHYOAhaQul9qzk2FTACXoOek=;
        b=LHYk3WOg2Su48Cj4Yk4iqjjg3vieVyy4TIVQlzdCTF2GjChoA0C6awIGod5DUjynqI
         027MYHGFBwwP2jvNMP6F4pdYKnIrd7v9NzmCvksW8dixrkNRAZfzff/XiM4n71l2fNr2
         1R2S7MrveMUsWsd0uNitXQL03n2wwHic/pDlkn4LCWdSPWehqDlxbyjuHpzWaxjy2/sv
         3fWPTSb5uRdbhw7U2N6/B90NHfoZT9zUA7GSLbrudrjOy8FTCZnSqRnqXtMoO/kgOCe+
         ybLf5nQ2+fHAuliEYDdb1B0IUARA9rA5DIrHzG9jy8IcSxwAR+MfuZRwmqtH8eVhjoJv
         mqpw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date;
        bh=sfI7e1sNM0I8lL95fT1vHYOAhaQul9qzk2FTACXoOek=;
        b=yO/iLp4iBRmyZj0PhyqhJrLjPFBW8juuk0uwAptAonWMsqlwzX/wehLrJLJFxVGyZv
         dDEC1oN1K+5LjKDwSMYAyC/k2NTKXXRY6XstvyZwPjuZfuLqJgz822kiIbJZckic7MnA
         orxxDncw6vvTYn5XoyXFk5OOu+Cmf0lu73z5dQDq8Pkfpx3XxegtsiV7UXqACZ9GT1hQ
         1mPWZHcZ0Q6CUOHw1O+iOSHlNmEldfZvrEoHGMpt6tGXpJLNgn/QiyATJl5ieOn8WCYo
         ZFHxH/Di5A3d3gJaTg+FamDfGvvtVq0C30M57E+vn0MLKRHHniBWtavNlhlcS96n6wiM
         qrFQ==
X-Gm-Message-State: ACgBeo0EvJKhOxX/yQWYogMxpkoKJFV57uysiBZq70Ynd/4meDACKvIx
	nv3GtEZf08ZEO2CODhFnNe/V3CQPcgqwzusOjnM=
X-Google-Smtp-Source: AA6agR6i/jD+ylxRfBV9zWKHDD3c9rNnL+7uNn/n7HKAjhZDrKeFqHXuwFRp5tX1ZgdaFW/1Isvd+L8TiVonJkOb+Fw=
X-Received: by 2002:a17:907:744:b0:741:36b9:d2cc with SMTP id
 xc4-20020a170907074400b0074136b9d2ccmr15690903ejb.613.1661960117237; Wed, 31
 Aug 2022 08:35:17 -0700 (PDT)
MIME-Version: 1.0
References: <20220830174830.224541-2-vineetg@rivosinc.com> <mhng-dfd1e731-e5d1-4f0b-a345-a4b155e38b33@palmer-mbp2014>
In-Reply-To: <mhng-dfd1e731-e5d1-4f0b-a345-a4b155e38b33@palmer-mbp2014>
From: Kito Cheng <kito.cheng@gmail.com>
Date: Wed, 31 Aug 2022 23:35:05 +0800
Message-ID: <CA+yXCZCz2cjq5cx6R5MMR7Y0CCVSk_TDqbO4io5DjSntYTAeLg@mail.gmail.com>
Subject: Re: [PATCH 1/2] RISC-V: remove deprecate pic code model macro
To: Palmer Dabbelt <palmer@rivosinc.com>
Cc: Vineet Gupta <vineetg@rivosinc.com>, collison@rivosinc.com, gnu-toolchain@rivosinc.com, 
	Philipp Tomsich <philipp.tomsich@vrull.eu>, GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

Could you also clean up all __riscv_cmodel_pic checking in
gcc/testsuite/gcc.target/riscv/predef-*.c?

On Wed, Aug 31, 2022 at 10:58 PM Palmer Dabbelt <palmer@rivosinc.com> wrote:
>
> On Tue, 30 Aug 2022 10:48:29 PDT (-0700), Vineet Gupta wrote:
> > Came across this deprecated symbol when looking around for
> > -mexplicit-relocs handling in code
> >
> > Signed-off-by: Vineet Gupta <vineetg@rivosinc.com>
> > ---
> >  gcc/config/riscv/riscv-c.cc | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/gcc/config/riscv/riscv-c.cc b/gcc/config/riscv/riscv-c.cc
> > index eb7ef09297e9..bba72cf77a82 100644
> > --- a/gcc/config/riscv/riscv-c.cc
> > +++ b/gcc/config/riscv/riscv-c.cc
> > @@ -93,9 +93,6 @@ riscv_cpu_cpp_builtins (cpp_reader *pfile)
> >        break;
> >
> >      case CM_PIC:
> > -      /* __riscv_cmodel_pic is deprecated, and will removed in next GCC release.
> > -      see https://github.com/riscv/riscv-c-api-doc/pull/11  */
> > -      builtin_define ("__riscv_cmodel_pic");
> >        /* FALLTHROUGH. */
> >
> >      case CM_MEDANY:
>
> It looks like some of the tests
> (gcc/testsuite/gcc.target/riscv/predef-3.c, for example) are checking
> for __riscv_cmodel_pic.  From looking at them I'd expect them to fail,
> but even if they're not we should clean them up.