From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id 291273858434 for ; Thu, 24 Feb 2022 09:55:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 291273858434 Received: by mail-ej1-x630.google.com with SMTP id p15so3119980ejc.7 for ; Thu, 24 Feb 2022 01:55:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Jv10RTolqj2N+ZV/BVIPS5HJ14rqTt4FD98/kZRMQaU=; b=g6dQSBPU5d53Sata5XLnLcBePPkW5mFKVtBGV0+iR1qYcl3eKzowQ4sGoLueCSFrVl 4Wpy6RRm1ieYBE+c/00+gpsj0WUwUCksPjjMFq9V30iMzbW+38iEZrP7trAmx5Cz8cug KNDazmE2SZxykx9z5+q1Fw23MmfzE9i5NnfWhnOWzgcSC/9am0Wxc9sY/1YtbEgZ59HQ 36mXJ3+tBMlwK4isXIesAyI7sJxhouRViaIpxUOmplgDiSiWj3UzT3wGl6M2f+WO+LTk 4EVHpBWGGsgbRPJ8bTTtca7pqVZc6WwiPOuh0890Pccb2xdYx/vWladsrY5Yi5+z/se3 MOtQ== X-Gm-Message-State: AOAM530ZPfSZk59g3gZTjp0zEjSFJ2oQ3YQV+K5k86mLMWU0m4aeYtZQ JvxRPAfWrBNTdbrEdES95ACv6uRtSYQt/ydILlY= X-Google-Smtp-Source: ABdhPJwygvGm9JrOiXfGEVYr06eLAuXfrvQjV8iQGgQAnRQgmSyTr9eeEcXmcVRw+yViC52gavLP0DpNKK4uRhAHVR4= X-Received: by 2002:a17:906:3152:b0:6cf:d100:a8b2 with SMTP id e18-20020a170906315200b006cfd100a8b2mr1581940eje.529.1645696529844; Thu, 24 Feb 2022 01:55:29 -0800 (PST) MIME-Version: 1.0 References: <20220223094418.3518-1-shihua@iscas.ac.cn> <20220223094418.3518-6-shihua@iscas.ac.cn> In-Reply-To: <20220223094418.3518-6-shihua@iscas.ac.cn> From: Kito Cheng Date: Thu, 24 Feb 2022 17:55:18 +0800 Message-ID: Subject: Re: [PATCH 5/5 V1] RISC-V:Implement architecture extension test macros for Crypto extension To: shihua@iscas.ac.cn Cc: GCC Patches , ben.marshall@pqshield.com, Christoph Muellner , Andrew Waterman , jiawei , mjos@iki.fi, Kito Cheng Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Feb 2022 09:55:32 -0000 I would suggest implementing that in riscv_subset_list::parse so that it also affect the ELF attribute emission. On Wed, Feb 23, 2022 at 5:44 PM wrote: > > From: LiaoShihua > > gcc/ChangeLog: > > * config/riscv/riscv-c.cc (riscv_cpu_cpp_builtins):Add __riscv_zks, __riscv_zk, __riscv_zkn > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/predef-17.c: New test. > > --- > gcc/config/riscv/riscv-c.cc | 9 ++++ > gcc/testsuite/gcc.target/riscv/predef-17.c | 59 ++++++++++++++++++++++ > 2 files changed, 68 insertions(+) > create mode 100644 gcc/testsuite/gcc.target/riscv/predef-17.c > > diff --git a/gcc/config/riscv/riscv-c.cc b/gcc/config/riscv/riscv-c.cc > index 73c62f41274..d6c153e8d7c 100644 > --- a/gcc/config/riscv/riscv-c.cc > +++ b/gcc/config/riscv/riscv-c.cc > @@ -63,6 +63,15 @@ riscv_cpu_cpp_builtins (cpp_reader *pfile) > builtin_define ("__riscv_fdiv"); > builtin_define ("__riscv_fsqrt"); > } > + > + if (TARGET_ZBKB && TARGET_ZBKC && TARGET_ZBKX && TARGET_ZKNE && TARGET_ZKND && TARGET_ZKNH) > + { > + builtin_define ("__riscv_zk"); > + builtin_define ("__riscv_zkn"); > + } > + > + if (TARGET_ZBKB && TARGET_ZBKC && TARGET_ZBKX && TARGET_ZKSED && TARGET_ZKSH) > + builtin_define ("__riscv_zks"); > > switch (riscv_abi) > { > diff --git a/gcc/testsuite/gcc.target/riscv/predef-17.c b/gcc/testsuite/gcc.target/riscv/predef-17.c > new file mode 100644 > index 00000000000..4366dee1016 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/riscv/predef-17.c > @@ -0,0 +1,59 @@ > +/* { dg-do compile } */ > +/* { dg-options "-march=rv64i_zbkb_zbkc_zbkx_zknd_zkne_zknh_zksed_zksh -mabi=lp64 -mcmodel=medlow -misa-spec=2.2" } */ > + > +int main () { > + > +#ifndef __riscv_arch_test > +#error "__riscv_arch_test" > +#endif > + > +#if __riscv_xlen != 64 > +#error "__riscv_xlen" > +#endif > + > +#if !defined(__riscv_i) > +#error "__riscv_i" > +#endif > + > +#if !defined(__riscv_zk) > +#error "__riscv_zk" > +#endif > + > +#if !defined(__riscv_zkn) > +#error "__riscv_zkn" > +#endif > + > +#if !defined(__riscv_zks) > +#error "__riscv_zks" > +#endif > + > +#if !defined(__riscv_zbkb) > +#error "__riscv_zbkb" > +#endif > + > +#if !defined(__riscv_zbkc) > +#error "__riscv_zbkc" > +#endif > + > +#if !defined(__riscv_zbkx) > +#error "__riscv_zbkx" > +#endif > + > +#if !defined(__riscv_zknd) > +#error "__riscv_zknd" > +#endif > + > +#if !defined(__riscv_zkne) > +#error "__riscv_zkne" > +#endif > + > +#if !defined(__riscv_zknh) > +#error "__riscv_zknh" > +#endif > + > +#if !defined(__riscv_zksh) > +#error "__riscv_zksh" > +#endif > + > + return 0; > +} > \ No newline at end of file > -- > 2.31.1.windows.1 >