From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 3D5163829BC3 for ; Sun, 19 Nov 2023 06:50:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3D5163829BC3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3D5163829BC3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700376657; cv=none; b=qzcyegdq4jl8jN5ZZLPQrfWUIQ/lY6ytA3/KtAF6kkj2w2AiUYx84WdtejQ6W3dH+leXvG4OJzDrKYE38db5M1YpcpHeGJWs6tm/NlGSH9vOmNekLulsT2wk+XitH9XvD/OSPzAZh5Ti4GxKmgHvFqxdI+g9UKbZGrM3Ah6LXmE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700376657; c=relaxed/simple; bh=tdPJKmsa7knJ1QKaVMiZldJhBaxbCuRT5mYGBNJ7W0M=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=AyiiU5kR18R16f8tRpSrOIVd1MTAS0cL6KMqhQ4THoMcvlEr9cdzhVBWUcESj8XlHHmAo41umIK9f9uNFUzxHVaaUQLnw0TyOvu2JydUJPYSApiSQGEDGRYBAPbxbVsXui/Sa8R3MqMxqfjPgYihjzO1zQwcK0q1ZOGw0pG72kM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-9de7a43bd1aso449160866b.3 for ; Sat, 18 Nov 2023 22:50:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700376655; x=1700981455; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xA3g8InCjSmWRyFcczVtTBVgTlSRvmRhr4rf/6Iho5I=; b=jXWOZKVmT2l/J/JrSz9YVffANYEMMw+g+AkF8IgMIjnYMfqd/yZfpiSlwBQUaCIQoc tHFZEVtKGt0FgBPbquRHQjpsRegG04kZt3Hism8m05VvVd0RBFe2lPh8P3OeGOh2WaPT qzcv+N2dCFPcAz1CzRMiaB5qId3pGs9NQp7I5fpuxiYTpFzdqBatrOpF4JmExyPDQfpN +58C1lWIDYcUgn1nvlP8HNbHgJuwpDB4CGXXRYcrKqGIuuzrnjBsiH6VTu6Vurypph71 r8JQ2ja+vIs8y6QkrDqQ9Fh+vj2XkF5cBmQ+dJMTYeRwpbMTUsrtYo7Ck7SkW/9xNH88 /vGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700376655; x=1700981455; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xA3g8InCjSmWRyFcczVtTBVgTlSRvmRhr4rf/6Iho5I=; b=idv4d1ne2F1RiyQEhMOKj6tvZ8RKpe6l46HtVU6Hqzl87GAgUL8J8o9xE8YKHjZ0u5 MubsCDaFBdtQ8lRHxDF7WTEDnGe/VAnAcBfHfTRVM5dThb56w4Asr5hhRTzEcygJYW0l F+b+HtlYqDtMuPL9NPA4RMS0LZiLC3HHtrKmInnvTxAq4h14tJuvDRBw0NYiFIs1+Sal fdX8fOUXSGTWDCS2MwGtE1e9NPoCs0eezMO05rtXbCvxX/laW/U8JIbLZwX1IYLu1eyV hgH0zb6q97OZH1u4+FlaHavIOPJ7y3eBVSEB7ze90y7znKxIM8zrydHFKfZ2M7Rk2iKP Z5RQ== X-Gm-Message-State: AOJu0Yz0x9ACpI5GF9460bhRO3/afdZCPRuU0lEzDOd+DD7Z9aQm5irB hpOj6ED7WQ1jc9LGBpiytJEIoEI0KpeqIquRbMY4T9g/1P0= X-Google-Smtp-Source: AGHT+IGec+9wxD3APw3iZKr8R/aZCwaagG4M9sxKasLAZx+FS29lzhlH8rQae1ca7RoqQw9kGm+yvIUkORS6m++rbCQ= X-Received: by 2002:a17:906:906:b0:9be:562:a44a with SMTP id i6-20020a170906090600b009be0562a44amr2678612ejd.23.1700376654658; Sat, 18 Nov 2023 22:50:54 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Kito Cheng Date: Sun, 19 Nov 2023 14:50:42 +0800 Message-ID: Subject: Re: [PATCH 14/44] RISC-V: Also invert the cond-move condition for GEU and LEU To: "Maciej W. Rozycki" Cc: gcc-patches@gcc.gnu.org, Andrew Waterman , Jim Wilson , Palmer Dabbelt Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: LGTM On Sun, Nov 19, 2023 at 1:39=E2=80=AFPM Maciej W. Rozycki wrote: > > Update `riscv_expand_conditional_move' and handle the missing GEU and > LEU operators there, avoiding an extraneous conditional set operation, > such as with this output: > > sgtu a0,a0,a1 > seqz a1,a0 > czero.eqz a3,a3,a1 > czero.nez a1,a2,a1 > or a0,a1,a3 > > produced when optimizing for Zicond targets from: > > int > movsigtu (int w, int x, int y, int z) > { > return w > x ? y : z; > } > > These operators can be inverted producing optimal code such as this: > > sgtu a1,a0,a1 > czero.nez a3,a3,a1 > czero.eqz a1,a2,a1 > or a0,a1,a3 > > which this change causes to happen. > > gcc/ > * config/riscv/riscv.cc (riscv_expand_conditional_move): Also > invert the condition for GEU and LEU. > --- > gcc/config/riscv/riscv.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > gcc-riscv-expand-conditional-move-geu-leu.diff > Index: gcc/gcc/config/riscv/riscv.cc > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- gcc.orig/gcc/config/riscv/riscv.cc > +++ gcc/gcc/config/riscv/riscv.cc > @@ -4142,7 +4142,7 @@ riscv_expand_conditional_move (rtx dest, > /* If riscv_expand_int_scc inverts the condition, then it will > flip the value of INVERT. We need to know where so that > we can adjust it for our needs. */ > - if (code =3D=3D LE || code =3D=3D GE) > + if (code =3D=3D LE || code =3D=3D LEU || code =3D=3D GE || code= =3D=3D GEU) > invert_ptr =3D &invert; > > /* Emit an scc like instruction into a temporary