From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe2b.google.com (mail-vs1-xe2b.google.com [IPv6:2607:f8b0:4864:20::e2b]) by sourceware.org (Postfix) with ESMTPS id D690B3858D1E for ; Mon, 19 Dec 2022 13:20:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D690B3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vs1-xe2b.google.com with SMTP id k185so8653603vsc.2 for ; Mon, 19 Dec 2022 05:20:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ZV2we8u7Mn8DVRLDRPCtFqgoN39Y52QaFLMPGfu7jU8=; b=ZDikA4BYA5mrI75T3QkPocB6wNJY51OqVYXv34M8FrEfu4fTCIIwgU8D+ENynsTGiz i9DGw1WzgWwYGIUOQEq8m71gwj6YandVO8HqWSiWNklWmEjVYBMlUAEVlA5kWcCpbOwC lgWE1iti7FqOB7qvxd2KTLDpeYyHifZgKuAzpFQgIZWVM6BB3hswL4sQJVk3QkyL5dv3 mbaap8uZXvskWxLSw6SmpbvmI/AhS/n+vBTQMGOfWVQ/MfxMzFkX/gUZC9s2DY++hWx2 5y/+qiWna3psZC54lvt9/E38aRQQ1FIWUJO2YaMER51OhxdqEvQGLtpxvpBAUkd+1JDZ gNVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZV2we8u7Mn8DVRLDRPCtFqgoN39Y52QaFLMPGfu7jU8=; b=k2GlRQubPRyaWXv2M3P8sx8PmodssL/p8FRV2/YYXoE4lonV6C2Gmc0mPaMCbsv/pS P3RVkVW9IR1tBl5faTYPexEIY3KOseRrCQjPZA2FR0dS+zjV08vnTRd0cZRIwiP7uOT5 CFWNgdPmXzBfRR8u051614oOARjG9mME3n9nHrfL8e8AytITO3N4B48UWHWkJ0Vcdki4 gxfjw2gDmY3oRyqwvcH6/Rt3dGOtoJMy+dl95XvvhTFj0J2UF+olMm+OajD43faYJsTe 9m3tXPPFtO+2qvJQGcmXYPsB7fksVESdcpC3Kytm5m/Mu6bjKdBErJb80TvGoST3Fmv7 XOig== X-Gm-Message-State: ANoB5pkvz5voA7B+lN2WQoX/kT/6je/gheZpWCzNAh//VZLqPddEIsgF KFpFj0hXVbcC35PRqm0pc9ztw+p1F+rt1dIeu1E= X-Google-Smtp-Source: AA0mqf50kWYNb15VJF0P0y7KLQMg0OS3wylaAFdBUms8uZ3ZfRVRfFL6zSq6TYOe99InBO99EOd3rCfMj354gIHr5w4= X-Received: by 2002:a05:6102:1009:b0:3b2:fc3d:3fbe with SMTP id q9-20020a056102100900b003b2fc3d3fbemr7680316vsp.77.1671456005935; Mon, 19 Dec 2022 05:20:05 -0800 (PST) MIME-Version: 1.0 References: <20221219010838.3878675-1-christoph.muellner@vrull.eu> <20221219010838.3878675-6-christoph.muellner@vrull.eu> In-Reply-To: <20221219010838.3878675-6-christoph.muellner@vrull.eu> From: Kito Cheng Date: Mon, 19 Dec 2022 21:19:54 +0800 Message-ID: Subject: Re: [PATCH v2 05/11] riscv: thead: Add support for the XTheadBa ISA extension To: Christoph Muellner Cc: gcc-patches@gcc.gnu.org, Kito Cheng , Jim Wilson , Palmer Dabbelt , Andrew Waterman , Philipp Tomsich , Jeff Law , Cooper Qu , Lifang Xia , Yunhai Shang , Zhiwei Liu Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: LGTM with a nit: ... > + "TARGET_XTHEADBA > + && (INTVAL (operands[2]) >= 0) && (INTVAL (operands[2]) <= 3)" IN_RANGE(INTVAL(operands[2]), 0, 3) and I am little bit suppress it can be zero > + "th.addsl\t%0,%1,%3,%2" > + [(set_attr "type" "bitmanip") > + (set_attr "mode" "")])