public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kito Cheng <kito.cheng@gmail.com>
To: Matthias Klose <doko@ubuntu.com>
Cc: Jim Wilson <jimw@sifive.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] RISC-V: Canonicalize --with-arch
Date: Sun, 6 Dec 2020 11:35:40 +0800	[thread overview]
Message-ID: <CA+yXCZD52WWm=0F9gE1o0cdkFwsJ9NzK=+-GhbABFbmTPvm0mA@mail.gmail.com> (raw)
In-Reply-To: <4068032b-aaa4-5eae-4955-f3d0cfad2e71@ubuntu.com>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98152

Andreas Schwab has created a bug entry for this issue,
using awk or shell should be fine to get the same functionality, but
it might take some time,
so I plan to add some checking to detect python, python2 or python3,
and skip this step if none of above is found.
The arch string canonicalize is not a must, it's a kind of improvement,
trying to reduce the build # of multi-lib, so I think skip that should
not be a problem if python is not available.

On Fri, Dec 4, 2020 at 10:41 PM Matthias Klose <doko@ubuntu.com> wrote:
>
> On 12/4/20 2:38 PM, Matthias Klose wrote:
> > On 12/4/20 9:07 AM, Kito Cheng via Gcc-patches wrote:
> >> Committed, thanks :)
> >>
> >> On Thu, Dec 3, 2020 at 8:51 AM Jim Wilson <jimw@sifive.com> wrote:
> >>>
> >>> On Tue, Dec 1, 2020 at 12:13 AM Kito Cheng <kito.cheng@sifive.com> wrote:
> >>>>
> >>>>  - We would like to canonicalize the arch string for --with-arch for
> >>>>    easier handling multilib, so split canonicalization part to a stand
> >>>>    along script to shared the logic.
> >>>>
> >>>> gcc/ChangeLog:
> >>>>
> >>>>         * config/riscv/multilib-generator (arch_canonicalize): Move
> >>>>         code to arch-canonicalize, and call that script to canonicalize arch
> >>>>         string.
> >>>>         (canonical_order): Move code to arch-canonicalize.
> >>>>         (LONG_EXT_PREFIXES): Ditto.
> >>>>         (IMPLIED_EXT): Ditto.
> >>>>         * config/riscv/arch-canonicalize: New.
> >>>>         * config.gcc (riscv*-*-*): Canonicalize --with-arch.
> >>>
> >>>
> >>> Looks OK to me.
> >
> > that breaks the bootstrap if python is not available. The python command might
> > not be available, so please check for python3, python, or python2.
>
> same for config/riscv/arch-canonicalize

      reply	other threads:[~2020-12-06  3:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01  8:13 Kito Cheng
2020-12-03  0:51 ` Jim Wilson
2020-12-04  8:07   ` Kito Cheng
2020-12-04 13:38     ` Matthias Klose
2020-12-04 13:43       ` Jakub Jelinek
2020-12-04 14:41       ` Matthias Klose
2020-12-06  3:35         ` Kito Cheng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+yXCZD52WWm=0F9gE1o0cdkFwsJ9NzK=+-GhbABFbmTPvm0mA@mail.gmail.com' \
    --to=kito.cheng@gmail.com \
    --cc=doko@ubuntu.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jimw@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).